System Heal

[Advice D.]

Not sure if it's intended or not, but for some reason it blocks all heals by default.

 

[tooltiperror]

Why not try to make it an independent library of Event?

 

[Jesus4Lyf]

Why not try to make it an independent library of Event?

And that's a good idea why? More code duplication?

 

[tooltiperror]

I`ve, personally, always found more requirements as a turn off.

 

[Lyerae]

Yeah. It's a little annoying sometimes to have to import a system you weren't originally planning on using

 

[quraji]

There's no reason that this shouldn't use Event. It should however note that it requires it in the post and provide a link.

 

[tooltiperror]

Also.

//
//      @@   @@   @@@@@@    @@@    @    
//      @@   @@   @@       @   @   @
//      @@@@@@@   @@@@@   @ @@@ @  @
//      @@   @@   @@      @     @  @
//      @@   @@   @@@@@@  @     @  @@@@@@@@

The L looks a bit long.

 

[kingkingyyk3]

Also.

//
//      @@   @@   @@@@@@    @@@    @    
//      @@   @@   @@       @   @   @
//      @@@@@@@   @@@@@   @ @@@ @  @
//      @@   @@   @@      @     @  @
//      @@   @@   @@@@@@  @     @  @@@@@@@@

The L looks a bit long.

My art skill is bad. :banghead:

 

[tooltiperror]

I suggest you re-realease a healing snippet, with just a global heal with no healer, and one that uses a healer and a healed unit. Then, you can just add to that over time, and it may be approved quicker.

 

[kingkingyyk3]

I suggest you re-realease a healing snippet, with just a global heal with no healer,

call HealUnit(target,target,1.,HEAL_TYPE_NORMAL)

 

[Kenny]

I think you really need to change your:

public function GetTriggerUnit takes nothing returns unit

To:

public function GetTarget takes nothing returns unit

To match the rest of the system.

And maybe change:

static method make takes nothing returns thistype
    set Counter = Counter + 1
    return Counter
endmethod

To:

static method register takes nothing returns thistype
    set Counter = Counter + 1
    return Counter
endmethod

To me, register makes much more sense, and looks nicer.

 

[tooltiperror]

I think you really need to change your:

static method register takes nothing returns thistype
    set Counter = Counter + 1
    return Counter
endmethod

To me, register makes much more sense, and looks nicer.

Can`t that be inlined?

static method register takes nothing returns thistype
     return Counter + 1
endmethod

 

[Deaod]

That wont increase Counter.

 

[tooltiperror]

...Why not?

 

[Deaod]

because theres no [ljass]set Counter = ...[/ljass] in that function.

 

[tooltiperror]

 function colorString takes string whichString returns string
     return |CFFFF0000+whichString+|R
 endfunction

Returns red, though.

 

[BRUTAL]

So?
Thats because there is a colour code in front of it.
Counter+1 will just return the value of counters plus one, not increase it by one.

 

[tooltiperror]

Oh, I get it now.

 

[kingkingyyk3]

Updated.

 

[kingkingyyk3]

Update again. Fully working version and demo map posted.