System Heal

Discussion in 'Systems and Snippets' started by kingkingyyk3, Dec 16, 2009.

  1. Advice D.

    Advice D. New Member

    Ratings:
    +11 / 0 / -0
    Not sure if it's intended or not, but for some reason it blocks all heals by default.
     
  2. tooltiperror

    tooltiperror Super Moderator Staff Member

    Ratings:
    +233 / 0 / -0
    Why not try to make it an independent library of Event?
     
  3. Jesus4Lyf

    Jesus4Lyf Good Idea™

    Ratings:
    +394 / 0 / -0
    And that's a good idea why? More code duplication?
     
  4. tooltiperror

    tooltiperror Super Moderator Staff Member

    Ratings:
    +233 / 0 / -0
    I`ve, personally, always found more requirements as a turn off.
     
  5. Lyerae

    Lyerae I keep popping up on this site from time to time.

    Ratings:
    +105 / 0 / -0
    Yeah. It's a little annoying sometimes to have to import a system you weren't originally planning on using
     
  6. quraji

    quraji zap

    Ratings:
    +143 / 0 / -0
    There's no reason that this shouldn't use Event. It should however note that it requires it in the post and provide a link.
     
  7. tooltiperror

    tooltiperror Super Moderator Staff Member

    Ratings:
    +233 / 0 / -0
    Also.

    JASS:
    //
    //      @@   @@   @@@@@@    @@@    @    
    //      @@   @@   @@       @   @   @
    //      @@@@@@@   @@@@@   @ @@@ @  @
    //      @@   @@   @@      @     @  @
    //      @@   @@   @@@@@@  @     @  @@@@@@@@


    The L looks a bit long.
     
  8. kingkingyyk3

    kingkingyyk3 Visitor (Welcome to the Jungle, Baby!)

    Ratings:
    +216 / 0 / -0
    My art skill is bad. :banghead:
     
  9. tooltiperror

    tooltiperror Super Moderator Staff Member

    Ratings:
    +233 / 0 / -0
    I suggest you re-realease a healing snippet, with just a global heal with no healer, and one that uses a healer and a healed unit. Then, you can just add to that over time, and it may be approved quicker.
     
  10. kingkingyyk3

    kingkingyyk3 Visitor (Welcome to the Jungle, Baby!)

    Ratings:
    +216 / 0 / -0
    I suggest you re-realease a healing snippet, with just a global heal with no healer,
    JASS:
    call HealUnit(target,target,1.,HEAL_TYPE_NORMAL)
     
  11. Kenny

    Kenny Back for now.

    Ratings:
    +202 / 0 / -0
    I think you really need to change your:

    JASS:
    public function GetTriggerUnit takes nothing returns unit


    To:

    JASS:
    public function GetTarget takes nothing returns unit


    To match the rest of the system.

    And maybe change:

    JASS:
    static method make takes nothing returns thistype
        set Counter = Counter + 1
        return Counter
    endmethod


    To:

    JASS:
    static method register takes nothing returns thistype
        set Counter = Counter + 1
        return Counter
    endmethod


    To me, register makes much more sense, and looks nicer.
     
  12. tooltiperror

    tooltiperror Super Moderator Staff Member

    Ratings:
    +233 / 0 / -0
    Can`t that be inlined?

    JASS:
    
    static method register takes nothing returns thistype
         return Counter + 1
    endmethod
     
  13. Deaod

    Deaod Member

    Ratings:
    +6 / 0 / -0
    That wont increase Counter.
     
  14. tooltiperror

    tooltiperror Super Moderator Staff Member

    Ratings:
    +233 / 0 / -0
    ...Why not?
     
  15. Deaod

    Deaod Member

    Ratings:
    +6 / 0 / -0
    because theres no set Counter = ... in that function.
     
  16. tooltiperror

    tooltiperror Super Moderator Staff Member

    Ratings:
    +233 / 0 / -0
    JASS:
    
     function colorString takes string whichString returns string
         return |CFFFF0000+whichString+|R
     endfunction


    Returns red, though.
     
  17. BRUTAL

    BRUTAL I'm working

    Ratings:
    +118 / 0 / -0
    So?
    Thats because there is a colour code in front of it.
    Counter+1 will just return the value of counters plus one, not increase it by one.
     
  18. tooltiperror

    tooltiperror Super Moderator Staff Member

    Ratings:
    +233 / 0 / -0
    Oh, I get it now.
     
  19. kingkingyyk3

    kingkingyyk3 Visitor (Welcome to the Jungle, Baby!)

    Ratings:
    +216 / 0 / -0
    Updated.
     
  20. kingkingyyk3

    kingkingyyk3 Visitor (Welcome to the Jungle, Baby!)

    Ratings:
    +216 / 0 / -0
    Update again. Fully working version and demo map posted. ;)
     

Share This Page