Leak or not?

[lucifekit]

Please see my map,i use leak check and my map don't have any leak(you can see again) but handle counter go up never stop after i use the skill.Can you find the leak which leak check cannot find?

 

[lucifekit]

Up topic for request quicker reply

Thanks you all.

 

[Darthfett]

4. Keep in mind that you may not be answered immediately. Be patient. If your thread is clean, reasonable, and easy to understand, it will be answered.
5. We here at TH.net are not a Warcraft III editing service. Do not expect for you to hand over your map to us and have it handed back magically complete. It won't happen. So don't try.
There are cases where the problem can't be readily seen in the posts, in which case you will be asked to upload the map for someone to look at, but they will only be looking at that one problem.

..

If 24 hours have passed, you were the last one to post, and your question has not been answered, you may bump your thread. But the 24 hour limit will be enforced, so be careful.

We're not just going to look through an entire map.

1. Post what triggers you believe to be problematic.
2. Have you read a tutorial on finding and fixing leaks yourself (without the program)?
3. "The skill" - do you have a custom triggered spell in your map? Did you make it yourself? Post the code/trigger here so we can take a look.

 

[lucifekit]

Yeah sorry.

But my spell is based on autocast arrow ability and it have 7 trigger(not long to much).And the handle counter you can see when testing map so i don't post all my trigger here.Viewing the map is the best i think so.I ask many mapmaker in my region but they don't know like me.

Yeah i reads tutorial on finding and fixing leaks.(leak check for more sure)

Sorry again for not reading the rule,near 24 hours

 

[lucifekit]

If 24 hours have passed, you were the last one to post, and your question has not been answered, you may bump your thread. But the 24 hour limit will be enforced, so be careful.

Sad.......

Hic,so i bump my thread,help me plz,maybe it's the one that make my map disconnect so fast T____T

 

[lucifekit]

Is it really tough that no one can explain this problem?

 

[perkeyone]

which skill causes the handle counter to go up?
maybe you could post the triggers for that one spell.
then we could look at it and tell you.
all you have to do is right click the trigger and "copy as text"
then paste it here inbetween [WC3*][/WC3*]tags
(without the *'s)
most people would rather not download your map and try every skill just to find the one specific thing you are trying to fix
so help us help you

 

[Artificial]

Your problem lies in NKHN Move:

Set TempGroup = (Units of type Nhan Kiem Hop Nhat)
Set TempGroup2 = (Units of type Effect NKHN)

(Units of type ...) happens to leak in a way you cannot fix using any simple custom scripts (like some other GUI actions seem to do, too).

A relatively easy way of fixing this:

1. Create a variable called 'TempUnitType' of type Unit-Type
2. Add this code to your map header (At the top of the list of triggers there's your maps name prefixed by a map image. Click on that to see the map header):
   

   function GetUnitsOfTypeIdAllLeakless takes integer unitid returns group
       local group g = CreateGroup()
       local integer index = 0
       set bj_lastCreatedGroup = CreateGroup()
       
       loop
           set bj_groupEnumTypeId = unitid
           call GroupEnumUnitsOfPlayer(g, Player(index), filterGetUnitsOfTypeIdAll)
           call GroupAddGroup(g, bj_lastCreatedGroup)
           set index = index + 1
           exitwhen index == bj_MAX_PLAYER_SLOTS
       endloop
       
       call DestroyGroup(g)
       set g = null
       
       return bj_lastCreatedGroup
   endfunction

3. Change these:
   

   Set TempGroup = (Units of type Nhan Kiem Hop Nhat)
   Set TempGroup2 = (Units of type Effect NKHN)

   to these:
   

   Set TempUnitType = Effect NKHN
   Custom script:   set udg_TempGroup = GetUnitsOfTypeIdAllLeakless(udg_TempUnitType)
   Set TempUnitType = Nhan Kiem Hop Nhat
   Custom script:   set udg_TempGroup2 = GetUnitsOfTypeIdAllLeakless(udg_TempUnitType)

A better way of fixing this:

1. Learn Jass. ^_^

> [WC3*][/WC3*]
You could btw use the [noparse][noparse][/noparse][/noparse] tags instead of those * inside the tags. [noparse][noparse]

[/noparse][/noparse] would transform into [noparse]

[/noparse] (see, no stars and it's still as plain text? ).

 

[perkeyone]

You could btw use the [noparse][noparse][/noparse][/noparse] tags instead of those * inside the tags. [noparse][noparse]

[/noparse][/noparse] would transform into [noparse]

[/noparse] (see, no stars and it's still as plain text? ).

nice
thanks i wondered about that
+rep

ps were tags case sensitive before?
i used to have trouble with getting them to work when not all caps

 

[LaZyNation43]

You also have a leak in your timer.

event
    Events
        Time - Every 2.00 seconds of game time
    Conditions
    Actions
        Unit Group - Pick every unit in TakeDamGroup and do (Actions)
            Loop - Actions
                Game - Display to (All players) the text: (Take Damage group : + (Name of (Picked unit)))

It can cause major lag if your game lasts a while. I forgot the website that shows how to clear timers up =/ but its in war3c.net I believe.
Goodluck bud

 

[lucifekit]

Your problem lies in NKHN Move:

Set TempGroup = (Units of type Nhan Kiem Hop Nhat)
Set TempGroup2 = (Units of type Effect NKHN)

(Units of type ...) happens to leak in a way you cannot fix using any simple custom scripts (like some other GUI actions seem to do, too).

....

Wow,so wonderful,i did it and the number didn't go up anymore.(but it up and down between 1-2,but it don't matter)

Thanks you so much :X.I added reputation to you :X.And all else 4 helping me

Except unit of type,is there any else functions leaks like it?