Need help with trigger leaks

[WBL]

I don't know where my other leaks are. If anyone more experienced can help will be appreciated.

The trigger runs every 4 seconds. Selects all enemies and make them attack units in range or else random unit.

Thanks T.s.e for finding a leak. I think there's more because it still lags a little.

Attack
    Events
    Conditions
    Actions
        -------- ----- Attack Units in Range ----- --------
        Set Temp_Group9 = (Units owned by Player 11 (Dark Green))
        Unit Group - Pick every unit in Temp_Group9 and do (Actions)
            Loop - Actions
                Set Temp_Point = (Position of Temp_Unit)
                Set FoundTarget = False
                For each (Integer intRange) from 1 to 4, do (Actions)
                    Loop - Actions
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                FoundTarget Equal to False
                            Then - Actions
                                Set Temp_Real = Distance[intRange]
                                Set Temp_Group10 = (Units of type MarineType)
                                Set Temp_Group2 = (Units within Temp_Real of Temp_Point matching ((((Matching unit) is in Temp_Group10) Equal to True) and (((Matching unit) is alive) Equal to True)))
                                Custom script:   call DestroyGroup (udg_Temp_Group10)
                                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                    If - Conditions
                                        (Number of units in Temp_Group2) Equal to 0
                                    Then - Actions
                                        Custom script:   call DestroyGroup (udg_Temp_Group2)
                                    Else - Actions
                                        Set Temp_Point2 = (Position of (Random unit from Temp_Group2))
                                        Unit - Order (Picked unit) to Attack-Move To Temp_Point2
                                        Custom script:   call RemoveLocation (udg_Temp_Point2)
                                        Custom script:   call DestroyGroup (udg_Temp_Group2)
                                        Set FoundTarget = True
                            Else - Actions
                Custom script:   call RemoveLocation (udg_Temp_Point)
                -------- ----- If NO Units in Range ----- --------
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        FoundTarget Equal to False
                    Then - Actions
                        Set Temp_PGroup = (All allies of Player 1 (Red))
                        Set Temp_Group10 = (Units of type MarineType)
                        Set Temp_Group2 = (Units owned by (Random player from Temp_PGroup) matching ((((Matching unit) is alive) Equal to True) and (((Matching unit) is in Temp_Group10) Equal to True)))
                        Custom script:   call DestroyGroup (udg_Temp_Group10)
                        Set Temp_Point6 = (Position of (Random unit from Temp_Group2))
                        Unit - Order (Picked unit) to Attack-Move To Temp_Point6
                        Custom script:   call RemoveLocation (udg_Temp_Point6)
                        Custom script:   call DestroyGroup (udg_Temp_Group2)
                        Custom script:   call DestroyForce (udg_Temp_PGroup)
                    Else - Actions
        Custom script:   call DestroyGroup (udg_Temp_Group9)

 

[T.s.e]

• (Units of type MarineType)

Doesn't this leak if it isn't set to a variable?

• Do nothing

Eew, don't do this, just leave the Else - Actions field blank.

Those are the only two I could find. Do Nothing doesn't leak, but it's the single most useless function in the whole of GUI and JASS combined. It doesn't do anything, why use it...?

 

[WBL]

ah, thank you thank you.

 

[LurkerAspect]

Do Nothing doesn't leak, but it's the single most useless function in the whole of GUI and JASS combined. It doesn't do anything, why use it...?

It's for self re-assurance

If I see an If/Then/Else action where the Else is empty, I can't help thinking that there must be some kind of leak or something. I know there isn't any, but I still put it there anyway.

 

[WBL]

It's for self re-assurance

If I see an If/Then/Else action where the Else is empty, I can't help thinking that there must be some kind of leak or something. I know there isn't any, but I still put it there anyway.

Agreed.