Reversing a singly linked list

jonas

Ultra Cool Member
Code:
rec_reverse(last_of_rev,to_rev) = if to_rev != nil:
  next_rev = to_rev.next;
  to_rev.next = last_of_rev;
  rec_reverse(to_rev,next_rev)

reverse(to_rev) = rec_reverse(nil, to_rev)
Code:
reversed list    list to be reversed
(|<-()<-...<-()  ,  []->()->...->()->|)
after one recurisve step becomes:
(|<-()<-...<-()<-[]  ,  ()->...->()->|)
at the end of recursion becomes:
(|<-()<-...<-()<-[]<-()<-...<-()  ,  |)
 
Last edited:

Accname

2D-Graphics enthusiast
How about this?
Code:
    public void reverse() {
       Node prev = null;
       Node current = first;
       while (current != null) {
         Node next = current.next;
         current.next = prev;
         prev = current;
         current = next;
       }
       first = prev;
     }
This is using a simple while-loop.
Here a full example with test case:
Code:
  public static void main(final String[] args) {
     LList l = new LList();
     l.first = new Node("A");
     l.first.next = new Node("B");
     l.first.next.next = new Node("C");
     l.first.next.next.next = new Node("D");
     l.first.next.next.next.next = new Node("E");
     l.first.next.next.next.next.next = new Node("F");
    
     System.out.println(l);
     System.out.println();
     l.reverse();
     System.out.println(l);
     System.out.println();
   }
  
   public static class LList {
     Node first;
    
     public void reverse() {
       Node prev = null;
       Node current = first;
       while (current != null) {
         Node next = current.next;
         current.next = prev;
         prev = current;
         current = next;
       }
       first = prev;
     }
    
     @Override
     public String toString() {
       StringBuilder sb = new StringBuilder();
       Node current = first;
       while (current != null) {
         sb.append(current.value);
         sb.append(" ");
         current = current.next;
       }
       return sb.toString();
     }
   }
  
   static class Node {
     Object value;
     Node next;
    
     public Node(Object value) {
       this.value = value;
     }
    
   }
Output:
A B C D E F

F E D C B A
 

Accname

2D-Graphics enthusiast
Its not quite the same depending on the execution enviroment and language you are using. A loop is much better in java than recursion. Sure, at some point the JIT will jump in and might improve the recursive method, but until then the loop will outperform the recursion every time.
 

jonas

Ultra Cool Member
Its not quite the same depending on the execution enviroment and language you are using. A loop is much better in java than recursion. Sure, at some point the JIT will jump in and might improve the recursive method, but until then the loop will outperform the recursion every time.
Note that I was not giving a java program... At the conceptual level the two are identical, and that was the level in which I was giving the algorithm. Yes, in a given actual implementation the performance between the two may differ significantly, and one of them may run out of memory while the other may not (this is actually the bigger issue). From my point of view, you have simply given the idiomatic Java implementation of the conceptual algorithm above. Maybe we can find common ground here?
 

Accname

2D-Graphics enthusiast
You have to go to a veeeeerrrryyy high conceptual level to call these two implementations equal. Sure, in the end they do the same thing because thats what they are supposed to do. But both use different syntactic and semantic constructs some of which may or may not be available in a given language / runtime enviroment.
 

jonas

Ultra Cool Member
You have to go to a veeeeerrrryyy high conceptual level to call these two implementations equal. Sure, in the end they do the same thing because thats what they are supposed to do. But both use different syntactic and semantic constructs some of which may or may not be available in a given language / runtime enviroment.
The first one is not an implementation, it's a description of the algorithm. There might not even be a compiler or interpreter for that language.
I wouldn't just say that they do the same thing, I'd go as far to say they do it the *same way*, namely by going through the pointers and flipping them one by one. Recursion and iteration just say "repeatedly do this", or "repeatedly do this until".
 

Accname

2D-Graphics enthusiast
Thats a little to vague for my taste. A loop is an actual syntactical structure defined by a language. Recursion is a method of software-developement that can be used in most languages but there is no syntactical component to it in any language I know of. There are many different languages, some of which do not have loops. Some of them do not have the concept of methods either but they have loops. Some have methods but do not allow for recursion, etc.
I can not say with a straight face that these two things are "the same". They might be very similar, they might be exchangeable in most enviroments, but they are not "the same".
 

jonas

Ultra Cool Member
Well, I understand that you live in the practical world of building real software, where there are very clearly specific definitions and precise differences for these definitions. If I would develop a Java program, I would use a while loop, not a recursive method call, just like you have.

I on the other hand live in the theoretical world of building language models and proving that can be compiled correctly to run on real machines, so I'm looking more at the conceptual level of what languages can do (in general) and how it would be compiled and run, and so in my world they use the same mechanisms and I don't distinguish between them. Whether a language implements "doing the same thing over and over" by function recursion or loop recursion or a recursion operator (like system T) is completely irrelevant to me; if it has a way of "doing the same thing over and over", it needs to do a) b) and c) to compile correctly for x86.
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Blackveiled Blackveiled:
    count on it then cause you don't live that far from me hah
  • The Helper The Helper:
    really that is cool!
  • The Helper The Helper:
    Hey Tom I added a new Weird tag to the News Prefixes
  • The Helper The Helper:
    What is up Blackveiled?
  • Blackveiled Blackveiled:
    Chillin', lurkin'. :D
  • The Helper The Helper:
    I am working on a bunch of site projects right now doing a bunch of behind the scenes stuff and trying to clean up some stuff that I let slide when I got lazy with the site for a few years...
  • The Helper The Helper:
    Are you in Houston Blackveiled or just in Texas?
  • Blackveiled Blackveiled:
    Houston
  • Blackveiled Blackveiled:
    I've been living here since 2014.
  • The Helper The Helper:
    OK banlord we need to get together soon! The only other member of the site I know in Houston is XXX Conan
  • The Helper The Helper:
    and he does not want none lol
  • The Helper The Helper:
    he put up a picture of his mom one time and she was HOT!
  • The Helper The Helper:
    I wish we still had that
  • Blackveiled Blackveiled:
    Lmao you scared him off I see.
  • The Helper The Helper:
    he will be back
  • The Helper The Helper:
    Conan was like 12 when he started here
  • The Helper The Helper:
    I literally think I was his male role model
  • Blackveiled Blackveiled:
    Yeah I was 12 when I started here as well.
  • The Helper The Helper:
    you guys were just kids
  • The Helper The Helper:
    I was in my 30s when i got the Blizzard MVP
  • The Helper The Helper:
    I am 53
  • Wizard Wizard:
    Happy Birthday!
  • The Helper The Helper:
    not my birthday
  • The Helper The Helper:
    but thanks lol
  • Blackveiled Blackveiled:
    and I'll be 30 in January lmao

    Members online

    No members online now.

    Affiliates

    Hive Workshop NUON Dome World Editor Tutorials

    Network Sponsors

    Apex Steel Pipe - Buys and sells Steel Pipe.
    Top