Server splits when creating units in TD

[Xenoche]

Hi one and all and thank you for your attention.
I have a strange occurance in a TD ive created where when the first creeps spawn some or all the players are disconnected. I have looked around for an answear, but have not found another with the same problem.

Here is the spawning code that triggers every 45 seconds, thus creating another wave of creep. In this instance Player 11 is the creep computer player.
The spawn switch varable is used to turn on(1) and off(0) each players spawn should a player leave ect...

creep create
    Events
        Time - Every 45.00 seconds of game time
    Conditions
    Actions
        Set Level_Number = (Level_Number + 1)
        Leaderboard - Change the title of (Last created leaderboard) to (|c0000cdf9HoS TD - |r + (|c0000cdf9Round |r + (String(Level_Number))))
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                spawnswitch[1] Equal to 1
            Then - Actions
                Unit - Create Monster_Amount creature[Level_Number] for Player 11 (Dark Green) at (Center of creepstart[1]) facing Default building facing degrees
            Else - Actions
                Do nothing
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                spawnswitch[2] Equal to 1
            Then - Actions
                Unit - Create Monster_Amount creature[Level_Number] for Player 11 (Dark Green) at (Center of creepstart[2]) facing Default building facing degrees
            Else - Actions
                Do nothing
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                spawnswitch[3] Equal to 1
            Then - Actions
                Unit - Create Monster_Amount creature[Level_Number] for Player 11 (Dark Green) at (Center of creepstart[3]) facing Default building facing degrees
            Else - Actions
                Do nothing
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                spawnswitch[4] Equal to 1
            Then - Actions
                Unit - Create Monster_Amount creature[Level_Number] for Player 11 (Dark Green) at (Center of creepstart[4]) facing Default building facing degrees
            Else - Actions
                Do nothing
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                spawnswitch[5] Equal to 1
            Then - Actions
                Unit - Create Monster_Amount creature[Level_Number] for Player 11 (Dark Green) at (Center of creepstart[5]) facing Default building facing degrees
            Else - Actions
                Do nothing
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                spawnswitch[6] Equal to 1
            Then - Actions
                Unit - Create Monster_Amount creature[Level_Number] for Player 11 (Dark Green) at (Center of creepstart[6]) facing Default building facing degrees
            Else - Actions
                Do nothing
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                spawnswitch[7] Equal to 1
            Then - Actions
                Unit - Create Monster_Amount creature[Level_Number] for Player 11 (Dark Green) at (Center of creepstart[7]) facing Default building facing degrees
            Else - Actions
                Do nothing
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                spawnswitch[8] Equal to 1
            Then - Actions
                Unit - Create Monster_Amount creature[Level_Number] for Player 11 (Dark Green) at (Center of creepstart[8]) facing Default building facing degrees
            Else - Actions
                Do nothing
        Game - Display to (All players) the text: ((Level -  + (String(Level_Number))) + (    + (Name of (Last created unit))))

Note that players are only disconnected the FIRST time this trigger runs.
Any help would be greatly appreciated.

 

[Rad]

(Center of creepstart[1])

Every time you take the center (or random point) of a region, or position of unit/destructible, or anything else that was not a preset point (location) to begin with, it will create a memory leak.

Memory leaks will add up, causing server splits. You have like 8 memory leaks every 45 seconds, multiplied by 'Monster_Amount'.

To fix a point (or location) leak use something like this:

Set [b]Loc[/b] = (Center of creepstart[1])
Unit - Create Monster_Amount creature[Level_Number] for Player 11 (Dark Green) at [b]Loc[/b] facing Default building facing degrees 
Custom script:   call RemoveLocation(udg_[b]Loc[/b])

Do note that this will remove the point after use, removing the leak but in turn removing ability to refer to it again.

 

[phyrex1an]

But that leak is way to small to cause serversplits by itself.
Another way to fix it is to use a global point array varaible that newer change, insteed of the global region array creepstart.

2 other things that may cause problems, but i dont think they lead to serversplits:
1. The size of spawnswitch. If the size is to small, it will be empty and cannot be used in conditions. Empty is not the same as = 0.
2. The amount of units created. If you create more than ~20 units at the same time it will create alot of lag. At the same time is it when you have no waits betwen the creation actions.

 

[xPheRe]

Keep It Stupidly Simple

creep create
    Events
        Time - Every 45.00 seconds of game time
    Conditions
    Actions
        Set Level_Number = (Level_Number + 1)
        Leaderboard - Change the title of (Last created leaderboard) to (|c0000cdf9HoS TD - |r + (|c0000cdf9Round |r + (String(Level_Number))))
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                spawnswitch[1] Equal to 1
            Then - Actions
                Unit - Create Monster_Amount creature[Level_Number] for Player 11 (Dark Green) at (Center of creepstart[1]) facing Default building facing degrees
            Else - Actions
                Do nothing
        (...)
            If - Conditions
                spawnswitch[8] Equal to 1
            Then - Actions
                Unit - Create Monster_Amount creature[Level_Number] for Player 11 (Dark Green) at (Center of creepstart[8]) facing Default building facing degrees
            Else - Actions
                Do nothing
        Game - Display to (All players) the text: ((Level -  + (String(Level_Number))) + (    + (Name of (Last created unit))))

Why using arrays if you don't use it's potential? Always loop everything as you can.
Also, as phyrex1an said, use a global point array to store the 8 "center of location" points in order to spawn the monsters

Creep create
    Events
        Time - Every 45.00 seconds of game time
    Conditions
    Actions
        Set Level_Number = Level_Number + 1
        Leaderboard - Change the title of (Last created leaderboard) to (|c0000cdf9HoS TD - |r + (|c0000cdf9Round |r + (String(Level_Number))))
        For Integer A between 1 and 8
            If spawnswitch[Integer A] equal to 1 then
                Unit - Create Monster_Amount creature[Level_Number] for Player 11 (Dark Green) at spawnpoint[Integer A] facing Default building facing degrees
        Game - Display to (All players) the text: ((Level -  + (String(Level_Number))) + (    + (Name of (Last created unit))))

Events
    Map initialization
Actions
    For Integer A between 1 and 8
        Set spawnpoint[Integer A] = Center of CreepStart[Integer A]

Much shorter (tons!) and leakproof

 

[Xenoche]

WOW i must say this is a lot of vitally usefull information, for me, and for anyone else that should ponder over this info, thx guys a whole heap, and for the short reply time its amazing. Ill try these ideas and with any luck stop these annoying splits. THX