System Attack Detection

[Cohadar]

A few remarks if I may.

System looks good from general point of view.
Big plus is that it is easy to use.

You should fix UnitEntersWorld to NOT register dummy casters.
In fact you should probably make a function like this:

    private function ExcludeUnit takes unit whichUnit returns boolean
        if GetUnitTypeId(whichUnit) == UID_DUMMY_CASTER then
            return true
        endif
        if GetUnitTypeId(whichUnit) == UID_SPECIAL_UNITA then
            return true
        endif
        //....
        // add your own units here
    endfunction

And then use it to check if unit should be registered with the engine.

This does not work

        private method onDestroy takes nothing returns nothing 
            //Creating this to make it private.
        endmethod

People can still call AD.destroy() you made onDestroy private, not destroy.
Do this:

        private method onDestroy takes nothing returns nothing 
            call BJDebugMsg("FATAL ERROR: AD struct destroyed")
        endmethod

 

[Sim]

Refer to Post #12 for updates.

 

[gref]

I took the subtle hint, and tidied it all up. Thanks Daxtreme.

As always, people who look at my system and give implementation suggestions and advice will be greatly appreciated.

 

[Cohadar]

Did I double post up there or Daxtreme decided to eat someones post for lunch?

@gref: move stuff from post #12 to first post?

 

[gref]

Daxtreme's been having fun pruning.

As it is all the important stuff is in the first post I think. Post 12 was just me telling people what I added, it's changelogged now anyway.

 

[pablo1517]

Hi! I tried to use both version.

While JASS version didn't work on my map AT ALL.
I have problems with GUI versions coz after I added everything what's needed to my map, units that got hit are getting orb effect on them for some reason ;/ and by that I mean they are getting frozen (slowed) and they have frost nova effect on them...

HALP

EDIT: I know already what was wrong. When I copied ability and buff my WE changed buff in ability to something other coz AD_Buff was missing. Fix'd, sry.