Decimals, Possible?

[Larcenist]

Attribute Gain
    Events
        Unit - A unit Gains a level
    Conditions
        (Unit-type of (Triggering unit)) Equal to Paladin
    Actions
        Set CurrentStr = (Strength of (Triggering unit) (Exclude bonuses))
        Set StrGain = ((Real(CurrentStr)) x 1.10)
        Set StrGainFinal = ((Integer((StrGain + 0.50))) - CurrentStr)
        Hero - Modify Strength of (Triggering unit): Add StrGainFinal

Something like that maybe? Added an extra variable cause I lost myself in all the conversions D:

 

[GooS]

Yah my looks somewhat like that

I did some very slow editing in my post ;D

Thx

PS: ((Integer((StrGain + 0.50))) - CurrentStr) yah I think I'll do it like that instead for a more neat code

 

[GooS]

Ok so I want to learn JASS so I read Vexorians guide did some small work and such.

But then I thought I might redo this trigger into JASS, so first of I just converted it into custom text just to get some basics.

After that I removed the global variables and set some locals instead (also removed one variable only needed two), well here's the code:

function Trig_Level_Increase_Conditions takes nothing returns boolean
    if ( not ( IsUnitType(GetTriggerUnit(), UNIT_TYPE_HERO) == true ) ) then
        return false
    endif
    return true
endfunction

function Trig_Level_Increase_UnitType takes nothing returns boolean
    if ( not ( GetUnitTypeId(GetTriggerUnit()) == 'H000' ) ) then
        return false
    endif
    return true
endfunction

function Trig_Level_Increase_Actions takes nothing returns nothing
    //=Creating Local Variables
    local integer array Att
    local real array AttGain
    if ( Trig_Level_Increase_UnitType() ) then
        //=Setting Variable Values #1, STR #2, AGI  #3, INT
        set Att[1] = GetHeroStatBJ(bj_HEROSTAT_STR, GetTriggerUnit(), false)
        set Att[2] = GetHeroStatBJ(bj_HEROSTAT_AGI, GetTriggerUnit(), false)
        set Att[3] = GetHeroStatBJ(bj_HEROSTAT_INT, GetTriggerUnit(), false)
        set AttGain[1] = ( I2R(Att[1]) * 1.10 )
        set AttGain[2] = ( I2R(Att[2]) * 1.09 )
        set AttGain[3] = ( I2R(Att[3]) * 1.085 )
        set Att[1] = (R2I( AttGain[1] + 0.99 ))
        set Att[2] = (R2I( AttGain[2] + 0.99 ))
        set Att[3] = (R2I( AttGain[3] + 0.99 ))
        call ModifyHeroStat( bj_HEROSTAT_STR, GetTriggerUnit(), bj_MODIFYMETHOD_SET, ( Att[1] ) )
        call ModifyHeroStat( bj_HEROSTAT_AGI, GetTriggerUnit(), bj_MODIFYMETHOD_SET, ( Att[2] ) )
        call ModifyHeroStat( bj_HEROSTAT_INT, GetTriggerUnit(), bj_MODIFYMETHOD_SET, ( Att[3] ) )
    else
    endif
endfunction

//===========================================================================

function InitTrig_Level_Increase takes nothing returns nothing
    set gg_trg_Level_Increase = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Level_Increase, EVENT_PLAYER_HERO_LEVEL )
    call TriggerAddCondition( gg_trg_Level_Increase, Condition( function Trig_Level_Increase_Conditions ) )
    call TriggerAddAction( gg_trg_Level_Increase, function Trig_Level_Increase_Actions )
endfunction

As for the question, In triggers such as these is there any way to shorten them down, like putting 2 of the functions together, like placing the condition within the function that sets the variables or do they have to call for the conditions when running that function?

Don't worry I do not think I know how to JASS just by clicking Convert into Custom Text. I will start working on a spell for my map in JASS now, just wanted this question answered

 

[GooS]

As I got no answer the last time.

I just went ahead and tried to shorten it myself, end result,, not good ;D

First of I would just like to say, I want to learn JASS but I get so confused all other programming or web-based mark-up languages use line enders ( and { } (don't know what they're called) but jass just puts text after text and it hurts my eyes ;D

Well here's the code and the error is:
"Local declaration after first statement"

function Trig_Level_Increase_Conditions takes nothing returns boolean
    if ( not ( IsUnitType(GetTriggerUnit(), UNIT_TYPE_HERO) == true ) ) then
        return false
    endif
    return true
endfunction

function Trig_Level_Increase_Actions takes nothing returns nothing
if ( not (GetUnitTypeId(GetTriggerUnit()) == 'H000' )) then
    else
    local integer array Att
    local real array AttGain //==Line in which the error occurs
        set Att[1] = GetHeroStatBJ(bj_HEROSTAT_STR, GetTriggerUnit(), false)//==Line in which the error occurs
        set Att[2] = GetHeroStatBJ(bj_HEROSTAT_AGI, GetTriggerUnit(), false)
        set Att[3] = GetHeroStatBJ(bj_HEROSTAT_INT, GetTriggerUnit(), false)
        set AttGain[1] = ( I2R(Att[1]) * 1.10 )
        set AttGain[2] = ( I2R(Att[2]) * 1.09 )
        set AttGain[3] = ( I2R(Att[3]) * 1.085 )
        set Att[1] = (R2I( AttGain[1] + 0.99 ))
        set Att[2] = (R2I( AttGain[2] + 0.99 ))
        set Att[3] = (R2I( AttGain[3] + 0.99 ))
        call ModifyHeroStat( bj_HEROSTAT_STR, GetTriggerUnit(), bj_MODIFYMETHOD_SET, ( Att[1] ) )
        call ModifyHeroStat( bj_HEROSTAT_AGI, GetTriggerUnit(), bj_MODIFYMETHOD_SET, ( Att[2] ) )
        call ModifyHeroStat( bj_HEROSTAT_INT, GetTriggerUnit(), bj_MODIFYMETHOD_SET, ( Att[3] ) )
endif
endfunction

//===========================================================================

function InitTrig_Level_Increase takes nothing returns nothing
    set gg_trg_Level_Increase = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Level_Increase, EVENT_PLAYER_HERO_LEVEL )
    call TriggerAddCondition( gg_trg_Level_Increase, Condition( function Trig_Level_Increase_Conditions ) )
    call TriggerAddAction( gg_trg_Level_Increase, function Trig_Level_Increase_Actions )
endfunction

Be kind to me ;D;D
what is the problem with the inline?, to see how it looked before check previous post

Oh and one more question, what if any are the natives for hero stats?

 

[Builder Bob]

All local variables must be declared at the very beginning of functions.

I'd suggest downloading Jass NewGen Pack 1.4c. It helps a lot when coding Jass. It prevents the WE to crash when your code is wrong, and gives you better explanations of why the code won't compile.

Edit: inlining does not affect the code. It only makes it easier to read.

 

[GooS]

>All local variables must be declared at the very beginning of functions.

Oh, stupid me >.<

Thx i got newgen 1.4 and that was the only error it presented to me

Edit: Works perfectly now, +rep to my savior

 

[Builder Bob]

Oh and one more question, what if any are the natives for hero stats?

Sorry, I didn't see your other question.

The natives for hero stats are

native          GetHeroAgi          takes unit whichHero, boolean includeBonuses returns integer
native          GetHeroInt          takes unit whichHero, boolean includeBonuses returns integer
native          GetHeroStr          takes unit whichHero, boolean includeBonuses returns integer

native          SetHeroAgi          takes unit whichHero, integer newAgi, boolean permanent returns nothing
native          SetHeroInt          takes unit whichHero, integer newInt, boolean permanent returns nothing
native          SetHeroStr          takes unit whichHero, integer newStr, boolean permanent returns nothing

I use JassCraft to find natives by the way.

 

[GooS]

Thx once again

Noticed that this was included in newgen under function list >.< ;D