DestroyForce / (All Players) / LeakChecker

Bird

Ultra Cool Member
Reaction score
29
This is the visual part of my custom Bounty trigger(s). Tmp_Integer (gold awarded) is calculated elsewhere, then displayed above the Triggering (dying) unit. It then hides the Bounty text for All Players, and then un-hides it for the Killer.

Trigger:
  • GoldTest
    • Events
    • Conditions
    • Actions
      • Floating Text - Create floating text that reads (+ + (String(Tmp_Integer))) above (Triggering unit) with Z offset 0.00, using font size 9.00, color (100.00%, 100.00%, 0.00%), and 0.00% transparency
      • Set Tmp_PG = (All players)
      • Floating Text - Hide (Last created floating text) for Tmp_PG
      • Custom script: call DestroyForce(udg_Tmp_PG)
      • Set Tmp_PG = (Player group((Owner of (Killing unit))))
      • Floating Text - Show (Last created floating text) for Tmp_PG
      • Custom script: call DestroyForce(udg_Tmp_PG)
      • Floating Text - Set the velocity of (Last created floating text) to 32.00 towards 90.00 degrees
      • Custom script: call FloatByeText()


JASS:

function FloatByeText takes nothing returns nothing
    call SetTextTagPermanentBJ( GetLastCreatedTextTag(), false )
    call SetTextTagLifespanBJ( GetLastCreatedTextTag(), 2.00 )
    call SetTextTagFadepointBJ( GetLastCreatedTextTag(), 1.50 )
endfunction


1. I read conflicting info on here about Destroying a Force variable that was set to All Players. This, logically, shouldn't be a problem. But, is it?
2. The error I get in LeakChecker. Why?
Code:
(Line: 9) (Word: 3) Player Group Leak
Set Tmp_PG = (Player group((Owner of (Killing unit))))
Set Tmp_PG = ^Leak
(Suggested Fix) No suggested fixes.
 

Sirroelivan

Gunnerkrigg Court
Reaction score
95
Hmm, as far as I remember destroying a group variable that refers to all players shouldn't be a problem, destroying all players would be. Don't quote me on it though, since I'm not entirely sure...
 

Rushhour

New Member
Reaction score
46
There is no need to set 'All Players' to a group variable. Just use 'All Players' directly in the specific action. And yes, there is no need to destroy it. If you did, it would be destroyed for the rest of the game. So it would be pretty senseless :D

And yes, you need to destroy the force created by 'PlayerGroup(Owner of....)' . But the way you did it was correct. I just think that the leak checker didn't recognize that you destroyed your temp force.
 

Bird

Ultra Cool Member
Reaction score
29
So, to summarize, this trigger is leak-free? And I don't even need to bother with creating an All Players force?

The Killer Force and the Floating Text are all destroyed properly?

(It's important because I believe this is the Leak causing my map crashes)
 

Accname

2D-Graphics enthusiast
Reaction score
1,456
1). leak-free
2). no need to create/destroy (all players), destroying it is even dangerous.
3). leaks wont cause a map to crash, only slowing it down. (at least as long as the leaks wont feed up all of your memory what is very unlikely to happen)
 

Bird

Ultra Cool Member
Reaction score
29
Well this is my Bounty trigger, which before posting here I just added in the Force removal. This is an AOS type map, and thousands and thousands of Units die over time... thus thousands and thousands of bounties get displayed, and thousands and thousands of Forces were leaking.

The only way I have ever caused a crash (before this) in any map of mine was with an infinite loop, and I def don't think I have any in this map.
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • jonas jonas:
    Is the school system in your country similar to Chinese school system? I could never imagine being a teacher in a Chinese school, what's expected of students and teachers is just so different from what I'd be looking for as a teacher
  • vypur85 vypur85:
    A Levels is based on the UK syllabus offered internationally. So the syllabus is similar throughout different countries, taught in english.
  • vypur85 vypur85:
    I can't speak or write or read much chinese... Too difficult....... Which also makes my life here in china a lil difficult.
  • jonas jonas:
    Oh, I see. I thought Chinese version of A-levels :D
  • jonas jonas:
    I've been using the translate app a lot on my phone. take a photo, translate. take another photo, translate again :D
  • jonas jonas:
    it also has voice translation, my colleagues sometimes use that
  • jonas jonas:
    You came during the 0 covid policy right? How'd you get through quarantine? Did you have some help with the apps and green codes?
  • tom_mai78101 tom_mai78101:
    If you have any Chinese you need help with, let me know.
    +1
  • vypur85 vypur85:
    @jonas Those were the things I did too. Translate app and VPN are always the most important things to have to survive. Lol.
  • vypur85 vypur85:
    Yea I came last year. I was quarantined for about 30 days. Fml. The first day of my quarantine was the eve of Chinese new year last year. Fml again... Lol.
  • vypur85 vypur85:
    @tom_mai78101 IIRC you're from Taiwan right.
  • The Helper The Helper:
    I thought China had cracked down on having any foreign teachers?
  • vypur85 vypur85:
    Yeah I've heard of the news before. My school is still actively hiring foreign teachers. Not sure how things work now.
  • The Helper The Helper:
    yeah it is hard to get reliable information about that kind of stuff
  • The Helper The Helper:
    but you are doing it so it is still doable
  • vypur85 vypur85:
    I think it doesn't affect existing foreign teachers. Then again, its still weird that my school is hiring.
  • The Helper The Helper:
    Happy Monday people hope everyone has a fantastic week!
  • Ghan Ghan:
    Happy Monday?! That's a contradiction.
  • jonas jonas:
  • jonas jonas:
    please put this in the news section, it's crazy
  • tom_mai78101 tom_mai78101:
    Technically, you can post in the Headline News. Just posted your news there.
  • tom_mai78101 tom_mai78101:
    I'm not aware of you not being able to post news.
  • jonas jonas:
    I think technically I can I just forget how
    +1
  • The Helper The Helper:
    Happy Thursday!

    The Helper Discord

    Members online

    No members online now.

    Affiliates

    Hive Workshop NUON Dome World Editor Tutorials

    Network Sponsors

    Apex Steel Pipe - Buys and sells Steel Pipe.
    Top