Is there a downside to inlining conditions?

afisakov

You can change this now in User CP.
I have seen some maps that write functions in this form
Code:
function Trig_kongzhi_Func005C takes nothing returns boolean
if(not(GetUnitTypeId(GetTriggerUnit())=='ndqp'))then
        return false
    endif
    return true
endfunction
 
function Trig_kongzhi_Func006C takes nothing returns boolean
if(not(GetUnitTypeId(GetTriggerUnit())=='ndqs'))then
        return false
    endif
    return true
endfunction
 
function Trig_kongzhi takes nothing returns nothing
if Trig_kongzhi_Func005C() then
do something
endif
if Trig_kongzhi_Func006C() then
do something else
endif
...
I am tempted to write it like this instead
Code:
function Trig_kongzhi takes nothing returns nothing
if (GetUnitTypeId(GetTriggerUnit())=='ndqp')then
do something
endif
if (GetUnitTypeId(GetTriggerUnit())=='ndqs') then
do something else
endif
...
I have no doubt that the second approach saves space, but I am wondering if it somehow slows down the execution. Otherwise I don't know why the first would be used except that is how game translates it from GUI.
Are there any advantages to the first approach or should I switch to the second (conditions written inside the function that uses them)?
 

cyb3rhack-r

New Member
The former executes faster than the latter because it doesn't call other functions. The former wasn't through Jass. It was preset upon converting GUI into custom text.
 

afisakov

You can change this now in User CP.
The former executes faster than the latter because it doesn't call other functions
Wait, I thought the former means the first, and it does call on the other (boolean) functions? Or is that not what u meant by calling other functions.

Do you mean that the longer way of writing it executes faster? The one made from gui conversion?
 

dracolich

TH.net Regular
its not a "some map", its GUI version of jass.
everytime you start to GUI something with conditions, theyre will be exported like those functions.
of course, in-lining is faster, cause function call still takes some time
 

afisakov

You can change this now in User CP.
its not a "some map", its GUI version of jass.
everytime you start to GUI something with conditions, theyre will be exported like those functions.
of course, in-lining is faster, cause function call still takes some time
ok, good, so the shorter way of writing it also works faster, that makes my life much easier.
also results in code that is easier to read :)
 

dracolich

TH.net Regular
well, in-lining not so useful for one-time called function, cause its still only 1 another function call.
but yeah, inlined code easier to read
 

afisakov

You can change this now in User CP.
well, in-lining not so useful for one-time called function, cause its still only 1 another function call.
but yeah, inlined code easier to read
thanks. Even if speed difference is minor, it takes less space and is easier to read, so as long as it isn't slower it seems a much better choice.

The reason I was asking is I open alot of unprotected maps (and some protected ones) to learn from them, and I was wondering if there was a reason they wrote the code that way. Now I know it was just an artifact from using gui and I can safely change it.
 

Tyrulan

Ultra Cool Member
The advantage of writing a separate boolean function can be for reuse and recycling. The compiler will not duplicate code if there is a boolean function, thus the map will load faster. It does slow down the execution, but the difference is so negligible that it doesn't matter.

If later, your boolean logic needed to change, you could simply edit the function. It's also a stylistic or organizational choice.
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • tom_mai78101 tom_mai78101:
    Hmm, about the Headline News, I noticed threads are being moved into the subforum (Health News, Environmental News, etc.). When that happens, the TH Forum Home page loses the articles, and instead would show old articles posted 1 or 2 weeks ago.
  • tom_mai78101 tom_mai78101:
    What do we do with the Home page?
  • Ghan Ghan:
    I added those forums to the filter for that widget.
    +1
  • tom_mai78101 tom_mai78101:
    Oh nice. They're back. Thanks.
  • tom_mai78101 tom_mai78101:
    Now I think it makes more sense for me to put news in their own subforums, without worry.
  • The Helper The Helper:
    Awesome Ghan thanks! I was purposely not moving the first 15 news articles in Headline news to the different subforums but I guess I don't have to do that now?
  • tom_mai78101 tom_mai78101:
    Question: Is there a way to remove thread redirects? It creates a copy of the moved thread and takes up space, and I am leaning towards wanting to remove them in the Headline News. But if they have an expiration date, I guess I'm fine with it.
  • The Helper The Helper:
    If you move a thread please leave a permanent redirect. You can delete any redirects after 6 months. The redirects are left to help Search Engines find the moved content.
  • tom_mai78101 tom_mai78101:
    What if you move the permanent redirect, not the thread?
  • The Helper The Helper:
    I think that works but I have not messed with it. You can delete redirects though if you have to that will not delete the original thread
  • The Helper The Helper:
    if a redirect ends up in the same forum as the post it goes to though I think the redirect drops or fails or something but they are not bugged out and when you are working on an indirect the original post is safe.
  • The Helper The Helper:
    Happy Early Friday :)
    +1
  • V-SNES V-SNES:
    Happy Friday :)
  • tom_mai78101 tom_mai78101:
    Fun Friday for me
  • tom_mai78101 tom_mai78101:
    Happy Fun Friday to all.
    +2
  • The Helper The Helper:
    Happy Sunday everyone!!!
  • V-SNES V-SNES:
    Happy Sunday!!!
    +1
  • jonas jonas:
    Happy monday :p
  • jonas jonas:
    Everyone hates mondays?
    +1
  • The Helper The Helper:
    Happy Tuesday!
  • jonas jonas:
    Happy belated tuesday
  • tom_mai78101 tom_mai78101:
    I found out you can't delete nor hide redirect links to existing threads. It will just stay there. I have no choice now but to start moving thread redirects to News Archive.
  • The Helper The Helper:
    That is not the way that it works for me I can delete redirects you just have to hit refresh sometimes big deletes will take a while as long as moves\
  • The Helper The Helper:
    You don't have to do that you can just leave stuff there in headline news for up to a year it was already down to like 8 months there is no rush.

    Staff online

    • Ghan
      Administrator - Servers are fun
    • tom_mai78101
      The Helper Connoisseur / Ex-MineCraft Host

    Members online

    Affiliates

    Hive Workshop NUON Dome World Editor Tutorials

    Network Sponsors

    Apex Steel Pipe - Buys and sells Steel Pipe.
    Top