My first time with JASS

Rommel · Jul 22, 2008

-Hi friends...I spent 18 hours without sleeping last night to learn Jass. I read all great tutorials of Vexorain, Daelin, Wyrmlord, DarkWolf...and i found JASS Very interesting

-Well, yes, firstly i have to convert GUI to JASS for learning, and try to research and optimize it....but later on, when my knowledge is better, i will try to write my own code. I also thank you all friends for your help.

-Here is the list of my next spells..But i should introduce they abit, right...so you can imagine how they work and see if my code is going right.

-Lay on Hands:
A holy light that can heal a friendly unit or deal half damage to a target foe.

-And the code:

JASS:

function Trig_Lay_on_Hands_Conditions takes nothing returns boolean
    return GetSpellAbilityId() == &#039;A003&#039;
endfunction

function Trig_Lay_on_Hands_Actions takes nothing returns nothing
local unit Caster_LOH = GetTriggerUnit()
local integer Int_LOH = GetUnitAbilityLevel(Caster_LOH, &#039;A003&#039;)
local unit Target_LOH = GetSpellTargetUnit()
call TriggerSleepAction(0.50)
if IsUnitAlly(Target_LOH, GetOwningPlayer(Caster_LOH))then
 call SetUnitState(Target_LOH, UNIT_STATE_LIFE, GetUnitState(Target_LOH, UNIT_STATE_LIFE) + (Int_LOH * 80. + udg_Bonus_LOH))
else
 call UnitDamageTargetBJ(Caster_LOH, Target_LOH, (80. * Int_LOH + udg_Bonus_LOH), ATTACK_TYPE_HERO, DAMAGE_TYPE_NORMAL)
endif
set Caster_LOH = null
set Target_LOH = null
endfunction

//===========================================================================
function InitTrig_Lay_on_Hands takes nothing returns nothing
    set gg_trg_Lay_on_Hands = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Lay_on_Hands, EVENT_PLAYER_UNIT_SPELL_CHANNEL )
    call TriggerAddCondition( gg_trg_Lay_on_Hands, Condition( function Trig_Lay_on_Hands_Conditions ) )
    call TriggerAddAction( gg_trg_Lay_on_Hands, function Trig_Lay_on_Hands_Actions )
endfunction

-Holy Incantation:
Passive - An aura that gives friendly nearby units a damage shield, which returns a percentage of a melee attacker's damage back to it.

-And the code for Conversion (For multiple conditions, we use "and", right? So i added this line at the end of the Condition Function: and not IsUnitType(GetTriggerUnit(), UNIT_TYPE_HERO :

JASS:

constant function Conversion_SpellId takes nothing returns integer
return &#039;A007&#039;
endfunction
constant function Conversion_BuffId takes nothing returns integer
return &#039;AeAh&#039;
endfunction
constant function Conversion_Dum takes nothing returns integer
return &#039;A004&#039;
endfunction

function Trig_Conversion_Conditions takes nothing returns boolean
return GetUnitTypeId(GetAttacker()) ==&#039;Hpal&#039; and IsUnitType(GetTriggerUnit(), UNIT_TYPE_UNDEAD) and GetUnitAbilityLevel(GetAttacker(), Conversion_SpellId()) &gt;=1 and GetUnitAbilityLevel(GetAttacker(), Conversion_BuffId()) &gt;0 and not IsUnitType(GetTriggerUnit(), UNIT_TYPE_HERO )
endfunction

function Trig_Conversion_Actions takes nothing returns nothing
  local unit c = GetAttacker()
  local unit t = GetTriggerUnit()
  local integer ir = GetRandomInt(1,100)
  local integer ic = 2 * GetUnitAbilityLevel(c, Conversion_SpellId())
if ir &lt;= ic then
  call SetUnitAnimation(c, &quot;attack&quot;)
  call DestroyEffect(AddSpecialEffectTarget(&quot;Abilities\\Spells\\Human\\HolyBolt\\HolyBoltSpecialArt.mdl&quot;, t, &quot;origin&quot;))
  call SetUnitOwner(t, GetOwningPlayer(c), true)
  call UnitAddAbility(t, Conversion_Dum())
endif
  set c = null
  set t = null
endfunction

function InitTrig_Conversion takes nothing returns nothing
call TriggerRegisterAnyUnitEventBJ(gg_trg_Conversion, EVENT_PLAYER_UNIT_ATTACKED)
call TriggerAddCondition(gg_trg_Conversion, Condition(function Trig_Conversion_Conditions))
call TriggerAddAction(gg_trg_Conversion, function Trig_Conversion_Actions)
endfunction

-Judicial Chop:
The Paladin focus his holy strength to jolt a hot light stream at a target enemy unit, causing damage and ministun.

-Sacred Strength:
Passive - The Paladin channels divine power to gain bonus Strength. Also adds more points to Lay on Hands, gives extra damage VS Undead to Judicial Chop, completely immune to Disease and has a chance to convert Undead creatures to your side on attacks under the effect of Holy Incantation

-And the Code for Extra damage for Judicial Chop(I make the game wait 0.5 sec before triggering damage and creating floating text because the caster need a small time to cast his spell or i should use event "A unit finish casting a spell" ?):

JASS:

function Trig_Judicial_Chop_Conditions takes nothing returns boolean
   return GetSpellAbilityId() == &#039;AHtb&#039;
endfunction

function Trig_Judicial_Chop_Actions takes nothing returns nothing
    local unit c = GetTriggerUnit()
    local unit t = GetSpellTargetUnit()
    local integer i = 100 * GetUnitAbilityLevel(c, &#039;A007&#039;)
    call TriggerSleepAction(0.50)
    call UnitDamageTargetBJ(c, t, i, ATTACK_TYPE_HERO, DAMAGE_TYPE_NORMAL)
    call CreateTextTagUnitBJ( ( &quot;+&quot; + I2S(i) ), t, 0, 10, 100, 0.00, 0.00, 0 )
    call SetTextTagVelocityBJ( GetLastCreatedTextTag(), 40.00, 90 )
    call SetTextTagPermanentBJ( GetLastCreatedTextTag(), false )
    call SetTextTagLifespanBJ( GetLastCreatedTextTag(), 3.00 )
    set c = null
    set t = null
    
endfunction

//===========================================================================
function InitTrig_Judicial_Chop takes nothing returns nothing
    set gg_trg_Judicial_Chop = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Judicial_Chop, EVENT_PLAYER_UNIT_SPELL_CAST )
    call TriggerAddCondition( gg_trg_Judicial_Chop, Condition( function Trig_Judicial_Chop_Conditions ) )
    call TriggerAddAction( gg_trg_Judicial_Chop, function Trig_Judicial_Chop_Actions )
endfunction

-The Code for Extra Strength and bonus point to Lay on Hands:

JASS:

function Trig_Sacred_Strength_Conditions takes nothing returns boolean
  return GetLearnedSkillBJ() == &#039;A007&#039;and GetUnitTypeId(GetTriggerUnit()) == &#039;Hpal&#039;
endfunction

function Trig_Sacred_Strength_Actions takes nothing returns nothing
  local unit c = GetTriggerUnit()
  local integer i = GetUnitAbilityLevel(GetTriggerUnit(), &#039;A007&#039;)
  set udg_Bonus_LOH = 3 * i
  if i == 1 then
     call UnitAddAbility(c, &#039;A008&#039;)
   elseif i ==2 then
           call UnitRemoveAbility(c, &#039;A008&#039;)
           call UnitAddAbility(c, &#039;A009&#039;)
     elseif i == 3 then
            call UnitRemoveAbility(c, &#039;A009&#039;)
            call UnitAddAbility(c, &#039;A00A&#039;)
  endif
  set c = null
endfunction

//===========================================================================
function InitTrig_Sacred_Strength takes nothing returns nothing
    set gg_trg_Sacred_Strength = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Sacred_Strength, EVENT_PLAYER_HERO_SKILL )
    call TriggerAddCondition( gg_trg_Sacred_Strength, Condition( function Trig_Sacred_Strength_Conditions ) )
    call TriggerAddAction( gg_trg_Sacred_Strength, function Trig_Sacred_Strength_Actions )
endfunction

Well, i saved it, the map report no bug, but except Lay on Hands i see it clearly works...The other i am not sure, and the Conversion action still does not work, hix.

I attach the map here, so if you have time, can you take a look at it? Also, if my spells have any typo or grammar error, i hope you could help me fix :lol:

At this corner is a group of Undead for testing:

And i want to bother you one more thing, how to create a game message like Blizzard's one, like this:

I will play here around to waiting for answerm hix

Rommel · Jul 23, 2008

Anyone there ?? i have been around here for 8 hours :banghead:

AdamGriffith · Jul 23, 2008

What is the problem?
Why post things that work?

Rommel · Jul 23, 2008

Well, i saved it, the map report no bug, but except Lay on Hands i see it clearly works...The other i am not sure, and the Conversion action still does not work, hix.

Hix the biggest problem is the code for "Conversion" does not work.
Under the effect of holy incantation and Sacred Strength, the caster must has 2/4/6% to convert an Undead creature to his side on attacks but nothing happens.

Also i hope some one could help me fix any error or unefficient things

Tukki · Jul 23, 2008

Oh, much code..

1) Holy Hands

JASS:

function Trig_Lay_on_Hands_Conditions takes nothing returns boolean
    return GetSpellAbilityId() == &#039;A003&#039;
endfunction

function Trig_Lay_on_Hands_Actions takes nothing returns nothing
local unit Caster_LOH = GetTriggerUnit()
local integer Int_LOH = GetUnitAbilityLevel(Caster_LOH, &#039;A003&#039;)
local unit Target_LOH = GetSpellTargetUnit()
local real TempReal = Int_LOC * 80 + udg_Bonus_LOH // new line
call TriggerSleepAction(0.50) // &lt;- this can be removed.
if IsUnitAlly(Target_LOH, GetOwningPlayer(Caster_LOH))then
 call SetUnitState(Target_LOH, UNIT_STATE_LIFE, GetUnitState(Target_LOH, UNIT_STATE_LIFE) + TempReal)
else
 call UnitDamageTargetBJ(Caster_LOH, Target_LOH, TempReal/2, ATTACK_TYPE_HERO, DAMAGE_TYPE_NORMAL) // use Attack_type_CHAOS and Damage_Type_UNIVERSAL for &#039;spell damage&#039;, chaos as it does not deal extra to anything and universal as it ignores armor. I added TempReal/2 as it should deal half of the hp healed.
endif
set Caster_LOH = null
set Target_LOH = null
endfunction

//===========================================================================
function InitTrig_Lay_on_Hands takes nothing returns nothing
    set gg_trg_Lay_on_Hands = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Lay_on_Hands, EVENT_PLAYER_UNIT_SPELL_CHANNEL )
    call TriggerAddCondition( gg_trg_Lay_on_Hands, Condition( function Trig_Lay_on_Hands_Conditions ) )
    call TriggerAddAction( gg_trg_Lay_on_Hands, function Trig_Lay_on_Hands_Actions )
endfunction

2) Holy Incantation
Consider using Thorns Shield (or something that way).

but this will not work;

JASS:

IsUnitType(GetTriggerUnit(), UNIT_TYPE_UNDEAD

add '== true' in this case.

3) Conversion

JASS:

function Trig_Conversion_Actions takes nothing returns nothing
  local unit c = GetAttacker()
  local unit t = GetTriggerUnit() 
  local integer ir = GetRandomInt(1,100)
  local integer ic = 2 * GetUnitAbilityLevel(c, Conversion_SpellId())
if ir &lt;= ic then // change to &quot;ic &gt;= ir&quot;
  call SetUnitAnimation(c, &quot;attack&quot;)
  call DestroyEffect(AddSpecialEffectTarget(&quot;Abilities\\Spells\\Human\\HolyBolt\\HolyBoltSpecialArt.mdl&quot;, t, &quot;origin&quot;))
  call SetUnitOwner(t, GetOwningPlayer(c), true)
  call UnitAddAbility(t, Conversion_Dum())
endif
  set c = null
  set t = null
endfunction

also this line is spooky;

JASS:

GetUnitTypeId(GetAttacker()) ==&#039;Hpal&#039; and IsUnitType(GetTriggerUnit(), UNIT_TYPE_UNDEAD) and GetUnitAbilityLevel(GetAttacker(), Conversion_SpellId()) &gt;= 1 and GetUnitAbilityLevel(GetAttacker(), Conversion_BuffId()) &gt;0 and not IsUnitType(GetTriggerUnit(), UNIT_TYPE_HERO )
endfunction

things to change;

JASS:

IsUnitType(GetTriggerUnit(), UNIT_TYPE_UNDEAD) == true

Hope it works.

EDIT: Are you using JassNewGenPack?

Rommel · Jul 23, 2008

Ah...yes.. my friend i think so..i checked the code thoroughly and fixed a those bugs you reported..it works now..blah ^^
Now i have a question: How to remove a buff from a unit, i trying to make the paladin immune to disease whenever a unit cast it on him. Jass define the buff as spell and the code looks like this, right:

JASS:

call RemoveUnitAbility(unit, buffcode)

But i cant know why it does not work.

Also about timer, Rising_Dusk said a way to use CS Safety of Vexorian...(The very first use he introduced is to use 2 functions where global vars are used>>this is not MUI)..but how to use it? thats the problem, sorry if the question is stupid just forget it :emote_grin:

P/S: Yes, im using JNGP

Prometheus · Jul 23, 2008

To display messages like bliz, I'd suggest trying this.
The 50 and the 0 are the texts position, it could actually be 0.5. I haven't used it beyond 0,0.

JASS:

call DisplayTextToPlater(GetLocalPlayer(),50,0,&quot;MyMsg&quot;)

Tukki · Jul 24, 2008

JASS:

call RemoveUnitAbility( unit, buffcode)

Obviously the unit is whichUnit you want to remove the buff from, and the buffcode is the id of the buff you want to remove. (example: 'B000')

CS Safety is a library for timer/group recyling, so you don't need to destroy them.

To make a unit immune to a buff like 'disease' I would do something like this;

JASS:

scope Test initializer InitTrig

globals
    private constant integer AID_DISEASE = &#039;A000&#039; // Your disease spell id.
    private constant integer BID_DISEASE = &#039;B000&#039; // Your disease buff id.
    private constant integer AID_DISEASEPROTECTION = &#039;A001&#039; // Your disease protection spell.
endglobals

private function Actions takes nothing returns nothing
 local unit Targeted = GetSpellTargetUnit()
 
    if (Targeted != null) and (GetUnitAbilityLevel(Targeted, AID_DISEASEPROTECTION) &gt; 0) then
        if (GetUnitAbilityLevel(Targeted, BID_DISEASE) &gt; 0) then
            call UnitRemoveAbility(Targeted, BID_DISEASE)
        endif
    endif
    
    set Targeted = null
endfunction

private function Conditions takes nothing returns boolean
    return GetSpellAbilityId() == AID_DISEASE
endfunction

private function InitTrig takes nothing returns nothing
 local trigger Trg = CreateTrigger()
 
    call TriggerRegisterAnyUnitEventBJ(Trg, EVENT_PLAYER_UNIT_SPELL_EFFECT)
    call TriggerAddCondition(Trg, Condition( function Conditions))
    call TriggerAddAction(Trg, function Actions)
endfunction
endscope

And since you are using JNGP, you should maybe start to learn vJass?

Edit: And your other spells can be made into vJass very easily!

Rommel · Jul 24, 2008

Thanks for your great help, tukki..Yes, VJass looks promising but i cant find any documents to start my learning course

Tukki · Jul 24, 2008

Check THIS

Rommel · Jul 24, 2008

Muahhahaha..I've been looking for this...kiss you one thousand times, tukki

If you have any more documents, send me please...Well, one more week without sleeping...Amen

Tukki · Jul 24, 2008

kiss you one thousand times, tukki

I hope you're kiddin' x)

If you have any more documents, send me please

It's around 30+ pages, so it's all vJass has to offer. (Some more if you make it yourself)

Well, one more week without sleeping...Amen

Good luck dude.

Prometheus · Jul 24, 2008

vJass (Light)

My first time with JASS

Rommel

New Member

Attachments

Rommel

New Member

AdamGriffith

You can change this now in User CP.

Rommel

New Member

Tukki

is Skeleton Pirate.

Rommel

New Member

Prometheus

Everything is mutable; nothing is sacred

Tukki

is Skeleton Pirate.

Rommel

New Member

Tukki

is Skeleton Pirate.

Rommel

New Member

Tukki

is Skeleton Pirate.

Prometheus

Everything is mutable; nothing is sacred

Settings Notifications

Options

The Helper Discord

Members online

Share this page

Affiliates

Network Sponsors

My first time with JASS

New Member

Attachments

New Member

You can change this now in User CP.

New Member

is Skeleton Pirate.

New Member

Everything is mutable; nothing is sacred

is Skeleton Pirate.

New Member

is Skeleton Pirate.

New Member

is Skeleton Pirate.

Everything is mutable; nothing is sacred

Log in

The Helper Discord

Share this page

Affiliates

Network Sponsors