Questions About Leaks

[Ghan]

I'm usually pretty good about leaks, but I think I have one that I can't find.

Do the following things leak?

set X1 = GetLocationX(GetStartLocationLoc(GetPlayerStartLocation(Player(currentPlayer))))

Does the above create a location that isn't destroyed?

call TimerStart(GetExpiredTimer(), SpawnTimes[currentPlayer], false, function Spawn)

Does a timer get leaked here?

exitwhen FirstOfGroup(temp) == null

Is a unit leaked here?


Basically my questions revolve around the concept of whether or not functions that return handles that aren't necessarily stored in a variable cause leaks.

Thanks for any help.

 

[AceHart]

Yes
No
No

 

[Ghan]

Does this still leak?

set X1 = GetStartLocationX(GetPlayerStartLocation(Player(currentPlayer)))

If it does, what should I do to fix it?

 

[AceHart]

What you should always do if you need a particular point several times... store it in some global on map init.
Even if it leaks there, it's once per map.

set StartX[1] = ...
...
set StartY[12] = ...

 

[Ghan]

Hm. Ok, I can do that. Thanks.

 

[AceHart]

> Does this still leak?

Seems I missed that part

GetStartLocationLoc was the problem as it creates a new location on every call.
Somewhat strange given start locations never change... but, well, ask Blizzard.

Still, why run all of those calls if a simple array solves all problems in one simple go?

 

[Ghan]

> it creates a new location on every call.

That's what I was thinking, but I wasn't sure.
Anyway, it should be fixed now. I have two real arrays to take care of it.