Whattoput( having a trouble with my code)

Azwan Izhar

New Member
Hello, I would like some help regarding my code. As you can see, it is very basic but I'm having a trouble with it. It works fine on target but when I redo it with the same skill on the same target for the second time, it wouldn't damage the target.

Code:
function Trig_Tiger_Fang_Actions takes nothing returns nothing
    local unit sfxdummy
    local unit caster = GetTriggerUnit()
    local unit target = GetSpellTargetUnit()
    local unit target2
    local real xa = GetUnitX(caster)
    local real ya = GetUnitY(caster)
    local real xb = GetUnitX(target)
    local real yb = GetUnitY(target)
    local group g = CreateGroup()
   
 
    set g = GetUnitsInRangeOfLocAll( 50, Location(xb, yb))
    set sfxdummy = CreateUnit(GetOwningPlayer(caster), 'h003', xb, yb, 0.00)
    set target2 = FirstOfGroup(g)
    call UnitApplyTimedLife( sfxdummy, 'BTLF', 2.00)
    call IssueTargetOrderById( sfxdummy, 852231, target2)
    call DestroyEffect( AddSpecialEffect( "Abilities\\Spells\\Human\\ManaFlare\\ManaFlareBoltImpact.mdl", xb, yb))
   
    set bj_wantDestroyGroup = true
    set caster = null
    set target = null
    set target2 = null
    set sfxdummy = null
endfunction
 

DrEvil

FCRI Associate!
since you create the 'sfxdummy' right on top of the target's location, the next cast will include it in the group enum.
FirstOfGroup returns a random unit, so it may be returning the dummy unit.

You should add a condition comparing the enumerated units to check they are enemies?

Something along the lines of: (bear in mind I haven't used wc3 in ages...)

JASS:
function condition takes nothing returns boolean
return IsAnEnemy( GetOwningPlayer (GetTriggerUnit()), GetOwningPlayer(GetEnumeratedUnit()))
// do note IsAnEnemy isn't the right name of the function
// maybe it takes units as parameters...
// It might not be enumerated unit... maybe matching?
endfunction
 
function Trig_Tiger_Fang_Actions takes nothing returns nothing
local unit sfxdummy
local unit caster = GetTriggerUnit()
local unit target = GetSpellTargetUnit()
local unit target2
local real xa = GetUnitX(caster)
local real ya = GetUnitY(caster)
local real xb = GetUnitX(target)
local real yb = GetUnitY(target)
local group g = CreateGroup()
 
 
set g = GetUnitsInRangeOfLocAll( 50, Location(xb, yb))// somehow use a GetUnitsInRange With condition .. (Condition(function condition))
set sfxdummy = CreateUnit(GetOwningPlayer(caster), 'h003', xb, yb, 0.00)
set target2 = FirstOfGroup(g)
call UnitApplyTimedLife( sfxdummy, 'BTLF', 2.00)
call IssueTargetOrderById( sfxdummy, 852231, target2)
call DestroyEffect( AddSpecialEffect( "Abilities\\Spells\\Human\\ManaFlare\\ManaFlareBoltImpact.mdl", xb, yb))
 
set bj_wantDestroyGroup = true
set caster = null
set target = null
set target2 = null
set sfxdummy = null
endfunction


But I'm sure that you are grouping the dummy unit when the next spell cast is casted.
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • tom_mai78101 tom_mai78101:
    Hmm, about the Headline News, I noticed threads are being moved into the subforum (Health News, Environmental News, etc.). When that happens, the TH Forum Home page loses the articles, and instead would show old articles posted 1 or 2 weeks ago.
  • tom_mai78101 tom_mai78101:
    What do we do with the Home page?
  • Ghan Ghan:
    I added those forums to the filter for that widget.
    +1
  • tom_mai78101 tom_mai78101:
    Oh nice. They're back. Thanks.
  • tom_mai78101 tom_mai78101:
    Now I think it makes more sense for me to put news in their own subforums, without worry.
  • The Helper The Helper:
    Awesome Ghan thanks! I was purposely not moving the first 15 news articles in Headline news to the different subforums but I guess I don't have to do that now?
  • tom_mai78101 tom_mai78101:
    Question: Is there a way to remove thread redirects? It creates a copy of the moved thread and takes up space, and I am leaning towards wanting to remove them in the Headline News. But if they have an expiration date, I guess I'm fine with it.
  • The Helper The Helper:
    If you move a thread please leave a permanent redirect. You can delete any redirects after 6 months. The redirects are left to help Search Engines find the moved content.
  • tom_mai78101 tom_mai78101:
    What if you move the permanent redirect, not the thread?
  • The Helper The Helper:
    I think that works but I have not messed with it. You can delete redirects though if you have to that will not delete the original thread
  • The Helper The Helper:
    if a redirect ends up in the same forum as the post it goes to though I think the redirect drops or fails or something but they are not bugged out and when you are working on an indirect the original post is safe.
  • The Helper The Helper:
    Happy Early Friday :)
    +1
  • V-SNES V-SNES:
    Happy Friday :)
  • tom_mai78101 tom_mai78101:
    Fun Friday for me
  • tom_mai78101 tom_mai78101:
    Happy Fun Friday to all.
    +2
  • The Helper The Helper:
    Happy Sunday everyone!!!
  • V-SNES V-SNES:
    Happy Sunday!!!
    +1
  • jonas jonas:
    Happy monday :p
  • jonas jonas:
    Everyone hates mondays?
    +1
  • The Helper The Helper:
    Happy Tuesday!
  • jonas jonas:
    Happy belated tuesday
  • tom_mai78101 tom_mai78101:
    I found out you can't delete nor hide redirect links to existing threads. It will just stay there. I have no choice now but to start moving thread redirects to News Archive.
  • The Helper The Helper:
    That is not the way that it works for me I can delete redirects you just have to hit refresh sometimes big deletes will take a while as long as moves\
  • The Helper The Helper:
    You don't have to do that you can just leave stuff there in headline news for up to a year it was already down to like 8 months there is no rush.

    Members online

    No members online now.

    Affiliates

    Hive Workshop NUON Dome World Editor Tutorials

    Network Sponsors

    Apex Steel Pipe - Buys and sells Steel Pipe.
    Top