Which is faster?

NoobImbaPro

You can change this now in User CP.
I've got two codes that do the same thing, which is faster and why?
JASS:
method iterate takes code func returns nothing
    local trigger temp = CreateTrigger()
    local thistype cnt = this.guard
 
    call TriggerAddAction(temp, func)
 
    loop
        set cnt = cnt.next
    exitwhen cnt == cnt.guard
        set enumerable = cnt
        call TriggerExecute(temp)
    endloop
 
    call DestroyTrigger(temp)
    set temp = null
endmethod


JASS:
method iterate takes string funcname returns nothing
    local thistype cnt = this.guard
 
    loop
        set cnt = cnt.next
    exitwhen cnt == cnt.guard
        set enumerable = cnt
        call ExecuteFunc( funcname )
    endloop
 
endmethod
 
They both suck :\

JASS:
List list = List.create()
local integer sentinel = list
//populate
 
loop
    set list = list.next
    exitwhen list == sentinel
 
    //code
endloop
 

PurgeandFire

zxcvmkgdfg
The second one is faster (according to old benchmarks), but some people stray away from it. There isn't really anything wrong with ExecuteFunc any more iirc (optimizer doesn't break it, and it doesn't crash when an invalid func is put in)

However, triggers are usually failsafe. If the function does not exist, it will throw an error. For ExecuteFunc, it just won't work. That's why some may prefer to use triggers. However, dynamic triggers (creating and destroying) are usually unnecessary. For example, if you just need to start a new thread or w/e, you can simply save the triggeraction to a local, execute the trigger, and then TriggerRemoveAction. Just use one global trigger, that way you don't need to destroy it.

I think some people said that TriggerEvaluate also runs on a new thread, but I can't confirm that. However, it may be something worth trying since TriggerEval is faster. (again, according to old benchmarks. Some things might've changed since)
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • tom_mai78101 tom_mai78101:
    Hmm, about the Headline News, I noticed threads are being moved into the subforum (Health News, Environmental News, etc.). When that happens, the TH Forum Home page loses the articles, and instead would show old articles posted 1 or 2 weeks ago.
  • tom_mai78101 tom_mai78101:
    What do we do with the Home page?
  • Ghan Ghan:
    I added those forums to the filter for that widget.
    +1
  • tom_mai78101 tom_mai78101:
    Oh nice. They're back. Thanks.
  • tom_mai78101 tom_mai78101:
    Now I think it makes more sense for me to put news in their own subforums, without worry.
  • The Helper The Helper:
    Awesome Ghan thanks! I was purposely not moving the first 15 news articles in Headline news to the different subforums but I guess I don't have to do that now?
  • tom_mai78101 tom_mai78101:
    Question: Is there a way to remove thread redirects? It creates a copy of the moved thread and takes up space, and I am leaning towards wanting to remove them in the Headline News. But if they have an expiration date, I guess I'm fine with it.
  • The Helper The Helper:
    If you move a thread please leave a permanent redirect. You can delete any redirects after 6 months. The redirects are left to help Search Engines find the moved content.
  • tom_mai78101 tom_mai78101:
    What if you move the permanent redirect, not the thread?
  • The Helper The Helper:
    I think that works but I have not messed with it. You can delete redirects though if you have to that will not delete the original thread
  • The Helper The Helper:
    if a redirect ends up in the same forum as the post it goes to though I think the redirect drops or fails or something but they are not bugged out and when you are working on an indirect the original post is safe.
  • The Helper The Helper:
    Happy Early Friday :)
    +1
  • V-SNES V-SNES:
    Happy Friday :)
  • tom_mai78101 tom_mai78101:
    Fun Friday for me
  • tom_mai78101 tom_mai78101:
    Happy Fun Friday to all.
    +2
  • The Helper The Helper:
    Happy Sunday everyone!!!
  • V-SNES V-SNES:
    Happy Sunday!!!
    +1
  • jonas jonas:
    Happy monday :p
  • jonas jonas:
    Everyone hates mondays?
    +1
  • The Helper The Helper:
    Happy Tuesday!
  • jonas jonas:
    Happy belated tuesday
  • tom_mai78101 tom_mai78101:
    I found out you can't delete nor hide redirect links to existing threads. It will just stay there. I have no choice now but to start moving thread redirects to News Archive.
  • The Helper The Helper:
    That is not the way that it works for me I can delete redirects you just have to hit refresh sometimes big deletes will take a while as long as moves\
  • The Helper The Helper:
    You don't have to do that you can just leave stuff there in headline news for up to a year it was already down to like 8 months there is no rush.

    Members online

    No members online now.

    Affiliates

    Hive Workshop NUON Dome World Editor Tutorials

    Network Sponsors

    Apex Steel Pipe - Buys and sells Steel Pipe.
    Top