Snippet AutocastOrderEvent

Azlier

Old World Ghost
I won't be able to upgrade this. I lost my computer last week. If someone is nice enough to create a version that works with specific ID's, I would be happy to replace the one in the first post and give credits.
 

Azlier

Old World Ghost
Revamped after all this time. Should be much, much faster. And it now recognizes Searing Arrows and friends.

Alas, I had to sacrifice the most useless function. Breaks backwards compatibility for those who for some reason used it.

If I missed any autocast orders, please tell me.

EDIT: Quick change in data storage. No longer uses a hashtable, because I discovered the perfect 'offset' for attachment to order ID's, much like 0x100000 for handles. But this is safe because order ID's are static.
 

Kenny

Back for now.
Hahaha wow!! Your new method reminds me of how I did this back when you first released this. Nice work keeping this hashtable free too. Hastables seem like a bit to much for something like this.

I'll see if I can find mine for comparison, it is freakishly similar...

Edit:

Found it hiding away somewhere:

JASS:
library AutocastEvent initializer Init requires Event
    
    globals 
        private Event         AutoOn   = 0
        private Event         AutoOff  = 0
        private integer array OrderIds
        private integer array ArrayIds
    endglobals

    function TriggerRegisterAutocastOnEvent takes trigger whichTrigger returns nothing
        call AutoOn.register(whichTrigger)
    endfunction

    function TriggerRegisterAutocastOffEvent takes trigger whichTrigger returns nothing
        call AutoOff.register(whichTrigger)
    endfunction

    private function Actions takes nothing returns boolean
        local integer i = ArrayIds[S2I(SubString(I2S(GetIssuedOrderId()),3,6))]
        
        if i == 1 then
            call AutoOn.fire()
        elseif i == 2 then
            call AutoOff.fire()
        endif
        
        return false
    endfunction

    private function Init takes nothing returns nothing
        local trigger trig = CreateTrigger()
        local integer i    = 15
        
        set AutoOn  = Event.create()
        set AutoOff = Event.create()
        
        loop
            call TriggerRegisterPlayerUnitEvent(trig,Player(i),EVENT_PLAYER_UNIT_ISSUED_ORDER,null)
            exitwhen i == 0
            set i = i - 1
        endloop
        
        call TriggerAddCondition(trig,Condition(function Actions))
        
        set OrderIds[0]  = 25  // Repair
        set OrderIds[1]  = 41  // Kaboom
        set OrderIds[2]  = 51  // Get Corpse
        set OrderIds[3]  = 64  // Heal
        set OrderIds[4]  = 67  // Inner Fire
        set OrderIds[5]  = 76  // Slow
        set OrderIds[6]  = 102 // Bloodlust
        set OrderIds[7]  = 133 // Abolish Magic
        set OrderIds[8]  = 150 // Faerie Fire
        set OrderIds[9]  = 158 // Recharge
        set OrderIds[10] = 162 // Renew
        set OrderIds[11] = 174 // Searing Arrows
        set OrderIds[12] = 191 // Curse
        set OrderIds[13] = 198 // Raise Dead
        set OrderIds[14] = 203 // Restore
        set OrderIds[15] = 212 // Web
        set OrderIds[16] = 244 // Cold Arrows
        set OrderIds[17] = 255 // Poison Arrows
        set OrderIds[18] = 458 // Frost Armor
        set OrderIds[19] = 484 // Spell Steal
        set OrderIds[20] = 540 // Orb of Annihilation
        set OrderIds[21] = 546 // Essence of Blight
        set OrderIds[22] = 549 // Spirit Touch
        set OrderIds[23] = 552 // Carrion Beetles
        set OrderIds[24] = 578 // Black Arrow
        set OrderIds[25] = 602 // Parasite
    
        loop
            exitwhen i == 26
            set ArrayIds[OrderIds<i>] = 1
            set ArrayIds[OrderIds<i> + 1] = 2
            set i = i + 1
        endloop
    endfunction

endlibrary
</i></i>


I suppose:

JASS:
local integer i = ArrayIds[S2I(SubString(I2S(GetIssuedOrderId()),3,6))]


Could be replaced with:

JASS:
local integer i = ArrayIds[GetIssuedOrderId() - 852000]


To make it a bit faster..
 

Azlier

Old World Ghost
That is indeed freakishly similar.

Wow. But, mine is better :p. Marginally.

And mine doesn't leak.

EDIT: Made even faster. On initialization, of course, where it doesn't really matter.
 

Kenny

Back for now.
Mind explaining where mine leaks? (I might actually use it later on).

Oh, and also, in what ways is yours marginally better? To me they look pretty similar.. Except instead of 26 function calls (each with 3 sets, before your update), I have 26 sets and 1 loop with 2 sets per iteration.

Personally I think my way is neater, as it doesn't use unwarrented function calls.
 

Azlier

Old World Ghost
Mine is slower on initialization. Yours is slower at runtime and leaks strings.
 

Kenny

Back for now.
>Mine is slower on initialization. Yours is slower at runtime and leaks strings.

Not if I switch to [ljass]local integer i = ArrayIds[GetIssuedOrderId() - 852000][/ljass] or even [ljass]set I = ArrayIds[GetIssuedOrderId() - 852000][/ljass] and use a global integer. :)
 

Azlier

Old World Ghost
Then you get something (possibly) slightly faster than mine, only at initialization. Yours trades 26 or so function calls for 52 array reads, 26 variable sets, and 26 exitwhen statements. Somehow, function calls sound better.

But why use 852000 over the perfect 0xD0000?
 

Kenny

Back for now.
>But why use 852000 over the perfect 0xD0000?

Because 0xD0000 equates to something like 851968 and the first autocast order starts at 852025.

So in hex format 0xD0000 looks perfect, but in decimal format 852000 looks perfect. :D

But yeah, they both seem to work, and the speed difference is negligible and not worth worrying about.

Anywho, once again, nice work with this. I think it will come in handy for many mappers.
 

Azlier

Old World Ghost
>I think it will come in handy for many mappers.

Not likely. However, this certainly has some very good uses.
 

Kenny

Back for now.
I think you are missing the [ljass]"incineratearrowon"[/ljass] and [ljass]"incineratearrowoff"[/ljass] orders. I don't have your print order library, but the order ids for them are:

- [ljass]852671[/ljass] - [ljass]0xD02BF[/ljass] - On
- [ljass]852672[/ljass] - [ljass]0xD02C0[/ljass] - Off
 

Azlier

Old World Ghost
I've never heard of such a spell!

Very well. Added.
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    The old shoutbox wasn't supported anymore. We updated xenForo, so it had to be replaced.
  • jonas jonas:
    let's see if everyone finds it... the nice thing about the shoutbox was I could check on it even while logged out, but the existence of this one is hidden when you're not logged in
  • Ghan Ghan:
    We can fix that.
  • Ghan Ghan:
    Chat should show on the sidebar when not logged in now.
  • Ghan Ghan:
    (You'll still need to log in to post messages)
  • Ghan Ghan:
    Test!
  • tom_mai78101 tom_mai78101:
    I must be in a test server.
  • tom_mai78101 tom_mai78101:
    Nice, Twitter tweets embedding now works
  • Wizard Wizard:
    Yup.
  • Ghan Ghan:
    Excellent.
  • Ghan Ghan:
    @tom_mai78101 Hello there.
  • Ghan Ghan:
    Tagging works in the chat too.
  • tom_mai78101 tom_mai78101:
    @Ghan Missed it.
  • Wizard Wizard:
    Still fixing things here and there. Added widgets to the portal, will make it match the ones here on the forum index tomorrow.
  • Ghan Ghan:
    The venerable World Editor Tutorials site has been converted to HTTPS at last.
  • jonas jonas:
    cool
  • jonas jonas:
    and I can even edit my messages, nice
  • seph ir oth seph ir oth:
    GENERAL CHIT CHAT, YOU ARE A BOLD ONE
  • Ghan Ghan:
    Hello there
  • The Helper The Helper:
    this new chatbox is great and the forum software update is great too
    +1
  • The Helper The Helper:
    upgrade has fixed forum registration spam problem
  • tom_mai78101 tom_mai78101:
    Something tells me we might be able to customize the chatbox a bit, considering that there's a gap under every message.
  • Wizard Wizard:
    Going to deploy a fix soon, just had to take some time for myself this weekend.
  • Varine Varine:
    Unbelievable. Time for yourself? How dare you!

    Members online

    No members online now.

    Affiliates

    Hive Workshop
    Top