Dynamic array/struct problem

Uberplayer · May 18, 2008

This is not the problem code, but works the same way.

JASS:

library Problem

    private struct Struct2
    endstruct
    
    private type type1 extends Struct2 array[2]
    private type type2 extends type1 array[2]
    
    struct Struct1
        private type2 type2_ar
        
        method Destroy takes nothing returns nothing
            call .type2_ar[0][0].destroy()
            call .type2_ar[0][1].destroy()
            call .type2_ar[1][0].destroy()
            call .type2_ar[1][1].destroy()
        endmethod
        
        method Create takes nothing returns nothing
            set .type2_ar[0][0] = Struct2.create()
            set .type2_ar[0][1] = Struct2.create()
            set .type2_ar[1][0] = Struct2.create()
            set .type2_ar[1][1] = Struct2.create()
        endmethod
    endstruct

endlibrary

This is the error message:

It seems to give the error for the third and fourth struct ([1][0] and [1][1]).

Steel · May 18, 2008

I thought JASS could not recognize a grid.

Uberplayer · May 19, 2008

What is a grid?

Cohadar · May 19, 2008

grid is a stupid name for matrix.

You forgot to create the matrix:

JASS:


set type2_ar = type2.create()

USE UPPERCASE FOR STRUCT AND TYPE NAMES DOUCHEBAG

Vexorian · May 19, 2008

Actually, considering the type names used by normal Jass, I would say lower case for type names is more suitable for a standard.

Cohadar · May 19, 2008

I have the same opinion about persons who designed normal jass as of persons who designed cobol.

Uberplayer · May 19, 2008

>You forgot to create the matrix..
I tried, but it gives the same error.

JASS:

library Problem

    private struct Struct2
    endstruct
    
    private type type1 extends Struct2 array[2]
    private type type2 extends type1 array[2]
    
    struct Struct1
        private type2 type2_ar
        
        method Destroy takes nothing returns nothing
            call BJDebugMsg(I2S(.type2_ar[0][0]))
            call BJDebugMsg(I2S(.type2_ar[0][1]))
            call BJDebugMsg(I2S(.type2_ar[1][0]))
            call BJDebugMsg(I2S(.type2_ar[1][1]))
        
            call .type2_ar[0][0].destroy()
            call .type2_ar[0][1].destroy()
            call .type2_ar[1][0].destroy()
            call .type2_ar[1][1].destroy()
        endmethod
        
        method Create takes nothing returns nothing
            set .type2_ar[0][0] = Struct2.create()
            set .type2_ar[0][1] = Struct2.create()
            set .type2_ar[1][0] = Struct2.create()
            set .type2_ar[1][1] = Struct2.create()
        endmethod
    endstruct

endlibrary

The debug messages, by the way, show:
3
4
3
4
"double free.."
"double free.."

Builder Bob · May 19, 2008

You can do it like this.

JASS:

library Problem

	private struct Struct2
	endstruct
	
	private type type1 extends Struct2 array[2]
	private type type2 extends type1 array[2]
	
	struct Struct1
		private type2 type2_ar
		
		method Destroy takes nothing returns nothing
			call BJDebugMsg(I2S(.type2_ar[0][0]))
			call BJDebugMsg(I2S(.type2_ar[0][1]))
			call BJDebugMsg(I2S(.type2_ar[1][0]))
			call BJDebugMsg(I2S(.type2_ar[1][1]))
		
			call .type2_ar[0][0].destroy()
			call .type2_ar[0][1].destroy()
			call .type2_ar[1][0].destroy()
			call .type2_ar[1][1].destroy()
		endmethod
		
		static method create takes nothing returns Struct1
			local Struct1 str = Struct1.allocate()
			local integer i = 0
			set str.type2_ar = type2.create()
			loop
				set str.type2_ar<i> = type1.create()
				set i = i + 1
				exitwhen(i == 2)
			endloop
			set str.type2_ar[0][0] = Struct2.create()
			set str.type2_ar[0][1] = Struct2.create()
			set str.type2_ar[1][0] = Struct2.create()
			set str.type2_ar[1][1] = Struct2.create()
			return str
		endmethod
		
	endstruct
	
	public function InitTrig takes nothing returns nothing
		local Struct1 str = Struct1.create()
		call str.Destroy()
	endfunction

endlibrary</i>

Uberplayer · May 19, 2008

Awesome.

You sure that the destroying part gets rid of everything?

Builder Bob · May 19, 2008

I'm afraid I don't know enough about it to say for sure if this is the correct way to do it. I've never used it more than just trying it out.

Cohadar · May 20, 2008

Do I have to spell everything.

JASS:


library Problem

    private struct Struct2
    endstruct
    
    private type type1 extends Struct2 array[2]
    private type type2 extends type1 array[2]
    
    struct Struct1
        private type2 type2_ar
        
        method Destroy takes nothing returns nothing
            call .type2_ar[0][0].destroy()
            call .type2_ar[0][1].destroy()
            call .type2_ar[1][0].destroy()
            call .type2_ar[1][1].destroy()
            call .type2_ar.destroy() // destroy the matrix after
        endmethod
        
        method Create takes nothing returns nothing
            set .type2_ar = type2.create() // create the matrix before
            set .type2_ar[0][0] = Struct2.create()
            set .type2_ar[0][1] = Struct2.create()
            set .type2_ar[1][0] = Struct2.create()
            set .type2_ar[1][1] = Struct2.create()
        endmethod
    endstruct

endlibrary

Uberplayer · May 20, 2008

It's still giving the double free error.

Cohadar · May 20, 2008

You are doing something wrong.
TIP: never say "it does not work" without showing the new code.

Uberplayer · May 20, 2008

I used your code. So you did something wrong, obviously.

But if you want to see the code, sure:

Cohadar said:

Do I have to spell everything.

JASS:


library Problem

    private struct Struct2
    endstruct
    
    private type type1 extends Struct2 array[2]
    private type type2 extends type1 array[2]
    
    struct Struct1
        private type2 type2_ar
        
        method Destroy takes nothing returns nothing
            call .type2_ar[0][0].destroy()
            call .type2_ar[0][1].destroy()
            call .type2_ar[1][0].destroy()
            call .type2_ar[1][1].destroy()
            call .type2_ar.destroy() // destroy the matrix after
        endmethod
        
        method Create takes nothing returns nothing
            set .type2_ar = type2.create() // create the matrix before
            set .type2_ar[0][0] = Struct2.create()
            set .type2_ar[0][1] = Struct2.create()
            set .type2_ar[1][0] = Struct2.create()
            set .type2_ar[1][1] = Struct2.create()
        endmethod
    endstruct

endlibrary

Builder Bob · May 20, 2008

The debug messages, by the way, show:
3
4
3
4
"double free.."
"double free.."

this hardly counts as "it does not work"

I'll take a wild guess and suggest the code

JASS:

library Problem

private struct Struct2
endstruct

private type type1 extends Struct2 array[2]
private type type2 extends type1 array[2]

struct Struct1
	private type2 type2_ar
	
	method Destroy takes nothing returns nothing
		local integer i = 0
		call BJDebugMsg(I2S(.type2_ar[0][0]))
		call BJDebugMsg(I2S(.type2_ar[0][1]))
		call BJDebugMsg(I2S(.type2_ar[1][0]))
		call BJDebugMsg(I2S(.type2_ar[1][1]))
	
		call .type2_ar[0][0].destroy()
		call .type2_ar[0][1].destroy()
		call .type2_ar[1][0].destroy()
		call .type2_ar[1][1].destroy()
		
		loop
			call .type2_ar<i>.destroy()
			set i = i + 1
			exitwhen(i == 2)
		endloop
		call .type2_ar.destroy()
		
	endmethod
	
	static method create takes nothing returns Struct1
		local Struct1 str = Struct1.allocate()
		local integer i = 0
		set str.type2_ar = type2.create()
		loop
			set str.type2_ar<i> = type1.create()
			set i = i + 1
			exitwhen(i == 2)
		endloop
		set str.type2_ar[0][0] = Struct2.create()
		set str.type2_ar[0][1] = Struct2.create()
		set str.type2_ar[1][0] = Struct2.create()
		set str.type2_ar[1][1] = Struct2.create()
		return str
	endmethod
	
endstruct

public function InitTrig takes nothing returns nothing
	local Struct1 str = Struct1.create()
	call str.Destroy()
endfunction

endlibrary</i></i>

Now someone with more knowledge can point out any errors.

It compiles, and shows the error messages:
1
2
3
4
as expected.

question is, is it destroyed correctly and in the right order?

I hope you don't mind me taking interest in this even though I don't know too much about it Uberplayer. I've been wondering about the same thing for a while.

TheDamien · May 20, 2008

Cohadar's code does not work because "type1"s are not being created.

Try:

JASS:

library Problem

    private struct Struct2
    endstruct
    
    private type type1 extends Struct2 array[2]
    private type type2 extends type1 array[2]
    
    struct Struct1
        private type2 type2_ar
        
        method Destroy takes nothing returns nothing
            call .type2_ar[0][0].destroy()
            call .type2_ar[0][1].destroy()
            call .type2_ar[1][0].destroy()
            call .type2_ar[1][1].destroy()
            call .type2_ar[0].destroy()
            call .type2_ar[1].destroy()
            call .type2_ar.destroy() // destroy the matrix after
        endmethod
        
        method Create takes nothing returns nothing
            set .type2_ar = type2.create() // create the matrix before
            set .type2_ar[0] = type1.create()
            set .type2_ar[1] = type1.create()
            set .type2_ar[0][0] = Struct2.create()
            set .type2_ar[0][1] = Struct2.create()
            set .type2_ar[1][0] = Struct2.create()
            set .type2_ar[1][1] = Struct2.create()
        endmethod
    endstruct

endlibrary

Cohadar · May 20, 2008

It looks about right now.

So you must create the matrix, than create all the rows and then individual fields...

for destroying in reverse.

Dynamic array/struct problem

-

Software Engineer

-

master of fugue

Why no custom sig?

master of fugue

-

Live free or don't

-

Live free or don't

master of fugue

-

master of fugue

-

Live free or don't

_

master of fugue

Log in

The Helper Discord

Share this page

Affiliates

Network Sponsors