Is this multiboard working?

[Dasslokk]

I decided to make a multiboard for my new map and I have never made one before.
That's why I need someone more experienced to look through the trigger. It's a 6v6 hero arena and the 4 extra rows are "team 1", "team 2" and a total kills field for both teams.

Here's the trigger:

• Multiboard
  • Events
    • Unit - A unit enters (Playable map area)
  • Conditions
  • Actions
    • Set Number_of_players = (Number of players in (All players matching ((((Matching player) slot status) Equal to Is playing) and (((Matching player) controller) Equal to User))))
    • Set Players_team_1 = (Number of players in (All players matching ((((Matching player) slot status) Equal to Is playing) and ((((Matching player) controller) Equal to User) and ((Team number of (Matching player)) Equal to 2)))))
    • Multiboard - Create a multiboard with 4 columns and (Number_of_players + 4) rows, titled Info
    • Multiboard - Set the display style for (Last created multiboard) item in column 0, row 0 to Show text and Hide icons
    • Multiboard - Set the width for (Last created multiboard) item in column 1, row 0 to 5.00% of the total screen width
    • Multiboard - Set the text for (Last created multiboard) item in column 1, row 1 to Team 1
    • Multiboard - Set the text for (Last created multiboard) item in column 2, row 1 to Level
    • Multiboard - Set the text for (Last created multiboard) item in column 3, row 1 to Kills
    • Multiboard - Set the text for (Last created multiboard) item in column 4, row 1 to Deaths
    • Player Group - Pick every player in (All players matching ((((Matching player) controller) Equal to User) and (((Matching player) slot status) Equal to Is playing))) and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Picked player) is in (All allies of Player 1 (Red))) Equal to True
          • Then - Actions
            • Multiboard - Set the text for (Last created multiboard) item in column 1, row ((Player number of (Picked player)) + 1) to (Name of (Picked player))
          • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • ((Picked player) is in (All allies of Player 7 (Green))) Equal to True
              • Then - Actions
                • Multiboard - Set the text for (Last created multiboard) item in column 1, row (Players_team_1 + ((Player number of (Picked player)) - 3)) to (Name of (Picked player))
              • Else - Actions
    • Multiboard - Set the text for (Last created multiboard) item in column 1, row (Players_team_1 + 3) to Team 2
    • Player Group - Pick every player in (All players matching ((((Matching player) controller) Equal to User) and (((Matching player) slot status) Equal to Is playing))) and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Picked player) is in (All allies of Player 1 (Red))) Equal to True
          • Then - Actions
            • Multiboard - Set the text for (Last created multiboard) item in column 2, row ((Player number of (Picked player)) + 1) to (String((Hero level of (Random unit from (Units owned by (Picked player) matching (((Matching unit) is A Hero) Equal to True))))))
          • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • ((Picked player) is in (All allies of Player 7 (Green))) Equal to True
              • Then - Actions
                • Multiboard - Set the text for (Last created multiboard) item in column 2, row (Players_team_1 + ((Player number of (Picked player)) - 3)) to (String((Hero level of (Random unit from (Units owned by (Picked player) matching (((Matching unit) is A Hero) Equal to True))))))
              • Else - Actions
    • Player Group - Pick every player in (All players matching ((((Matching player) controller) Equal to User) and (((Matching player) slot status) Equal to Is playing))) and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Picked player) is in (All allies of Player 1 (Red))) Equal to True
          • Then - Actions
            • Multiboard - Set the text for (Last created multiboard) item in column 3, row ((Player number of (Picked player)) + 1) to (String(Kills[(Player number of (Picked player))]))
          • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • ((Picked player) is in (All allies of Player 7 (Green))) Equal to True
              • Then - Actions
                • Multiboard - Set the text for (Last created multiboard) item in column 1, row (Players_team_1 + ((Player number of (Picked player)) - 3)) to (String(Kills[(Player number of (Picked player))]))
              • Else - Actions
    • Player Group - Pick every player in (All players matching ((((Matching player) controller) Equal to User) and (((Matching player) slot status) Equal to Is playing))) and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Picked player) is in (All allies of Player 1 (Red))) Equal to True
          • Then - Actions
            • Multiboard - Set the text for (Last created multiboard) item in column 4, row ((Player number of (Picked player)) + 1) to (String(Deaths[(Player number of (Picked player))]))
          • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • ((Picked player) is in (All allies of Player 7 (Green))) Equal to True
              • Then - Actions
                • Multiboard - Set the text for (Last created multiboard) item in column 4, row (Players_team_1 + ((Player number of (Picked player)) - 3)) to (String(Deaths[(Player number of (Picked player))]))
              • Else - Actions
    • Multiboard - Show (Last created multiboard)
    • Multiboard - Maximize (Last created multiboard)

 

[Komaqtion]

You desperatly need to change the event ! Use:

• Time - Elapsed game time is 0.01 seconds

Will look through the trigger now

Ok, you have a couple of player group leaks there... You need to set this to a player-group variable:

Player Group - Pick every player in [COLOR="Red"](All players matching ((((Matching player) controller) Equal to User) and (((Matching player) slot status) Equal to Is playing)))[/COLOR] and do (Actions)

Then use this line to remove the leaks (At the very end of the trigger):

• Custom script: call DestroyForce(udg_<span style="color: Red">Your_Variable</span>)

(Change the red part to your player-group variable name )

And also, you should merge all thise if's and player group actions into one:

• Player Group - Pick every player in (All players matching ((((Matching player) controller) Equal to User) and (((Matching player) slot status) Equal to Is playing))) and do (Actions)
  • Loop - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Picked player) is in (All allies of Player 1 (Red))) Equal to True
      • Then - Actions
        • Multiboard - Set the text for (Last created multiboard) item in column 1, row ((Player number of (Picked player)) + 1) to (Name of (Picked player))
        • Multiboard - Set the text for (Last created multiboard) item in column 2, row ((Player number of (Picked player)) + 1) to (String((Hero level of (Random unit from (Units owned by (Picked player) matching (((Matching unit) is A Hero) Equal to True))))))
        • Multiboard - Set the text for (Last created multiboard) item in column 3, row ((Player number of (Picked player)) + 1) to (String(Kills[(Player number of (Picked player))]))
        • Multiboard - Set the text for (Last created multiboard) item in column 4, row ((Player number of (Picked player)) + 1) to (String(Deaths[(Player number of (Picked player))]))
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Picked player) is in (All allies of Player 7 (Green))) Equal to True
          • Then - Actions
            • Multiboard - Set the text for (Last created multiboard) item in column 1, row (Players_team_1 + ((Player number of (Picked player)) - 3)) to (Name of (Picked player))
            • Multiboard - Set the text for (Last created multiboard) item in column 2, row (Players_team_1 + ((Player number of (Picked player)) - 3)) to (String((Hero level of (Random unit from (Units owned by (Picked player) matching (((Matching unit) is A Hero) Equal to True))))))
            • Multiboard - Set the text for (Last created multiboard) item in column 1, row (Players_team_1 + ((Player number of (Picked player)) - 3)) to (String(Kills[(Player number of (Picked player))]))
            • Multiboard - Set the text for (Last created multiboard) item in column 4, row (Players_team_1 + ((Player number of (Picked player)) - 3)) to (String(Deaths[(Player number of (Picked player))]))
          • Else - Actions

And also just noticed one thing:

Multiboard - Set the text for (Last created multiboard) item in [COLOR="Red"]column 1[/COLOR], row (Players_team_1 + ((Player number of (Picked player)) - 3)) to (String(Kills[(Player number of (Picked player))]))

Red part should be 3 right ?? :S

 

[Dasslokk]

Thanks a lot rep added ofc.
FYI:
The event will be a variable, because you will play untill a team reaches a selected kill limit and then repicks hero and arena.

I did what (I think) you said, and now the trigger looks like this:
(is it correct now?)

• Multiboard
  • Events
  • Conditions
  • Actions
    • Set Number_of_players = (Number of players in (All players matching ((((Matching player) slot status) Equal to Is playing) and (((Matching player) controller) Equal to User))))
    • Set Players_team_1 = (Number of players in (All players matching ((((Matching player) slot status) Equal to Is playing) and ((((Matching player) controller) Equal to User) and ((Team number of (Matching player)) Equal to 2)))))
    • Multiboard - Create a multiboard with 4 columns and (Number_of_players + 4) rows, titled Info
    • Multiboard - Set the display style for (Last created multiboard) item in column 0, row 0 to Show text and Hide icons
    • Multiboard - Set the width for (Last created multiboard) item in column 1, row 0 to 5.00% of the total screen width
    • Multiboard - Set the text for (Last created multiboard) item in column 1, row 1 to Team 1
    • Multiboard - Set the text for (Last created multiboard) item in column 2, row 1 to Level
    • Multiboard - Set the text for (Last created multiboard) item in column 3, row 1 to Kills
    • Multiboard - Set the text for (Last created multiboard) item in column 4, row 1 to Deaths
    • Set Player_group_variable = (All players matching ((((Matching player) controller) Equal to User) and (((Matching player) slot status) Equal to Is playing)))
    • Player Group - Pick every player in Player_group_variable and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Picked player) is in (All allies of Player 1 (Red))) Equal to True
          • Then - Actions
            • Multiboard - Set the text for (Last created multiboard) item in column 1, row ((Player number of (Picked player)) + 1) to (Name of (Picked player))
            • Multiboard - Set the text for (Last created multiboard) item in column 2, row ((Player number of (Picked player)) + 1) to (String((Hero level of (Random unit from (Units owned by (Picked player) matching (((Matching unit) is A Hero) Equal to True))))))
            • Multiboard - Set the text for (Last created multiboard) item in column 3, row ((Player number of (Picked player)) + 1) to (String(Kills[(Player number of (Picked player))]))
            • Multiboard - Set the text for (Last created multiboard) item in column 4, row ((Player number of (Picked player)) + 1) to (String(Deaths[(Player number of (Picked player))]))
          • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • ((Picked player) is in (All allies of Player 7 (Green))) Equal to True
              • Then - Actions
                • Multiboard - Set the text for (Last created multiboard) item in column 1, row (Players_team_1 + ((Player number of (Picked player)) - 3)) to (Name of (Picked player))
                • Multiboard - Set the text for (Last created multiboard) item in column 2, row (Players_team_1 + ((Player number of (Picked player)) - 3)) to (String((Hero level of (Random unit from (Units owned by (Picked player) matching (((Matching unit) is A Hero) Equal to True))))))
                • Multiboard - Set the text for (Last created multiboard) item in column 3, row (Players_team_1 + ((Player number of (Picked player)) - 3)) to (String(Kills[(Player number of (Picked player))]))
                • Multiboard - Set the text for (Last created multiboard) item in column 4, row (Players_team_1 + ((Player number of (Picked player)) - 3)) to (String(Deaths[(Player number of (Picked player))]))
              • Else - Actions
    • Multiboard - Set the text for (Last created multiboard) item in column 1, row (Players_team_1 + 3) to Team 2
    • Multiboard - Show (Last created multiboard)
    • Multiboard - Maximize (Last created multiboard)
    • Custom script: call DestroyForce(udg_Player_group_variable)

 

[Komaqtion]

Much better

 

[GetTriggerUnit-]

The event could be 0.00 unless 0.01, makes all the diffence IMO.

 

[Komaqtion]

Some things, I've noticed, bugs when 0.00 so I suggested 0.01... But might only be me, or something with the triggers I've done XD

 

[Gtam]

Nope 0.00 does bug sometimes with certain things

 

[GetTriggerUnit-]

Okay then
Geezus,
I never use Multiboards.