Leak Check

[junicobakura]

If you may... Please check if there are leaks in my trigger

• Getsuga Tenshou
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Getsuga Tenshou
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Triggering unit) has buff Tensa Zangetsu ) Equal to False
      • Then - Actions
        • Set TenshouCastLoc = (Position of (Triggering unit))
        • Set TenshouTargLoc = (Target point of ability being cast)
        • Unit - Create 1 Dummy Caster for (Owner of (Triggering unit)) at TenshouCastLoc facing TenshouTargLoc
        • Unit - Add Getsuga Tenshou (Normal) to (Last created unit)
        • Unit - Set level of Getsuga Tenshou (Normal) for (Last created unit) to (Level of Getsuga Tenshou for (Triggering unit))
        • Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
        • Unit - Order (Last created unit) to Orc Tauren Chieftain - Shockwave TenshouTargLoc
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Triggering unit) has buff Hollowfication ) Equal to False
          • Then - Actions
            • Set TenshouCastLoc = (Position of (Triggering unit))
            • Set TenshouTargLoc = (Target point of ability being cast)
            • Unit - Create 1 Dummy Caster for (Owner of (Triggering unit)) at TenshouCastLoc facing TenshouTargLoc
            • Unit - Add Getsuga Tenshou (Bankai) to (Last created unit)
            • Unit - Set level of Getsuga Tenshou (Bankai) for (Last created unit) to (Level of Getsuga Tenshou for (Triggering unit))
            • Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
            • Unit - Order (Last created unit) to Orc Tauren Chieftain - Shockwave TenshouTargLoc
          • Else - Actions
            • Set TenshouCastLoc = (Position of (Triggering unit))
            • Set TenshouTargLoc = (Target point of ability being cast)
            • Unit - Create 1 Dummy Caster for (Owner of (Triggering unit)) at TenshouCastLoc facing TenshouTargLoc
            • Unit - Add Getsuga Tenshou (Bankai) to (Last created unit)
            • Unit - Set level of Getsuga Tenshou (Bankai) for (Last created unit) to (Level of Getsuga Tenshou for (Triggering unit))
            • Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
            • Unit - Order (Last created unit) to Orc Tauren Chieftain - Shockwave TenshouTargLoc
            • Unit - Create 1 Dummy Caster for (Owner of (Triggering unit)) at TenshouCastLoc facing TenshouTargLoc
            • Unit - Add Getsuga Tenshou (Hollow Bonus) to (Last created unit)
            • Unit - Set level of Getsuga Tenshou (Hollow Bonus) for (Last created unit) to (Level of Getsuga Tenshou for (Triggering unit))
            • Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
            • Unit - Order (Last created unit) to Orc Tauren Chieftain - Shockwave TenshouTargLoc
    • Custom script: call RemoveLocation(udg_TenshouCastLoc)
    • Custom script: call RemoveLocation(udg_TenshouTargLoc)

 

[skyblader]

Yeah. You used the 2 point variables twice, but you only cleared it once. Clear it once move before you set it for the second time.

 

[DioD]

there is no leaks possible to fix from GUI.

also you may set dummy units explode on death, this will remove them instantly without any delay on death.

 

[junicobakura]

so these?

• Getsuga Tenshou
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Getsuga Tenshou
  • Actions
    • Set TenshouCastLoc = (Position of (Triggering unit))
    • Set TenshouTargLoc = (Target point of ability being cast)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Triggering unit) has buff Tensa Zangetsu ) Equal to False
      • Then - Actions
        • Unit - Create 1 Dummy Caster for (Owner of (Triggering unit)) at TenshouCastLoc facing TenshouTargLoc
        • Unit - Make (Last created unit) Explode on death
        • Unit - Add Getsuga Tenshou (Normal) to (Last created unit)
        • Unit - Set level of Getsuga Tenshou (Normal) for (Last created unit) to (Level of Getsuga Tenshou for (Triggering unit))
        • Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
        • Unit - Order (Last created unit) to Orc Tauren Chieftain - Shockwave TenshouTargLoc
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Triggering unit) has buff Hollowfication ) Equal to False
          • Then - Actions
            • Unit - Create 1 Dummy Caster for (Owner of (Triggering unit)) at TenshouCastLoc facing TenshouTargLoc
            • Unit - Make (Last created unit) Explode on death
            • Unit - Add Getsuga Tenshou (Bankai) to (Last created unit)
            • Unit - Set level of Getsuga Tenshou (Bankai) for (Last created unit) to (Level of Getsuga Tenshou for (Triggering unit))
            • Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
            • Unit - Order (Last created unit) to Orc Tauren Chieftain - Shockwave TenshouTargLoc
          • Else - Actions
            • Unit - Create 1 Dummy Caster for (Owner of (Triggering unit)) at TenshouCastLoc facing TenshouTargLoc
            • Unit - Make (Last created unit) Explode on death
            • Unit - Add Getsuga Tenshou (Bankai) to (Last created unit)
            • Unit - Set level of Getsuga Tenshou (Bankai) for (Last created unit) to (Level of Getsuga Tenshou for (Triggering unit))
            • Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
            • Unit - Order (Last created unit) to Orc Tauren Chieftain - Shockwave TenshouTargLoc
            • Unit - Create 1 Dummy Caster for (Owner of (Triggering unit)) at TenshouCastLoc facing TenshouTargLoc
            • Unit - Make (Last created unit) Explode on death
            • Unit - Add Getsuga Tenshou (Hollow Bonus) to (Last created unit)
            • Unit - Set level of Getsuga Tenshou (Hollow Bonus) for (Last created unit) to (Level of Getsuga Tenshou for (Triggering unit))
            • Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
            • Unit - Order (Last created unit) to Orc Tauren Chieftain - Shockwave TenshouTargLoc
    • Custom script: call RemoveLocation(udg_TenshouCastLoc)
    • Custom script: call RemoveLocation(udg_TenshouTargLoc)

 

[TomTTT]

so these?

• Getsuga Tenshou
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Getsuga Tenshou
  • Actions
    • Set TenshouCastLoc = (Position of (Triggering unit))
    • Set TenshouTargLoc = (Target point of ability being cast)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Triggering unit) has buff Tensa Zangetsu ) Equal to False
      • Then - Actions
        • Unit - Create 1 Dummy Caster for (Owner of (Triggering unit)) at TenshouCastLoc facing TenshouTargLoc
        • Unit - Make (Last created unit) Explode on death
        • Unit - Add Getsuga Tenshou (Normal) to (Last created unit)
        • Unit - Set level of Getsuga Tenshou (Normal) for (Last created unit) to (Level of Getsuga Tenshou for (Triggering unit))
        • Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
        • Unit - Order (Last created unit) to Orc Tauren Chieftain - Shockwave TenshouTargLoc
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Triggering unit) has buff Hollowfication ) Equal to False
          • Then - Actions
            • Unit - Create 1 Dummy Caster for (Owner of (Triggering unit)) at TenshouCastLoc facing TenshouTargLoc
            • Unit - Make (Last created unit) Explode on death
            • Unit - Add Getsuga Tenshou (Bankai) to (Last created unit)
            • Unit - Set level of Getsuga Tenshou (Bankai) for (Last created unit) to (Level of Getsuga Tenshou for (Triggering unit))
            • Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
            • Unit - Order (Last created unit) to Orc Tauren Chieftain - Shockwave TenshouTargLoc
          • Else - Actions
            • Unit - Create 1 Dummy Caster for (Owner of (Triggering unit)) at TenshouCastLoc facing TenshouTargLoc
            • Unit - Make (Last created unit) Explode on death
            • Unit - Add Getsuga Tenshou (Bankai) to (Last created unit)
            • Unit - Set level of Getsuga Tenshou (Bankai) for (Last created unit) to (Level of Getsuga Tenshou for (Triggering unit))
            • Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
            • Unit - Order (Last created unit) to Orc Tauren Chieftain - Shockwave TenshouTargLoc
            • Unit - Create 1 Dummy Caster for (Owner of (Triggering unit)) at TenshouCastLoc facing TenshouTargLoc
            • Unit - Make (Last created unit) Explode on death
            • Unit - Add Getsuga Tenshou (Hollow Bonus) to (Last created unit)
            • Unit - Set level of Getsuga Tenshou (Hollow Bonus) for (Last created unit) to (Level of Getsuga Tenshou for (Triggering unit))
            • Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
            • Unit - Order (Last created unit) to Orc Tauren Chieftain - Shockwave TenshouTargLoc
    • Custom script: call RemoveLocation(udg_TenshouCastLoc)
    • Custom script: call RemoveLocation(udg_TenshouTargLoc)

You used once at start and once in Else/Then actions.
Before you set the same variable again, you must clean it

 

[skyblader]

You used once at start and once in Else/Then actions.
Before you set the same variable again, you must clean it

He only used it once in his second trigger...

 

[junicobakura]

He only used it once in his second trigger...

is it okay now in the second trigger?

 

[skyblader]

As far as I know, there shouldn't be anymore leaks. :thup:

 

[DioD]

ever in first version there is only one call.

next step is removing useless code by moving it outside if blocks, you create unit anyway, soo this call shoud be outside if block, same with other actions shared with every condition