Quick Leak Check

[the_ideal]

• Tome Given
  • Events
  • Conditions
    • ((Triggering unit) is A Hero) Equal to True
  • Actions
    • Set point2 = (Position of (Triggering unit))
    • Set unitgroup = (Units of type Floating Tome)
    • Unit Group - Pick every unit in unitgroup and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Picked unit) is in UsedTomesByPlayer[(Player number of (Owner of (Triggering unit)))]) Equal to False
            • (Distance between (Position of (Picked unit)) and (Position of (Triggering unit))) Less than 104.00
          • Then - Actions
            • Unit Group - Add (Picked unit) to UsedTomesByPlayer[(Player number of (Owner of (Triggering unit)))]
            • Set point2 = (Center of (Playable map area))
            • Item - Create Manual of Health at point1
            • Custom script: call RemoveLocation (udg_point1)
            • Hero - Give (Last created item) to (Triggering unit)
          • Else - Actions
    • Custom script: call DestroyGroup(udg_unitgroup)
    • Custom script: call RemoveLocation (udg_point2)

Does this have any leaks I haven't fixed?

Thanks a lot.

 

[ludnica]

Well, "point1" is not set. (Position of (Picked unit)) and (Position of Triggering unit)) also - those two are in *Distance between*.

 

[Dinowc]

Set point2 = (Center of (Playable map area))

shouldn't this should be: Set point1 = (Center of (Playable map area)) ?

you also leak 2 points here:

Distance between (Position of (Picked unit)) and (Position of (Triggering unit))) Less than 104.00

 

[Accname]

as far as i know the condition:

• (Distance between (Position of (Picked unit)) and (Position of (Triggering unit))) Less than 104.00

does leak the point variables.

 

[HydraRancher]

Did you actually try your trigger, cos it should fail