Quick question about memory leaks

[ThePlague]

set udg_tempunit= GetTriggerUnit()

since this is a global and will be overwritten constantly is there any need to nullify this?

also since it is only temporary to avoid leaking with GetTriggerUnit()
does it make any difference if i use
set udg_tempunit= GetTriggerUnit()
or
local unit temp= GetTriggerUnit()

Edit: this is just for simple triggers with few actions and no waits

 

[Artificial]

> since this is a global and will be overwritten constantly is there any need to nullify this?
Nope, there isn't any need to null globals.

> avoid leaking with GetTriggerUnit()
GetTriggerUnit doesn't leak...

> does it make any difference if i use [...]
You need to null locals, but there's not much of other difference in there.

 

[AceHart]

> set udg_tempunit= GetTriggerUnit()

No leak here, no other action needed.

> local unit temp= GetTriggerUnit()

One extra action needed: set temp = null when done.

 

[ThePlague]

really? I thought all of the generic variables triggering unit, casting unit, etc leaked.

Is this only true for triggering UNit or are tehre others that do not leak?


New question also is there any advantage to using condition and action functions seperately? or can i just use:

if condition then
actions
endif
(with no other actions so nothing would happen)

or

if opposite condition then
return
endif
actions

 

[AceHart]

The test needs to be done either way, so no win there.
With condition functions though, the code tends to be cleaner.

 

[ThePlague]

k thanks those questions have been bugging me for a while