Spellpack D.V.D Passive Spells

[D.V.D]

Hey guys, i made some passive spells for fun. First one is from my tutorial Passive Mirror Image. Second one is passive explosion. Codes are below and please give me credit if you use these in your map! Enjoy !

Passive Mirror Image

Spoiler

Passive Mirror Image
    Events
        Unit - A unit Is attacked
    Conditions
    Actions
        Set Caster = (Triggering unit)
        Set Point[0] = (Position of Caster)
        Set Player = (Owner of Caster)
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                (Level of Passive Mirror Image for Caster) Equal to 1
            Then - Actions
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        (Random integer number between 1 and 100) Less than or equal to 10
                    Then - Actions
                        Unit - Create 1 Dummy for Player at Point[0] facing Point[0]
                        Set Dummy = (Last created unit)
                        Unit - Add Inventory (Hero) to Dummy
                        Hero - Create Wand of Illusion and give it to Dummy
                        Set Item = (Last created item)
                        Hero - Order Dummy to use Item on Caster
                        Unit - Add a 1.00 second Generic expiration timer to Dummy
                    Else - Actions
            Else - Actions
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        (Level of Passive Mirror Image for Caster) Equal to 2
                    Then - Actions
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                (Random integer number between 1 and 100) Less than or equal to 12
                            Then - Actions
                                Unit - Create 1 Dummy for Player at Point[0] facing Point[0]
                                Set Dummy = (Last created unit)
                                Unit - Add Inventory (Hero) to Dummy
                                Hero - Create Wand of Illusion and give it to Dummy
                                Set Item = (Last created item)
                                Hero - Order Dummy to use Item on Caster
                                Unit - Add a 1.00 second Generic expiration timer to Dummy
                            Else - Actions
                    Else - Actions
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        (Level of Passive Mirror Image for Caster) Equal to 3
                    Then - Actions
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                (Random integer number between 1 and 100) Less than or equal to 15
                            Then - Actions
                                Unit - Create 1 Dummy for Player at Point[0] facing Point[0]
                                Set Dummy = (Last created unit)
                                Unit - Add Inventory (Hero) to Dummy
                                Hero - Create Wand of Illusion and give it to Dummy
                                Set Item = (Last created item)
                                Hero - Order Dummy to use Item on Caster
                                Unit - Add a 1.00 second Generic expiration timer to Dummy
                            Else - Actions
                    Else - Actions
        Custom script:   call RemoveLocation (udg_Point[0])
        Custom script:   set udg_Caster = null
        Custom script:   set udg_Dummy = null
        Custom script:   set udg_Target = null

Passive Explosion

Spoiler

Passive Explosion
    Events
        Unit - A unit Is attacked
    Conditions
    Actions
        Set Caster = (Triggering unit)
        Set Target = (Attacking unit)
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                (Level of Passive Explosion for Caster) Equal to 1
            Then - Actions
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        (Random integer number between 1 and 100) Less than or equal to 12
                    Then - Actions
                        Special Effect - Create a special effect at (Position of (Attacking unit)) using Objects\Spawnmodels\Human\FragmentationShards\FragBoomSpawn.mdl
                        Set SpecialEffect = (Last created special effect)
                        Unit - Cause Caster to damage Target, dealing 50.00 damage of attack type Spells and damage type Normal
                        Special Effect - Destroy SpecialEffect
                    Else - Actions
            Else - Actions
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        (Level of Passive Explosion for Caster) Equal to 2
                    Then - Actions
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                (Random integer number between 1 and 100) Less than or equal to 15
                            Then - Actions
                                Special Effect - Create a special effect at (Position of (Attacking unit)) using Objects\Spawnmodels\Human\FragmentationShards\FragBoomSpawn.mdl
                                Set SpecialEffect = (Last created special effect)
                                Unit - Cause Caster to damage Target, dealing 60.00 damage of attack type Spells and damage type Normal
                                Special Effect - Destroy SpecialEffect
                            Else - Actions
                    Else - Actions
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        (Level of Passive Explosion for (Triggering unit)) Equal to 3
                    Then - Actions
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                (Random integer number between 1 and 100) Less than or equal to 20
                            Then - Actions
                                Special Effect - Create a special effect at (Position of (Attacking unit)) using Objects\Spawnmodels\Human\FragmentationShards\FragBoomSpawn.mdl
                                Set SpecialEffect = (Last created special effect)
                                Unit - Cause Caster to damage Target, dealing 80.00 damage of attack type Spells and damage type Normal
                                Special Effect - Destroy SpecialEffect
                            Else - Actions
                    Else - Actions
        Custom script:   set udg_Caster = null
        Custom script:   set udg_Target = null

 

[Jagan]

Screenshots? And your code is not efficient. You're setting ifs for every level of the ability instead of setting them accordingly in one.

 

[Kazuga]

The spells are bad coded and extremely simple. You should just use a loop so it works for all levels, and demanding credits for a spell is a bit rude.

How you can improve the spells:
Add special effects, it gives more eye candy.
Make it more unique, these spells can be found in other maps as well, try to add something more to the spells. For instance, add extra attack/move speed for x seconds to the passive mirror image.

 

[D.V.D]

First of all, im not demanding credit, second of all, I'll make them better and I'll make more during the weekend when I have time.

 

[Sevion]

"please give me credit if you use these in your map!"

Yes you are.

You should try learning JASS and optimizing it.

The spells seem a little bland IMHO.

 

[Jagan]

Oh and I forgot to mention the Positions of Attacking Units in your Passive Explosion trigger leaks. Clean 'em up.

 

[Flare]

You could do alot of improvement for the If's (taking Mirror Image as the example) - instead of 3 if's, you could do

Random integer between 1 and 100 is less than or equal to R2I (7.5 + 2.5x I2R (Level of Ability for Unit))

(R2I = Real 2 Integer, I2R = Integer 2 Real)

That way, you'd have 10/12.5/15% chance, but when the R2I conversion is done, it'll end up as 10/12/15, which is what you have there

There's no need to null globals

And the leaks, they must be sorted

"please give me credit if you use these in your map!"

Yes you are.

Sounds more like he is just requesting credits (nothing very demanding about the way he said it IMO)

 

[D.V.D]

Ok, I will make the spells better. its just a start. Im going to keep improving. Also, I can't attach another file by editing the post. it doesn't let me. Suggestions on what to do will help. And like I said before, I'm going to make the abilities better once the weekend comes because of school.

 

[waaaks!]

theres a order ability for item illusion ability (852274)

 

[Flare]

Also, I can't attach another file by editing the post.

When you edit the post, click the Advanced button, and you should be able to manage attachments then

 

[D.V.D]

Did any of you reduce my rep by like 15? I had +25 and now +10.

 

[Sevion]

Does rep really matter that much? If it does to you, all you have to do is be helpful and follow the rules and rep will come with time.

 

[The Helper]

Did any of you reduce my rep by like 15? I had +25 and now +10.

You can see your reps in your User CP.

 

[Renendaru]

I used to have really low rep, even at 1k posts. But after helping I'm up to 203. All you have to do is help.

 

[D.V.D]

I do and it pisses me off when romek minuses my rep for replying to coments on my post 3 times and he thinks there bumps.

 

[Renendaru]

All right, all right... We're getting off track here. Can we go back to the topic this thread was made for.

Your skills as far as functioning are fine, but provide leakless examples...

 

[D.V.D]

Ok, I'll use leak checker to check for leaks.

 

[BRUTAL]

try fixing up the tooltips
why do you think theres different tooltips for each level in object editor
dont put level 1-w.e level 2 w.e all the same tooltips.

 

[Charapanga]

Hey!

I like the spells and if you let me i will use them in my upcoming map, oh and A Missle art for the Passive explosion would be great! You get +rep my friend

Chara

 

[D.V.D]

Thanks for the rep. I don`t mind if you use the spells and Im going to make them better. The mirror image will cast the spells that the hero casts and the explosion will have a missle art and made bigger.