Does this leak?

[s3rius]

I've copied something from Blizzard's Bomber Command and modified it for my needs. Now I'd like to ask if there are any leaks remaining (since I have no experience in removing trigger leaks)

function Rocket_Impact takes nothing returns nothing
    local unit u= GetTriggerUnit()
    
    call DestroyTrigger( GetTriggeringTrigger() )
    
    //Do something
    //Do something more
    
    call RemoveUnit(u)
    call RemoveUnit(GetEventDamageSource())
    set u = null
endfunction

function Fire_Rocket takes nothing returns nothing
    local unit c = GetTriggerUnit()
    local unit u
    local unit targ
    local location targloc = GetSpellTargetLoc()
    local trigger trg
    
    set u=CreateUnitAtLoc(GetOwningPlayer(c),'n009', GetUnitLoc(c),GetUnitFacing(c))
    set targ = CreateUnitAtLoc(GetOwningPlayer(c), 'n00B', targloc, 270)
    
    //Do some other shit
  
    set trg = CreateTrigger()
    call TriggerRegisterUnitEvent( trg, targ, EVENT_UNIT_DAMAGED )
    call TriggerAddAction( trg, function Rocket_Impact )

    call IssueTargetOrder( u, "thunderbolt", targ )
    
    set c = null
    set targ = null
    set u=null
    call RemoveLocation(targloc)
    set targloc = null
    set trg = null
endfunction

Thanks for any help.

 

[quraji]

Looks good.

 

[trb92]

    set u=CreateUnitAtLoc(GetOwningPlayer(c),'n009', GetUnitLoc(c),GetUnitFacing(c))

This line leaks. You need to store GetUnitLoc(c) in a variable and remove that location.

 

[Larcenist]

    call TriggerAddAction( trg, function Rocket_Impact )

That also leaks a trigger action.



Offtopic:

    set targ = CreateUnitAtLoc(GetOwningPlayer(c), 'n00B', targloc, 270)

Lol at the rawcode of that unit.

 

[quraji]

    set u=CreateUnitAtLoc(GetOwningPlayer(c),'n009', GetUnitLoc(c),GetUnitFacing(c))

This line leaks. You need to store GetUnitLoc(c) in a variable and remove that location.

Woops, not sure how I missed that one.

 

[s3rius]

Thanks, I thought it might leak that trigger action. I guess I managed to clean it up. And I overlooked that GetUnitLoc :x +rep

 

[AceLegend90]

I don't se any more leaks after you fix the trigger action, but you could optimize.

Using X and Y coordinates instead of a location would optimize the code better since you don't need to remove or null reals.