GroupPickRandomUnit isn't so random.

Azlier

Old World Ghost
Reaction score
461
Set every unit in the group into a unit array and use Random Integer to get one?
 

cleeezzz

The Undead Ranger.
Reaction score
268
i was hoping it would be easier, i mean, thats what a groupickRANDOMunit is for =/, whats the point of that function if its not even random -.- (between games)
 

Prometheus

Everything is mutable; nothing is sacred
Reaction score
589
Create your own and submit it as a snippit.
 
Reaction score
333
GroupPickRandomUnit uses GetRandomInt. Test it out in a game rather than through test map, and see if it is any different.
 

cleeezzz

The Undead Ranger.
Reaction score
268
my bad, didn't copy full trigger,

JASS:
set g = NewGroup()
            call GroupEnumUnitsInRect( g, bj_mapInitialPlayableArea, Condition(function PrivateFilter))
            set c = CountUnitsInGroup(g)
            loop
                exitwhen i == c + 1
                set RandomHero<i> = FirstOfGroup(g)
                call BJDebugMsg(I2S(i))
                call BJDebugMsg(GetUnitName(RandomHero<i>))
                call GroupRemoveUnit(g,RandomHero<i>)
                set i = i + 1
            endloop
            call ReleaseGroup(g)
            set r = GetRandomInt(1,c)
            call BJDebugMsg(I2S(r))
            set Hero[GetPlayerId(p)] = RandomHero[r]</i></i></i>

r always returns 5 for some reason (at least 4 in a row)
if it IS random, imma go buy a lotto ticket. -.-
 

Builder Bob

Live free or don't
Reaction score
249
4/5 is unlikely, but it is not a proper test.

Here's a test map for the function GroupPickRandomUnit(). What are your results? Is the function really not random on your computer? It gives the expected randomization when I test it.
 

cleeezzz

The Undead Ranger.
Reaction score
268
its random, but i dont know why, it doesn't seem to be random in my map.

i get 5 every time
 

Builder Bob

Live free or don't
Reaction score
249
That's just weird... From the code you posted I'd expect your debugging to show a random number of all the numbers being run through the loop.
 

cleeezzz

The Undead Ranger.
Reaction score
268
well, its random AFTER the first run, but first run always returns 5 lol
 

Gwypaas

hook DoNothing MakeGUIUsersCrash
Reaction score
50
Maybe it uses an internal value that changes after every use if "GetRandomInt" so, the first is always the same but after that then it uses ingame parameters to calculate it.

Just a thought.
 

emjlr3

Change can be a good thing
Reaction score
395
if your using test map - its always going to be the same during the first test - load the game individually from TFT and try again
 

AceHart

Your Friendly Neighborhood Admin
Reaction score
1,495
> If you're using "test map" - it's always going to be the same during the first test

And this from our very own Hulk3...
There's the "use fixed seed" option in "preferences", just for that.

And, with the exception of cleeeeeeeez' map, that option works just fine.
 
Reaction score
456
> There's the "use fixed seed" option in "preferences", just for that.
Should it be checked or not :eek:? I have it checked, and it does not seem to affect to GetRandomInt.
 

AceHart

Your Friendly Neighborhood Admin
Reaction score
1,495
> And, with the exception of cleeeeeeeez' map, that option works just fine.

Correction:
And, with the exception of cleeeeeeeez' map and uber's map, that option works just fine.


Unchecked.
 

cleeezzz

The Undead Ranger.
Reaction score
268
lol...

http://www.thehelper.net/forums/showthread.php?t=113055

please download this map and then as player one, type -ffa, then type -save, and then copy the code into the chat box. ex: -load HIH-IHI

then wait until the building finishes, do not select a hero or else it will not random. when it finishes building and you get a hero other than Illusionist, please tell me.
 
General chit-chat
Help Users
  • No one is chatting at the moment.

      The Helper Discord

      Members online

      No members online now.

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top