How else to code unit with buff takes damage

[shiFt]

Does this not fire everytime a unit takes damage? Is there not a more efficient way or is this fine?

 

[Crazy_Dead]

call Damage_Event_Register(t)
call TriggerAddAction(t , Condition( yourunitWithBuffCOnditionActions ))

This?

 

[shiFt]

no thats not the problem I was trying to figure out if there was a more efficient way of detecting it, rather than a unit takes damage event, as it checks evrytime a unit takes damage... right?

 

[the Immortal]

No, as even if there was (for example on spell cast add 'unit takes damage' for the target) you can't remove events from triggers. Which would mean you need to manually destroy/create them. Which is what Damage does anyways, so it actually becomes slower.

Also 'any unit takes damage' with [lJASS]GetUnitAbilityLevel()[/lJASS] doesn't create any performance issues so it's pretty safe to use...

 

[shiFt]

thanks for clearing that up for me

 

[Jesus4Lyf]

One thing. If you use BuffStruct for your buff, it comes with this for free:

method onDamageReceived takes nothing returns nothing
    // do things like: call Damage_Pure(this.unit, GetEventDamageSource(), GetEventDamage()) // <-- would reflect all damage.
endmethod

This is more efficient as it hashes based on the unit instead of firing all possibilities and checking. It's also faster to code. Either approach is fine (especially if you didn't use BuffStruct for the buff, this is more on the off chance that you did).

 

[shiFt]

now to learn buffstruct

Do buffs with buffstruct stack?

 

[Jesus4Lyf]

Do buffs with buffstruct stack?

Do you want them to?
Try it out yourself, man.
They stack, but currently the icon may be removed early if you do stack it. (BuffStruct is still technically in BETA, lol.)

 

[shiFt]

Im thinking about implementing it later though, thanks