Set Value to a Global

[Weirdoze]

So, I just started learning JASS today so I have some (probably) very noobish questions

First is, how do i set a new value for a global variable?

And second what is wrong with this

function Trig_Untitled_Trigger_002_Actions takes nothing returns nothing
if udg_global_HA == 0 then call CustomDefeatBJ( Player(0), "TRIGSTR_005" )
if udg_global_OA == 0 then call CustomDefeatBJ( Player(1), "TRIGSTR_005" )
endfunction

//===========================================================================
function InitTrig_Untitled_Trigger_002 takes nothing returns nothing
    set gg_trg_Untitled_Trigger_002 = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Untitled_Trigger_002, EVENT_PLAYER_UNIT_DEATH )
    call TriggerAddAction( gg_trg_Untitled_Trigger_002, function Trig_Untitled_Trigger_002_Actions )
endfunction

errors in:
if udg_global_HA == 0 then call CustomDefeatBJ( Player(0), "TRIGSTR_005" )
if udg_global_OA == 0 then call CustomDefeatBJ( Player(1), "TRIGSTR_005" )

HA and OA are integers with no array.

Please don't be mad if i ask very noobish questions

 

[wellwish3r]

globals are declared

globals
    integer i
    unit u
    ....
endglobals

setting a variable is simply:

set varname = stuff

if the variable is a GUI global dont forget the udg_ prefix

you are missing the endif in you if statements:

if stuff then
   actions
endif

or

if stuff then
    actions
else
    actions
endif

 

[Weirdoze]

i added the

endif

but it still says

"Expected a name"

and when i tried to set those globals it says

Expected a code statement

what am i doing wrong??

 

[wellwish3r]

jus wondering, do you have JassNewGen and JassHelper enabled?^^

 

[Weirdoze]

i have NewGen... but it ain't helping a bit when it just tells me the error name, not how to fix it...

 

[Faust]

2 ifs need 2 endifs

 

[Weirdoze]

i'm not that dumb.. i added endif to the end of both lines but it just tells me "Expected a name"

 

[wellwish3r]

i'm not that dumb.. i added endif to the end of both lines but it just tells me "Expected a name"

can you just post what you have now?

EDIT: Hmm wait what are your variables called? global_HA and global_AO ? or just HA and HO? cause the only prefix that globals have is udg_ not global_

 

[Weirdoze]

function Trig_Untitled_Trigger_002_Actions takes nothing returns nothing
if udg_global_HA == 0 then call CustomDefeatBJ( Player(0), "TRIGSTR_005" ) endif
if udg_global_OA == 0 then call CustomDefeatBJ( Player(1), "TRIGSTR_005" ) endif
endfunction

//===========================================================================
function InitTrig_Untitled_Trigger_002 takes nothing returns nothing
    set gg_trg_Untitled_Trigger_002 = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Untitled_Trigger_002, EVENT_PLAYER_UNIT_DEATH )
    call TriggerAddAction( gg_trg_Untitled_Trigger_002, function Trig_Untitled_Trigger_002_Actions )
endfunction

and 2nd trigger

function Trig_Orc_Spawn_Conditions takes nothing returns boolean
    if ( not ( GetPlayerSlotState(Player(1)) == PLAYER_SLOT_STATE_PLAYING ) ) then
        return false
    endif
    return true
endfunction

function Trig_Orc_Spawn_Actions takes nothing returns nothing
    call CreateNUnitsAtLoc( 1, 'ogre', Player(1), GetRectCenter(gg_rct_Orc_spawn), bj_UNIT_FACING )
    
    globals
    integer udg_global_OA = 1
    endglobals

endfunction

//===========================================================================
function InitTrig_Orc_Spawn takes nothing returns nothing
    set gg_trg_Orc_Spawn = CreateTrigger(  )
    call TriggerAddCondition( gg_trg_Orc_Spawn, Condition( function Trig_Orc_Spawn_Conditions ) )
    call TriggerAddAction( gg_trg_Orc_Spawn, function Trig_Orc_Spawn_Actions )
endfunction

u want all the names of the errors?

 

[wellwish3r]

globals are not declared inside functions, they are declared outside (they can however be declared inside libraries and scopes), and i dont see you declaring udg_global_HA anywhere.

 

[Weirdoze]

i read like 3 tutorials of starting JASS and don't remember seen words "libraries / scopes" anytime...

Okay now i got everything else working but this:

function Trig_Untitled_Trigger_002_Actions takes nothing returns nothing
if udg_global_HA != 1 then call CustomDefeatBJ( Player(0), "TRIGSTR_005" ) 
endif
if udg_global_OA != 1 then call CustomDefeatBJ( Player(1), "TRIGSTR_005" ) 
endif
endfunction

//===========================================================================
function InitTrig_Untitled_Trigger_002 takes nothing returns nothing
    set gg_trg_Untitled_Trigger_002 = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Untitled_Trigger_002, EVENT_PLAYER_UNIT_DEATH )
    call TriggerAddAction( gg_trg_Untitled_Trigger_002, function Trig_Untitled_Trigger_002_Actions )
endfunction

^Firstly I'm trying to check if udg_global_HA / OA is not equal to 1
ERROR ---> "Comparing two variables of different primitives is not allowed!
^And then there is endif
ERROR ---> "Missing linebreak before endif"
^And some other errors
ERROR ---> "Missing endfunction"
ERROR ---> "Syntax error"
ERROR ---> "Statement outside function"

 

[wellwish3r]

i read like 3 tutorials of starting JASS and don't remember seen words "libraries / scopes" anytime...

thats why they are about starting jass :thup:

anyways, this compiles fine for me:

globals
    integer udg_global_HA = 1
    integer udg_global_OA = 1
endglobals


function Trig_Untitled_Trigger_002_Actions takes nothing returns nothing
    if udg_global_HA != 1 then
        call CustomDefeatBJ( Player(0), "Apples" ) 
    endif
    if udg_global_OA != 1 then
        call CustomDefeatBJ( Player(1), "Bananas" ) 
    endif
endfunction

//===========================================================================
function InitTrig_Untitled_Trigger_002 takes nothing returns nothing
    set gg_trg_Untitled_Trigger_002 = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Untitled_Trigger_002, EVENT_PLAYER_UNIT_DEATH )
    call TriggerAddAction( gg_trg_Untitled_Trigger_002, function Trig_Untitled_Trigger_002_Actions )
endfunction

im not sure about jass, but since you have no action end identifier, it might be that the script need line breaks at certain points. It does not matter where you declared the globals, i just did that in there because i needed the variables.

Just try adding the line breaks the same way i did.

 

[Komaqtion]

Just wondering, are the variables HA and OA GUI globals ??? In that case it's just supposed to be only udg_HA and udg_OA, just remove the global_ and it should work

 

[wellwish3r]

Just wondering, are the variables HA and OA GUI globals ??? In that case it's just supposed to be only udg_HA and udg_OA, just remove the global_ and it should work

read his posts, he declared them as jass globals... and i asked that allready.

 

[Komaqtion]

Oh, sorry

 

[SerraAvenger]

globals are not declared inside functions, they are declared outside (they can however be declared inside libraries and scopes), and i dont see you declaring udg_global_HA anywhere.

Nah. You actually can declare globals within functions... It's just bad practise.

if udg_global_HA != 1 then call CustomDefeatBJ( Player(0), "TRIGSTR_005" ) 
endif
if udg_global_OA != 1 then call CustomDefeatBJ( Player(1), "TRIGSTR_005" ) 
endif

As wellwisher pointed out, you cannot declare if then else blocks in a single line.

if udg_global_OA != 1 then
    call CustomDefeatBJ( Player(1), "TRIGSTR_005" ) 
endif

Also, please indent your code properly and name your functions somewhat useful.

 

[kingkingyyk3]

Before posting, please see some example first. Only post it when you can't find any solution.