Why doesnt this trigger work?

[Quauhtli]

How come this doesn't work?

ColorChange P2
    Events
        Map initialization
    Conditions
    Actions
        Unit Group - Pick every unit in (Units in (Playable map area)) and do (Actions)
            Loop - Actions
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        (Owner of (Triggering unit)) Equal to Player 2 (Blue)
                    Then - Actions
                        Unit - Change color of (Triggering unit) to Brown
                    Else - Actions
                        Do nothing

I have this trigger for every player...
but it only works for player 1 (well, actually i dont know, since red is already red, and changing red to red wel...)

 

[Potatisbil]

I think you should use picked unit instead of triggering unit. Never knew that "Map initialization" was counted as a triggering unit XD

~Potatisbil

 

[R@d14nc3]

Leaks.
Add:
Custom script: set bj_wantDestroyGroup = true

Won't leak after that.

 

[Quauhtli]

Leaks.
Add:
Custom script: set bj_wantDestroyGroup = true

Won't leak after that.

and where would I add that?
after the else action?

 

[R@d14nc3]

The 1st action would be that

 

[Quauhtli]

nope.
still aint work

 

[R@d14nc3]

The 1st action would be that

Oops.
I meant 1st Loop action

 

[Quauhtli]

it looks like this now:

ColorChange P2
    Events
        Map initialization
    Conditions
    Actions
        Unit Group - Pick every unit in (Units in (Playable map area)) and do (Actions)
            Loop - Actions
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        (Owner of (Picked unit)) Equal to Player 2 (Blue)
                    Then - Actions
                        Unit - Change color of (Triggering unit) to Brown
                        Custom script:   set bj_wantDestroyGroup = true
                    Else - Actions
                        Do nothing

still nothing works

 

[R@d14nc3]

ColorChange P2
    Events
        Map initialization
    Conditions
    Actions
        Unit Group - Pick every unit in (Units in (Playable map area)) and do (Actions)
            Loop - Actions
                [B]Custom script:   set bj_wantDestroyGroup = true[/B]
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        (Owner of (Picked unit)) Equal to Player 2 (Blue)
                    Then - Actions
                        Unit - Change color of ([B]Picked unit[/B]) to Brown
                                            Else - Actions
                        Do nothing

fixed

 

[AceHart]

The custom script line needs to come before the loop, not somewhere inside.

And, if you pick every unit in "units owned by player" you don't need the test anymore.


"Do nothing" is not needed. It isn't doing anything anyway.

 

[Quauhtli]

thx

it worked
but:
on the minimap they still give player color

how to change?

 

[Chocobo]

Object Editor -> Units -> Shows as Neutral (maybe?)