Custom Map Script vs. BJ

[Nevyll]

Which is faster, writing a function in the custom map script section of a map and calling it from a trigger, or simply calling a BJ?

Example:

function GetAngleBetweenPoints takes real x1, real x2, real y1, real y2 returns real
    return bj_RADTODEG * Atan2( y2 - y1, x2 - x1 )
endfunction

As opposed to

    set SomeReal = AngleBetweenPoints( locA, locB )

 

[Chaos_Knight]

Which is faster, writing a function in the custom map script section of a map and calling it from a trigger, or simply calling a BJ?

Example:

function GetAngleBetweenPoints takes real x1, real x2, real y1, real y2 returns real
    return bj_RADTODEG * Atan2( y2 - y1, x2 - x1 )
endfunction

As opposed to

    set SomeReal = AngleBetweenPoints( locA, locB )

1st: Better
2nd: Faster(I think)

 

[Komaqtion]

No, first is faster, as you use reals directly...

And, it's simply better to use anyways

 

[Nevyll]

...but the fastest would simply be not writing any functions at all, but just using the Atan2() native directly in the trigger?

 

[Viikuna]

Something like:

local real x1
local real y1
local real x2
local real y2

local real dx=x2-x1
local real dy=y2-y1

local real angle=Atan2(dy,dx)
local real distance=SquareRoot(dx*dx+dy*dy)

 

[Sevion]

The speed difference versus readability isn't exactly worth it... Using your user-defined function would be better IMHO.

local real angle = GetAngleBetweenPoints(x1, x2, y1 ,y2)

If you're just comparing distances, then you don't have to even use the square root

local real d1 = dx1*dx1+dy1*dy1
local real d2 = dx2*dx2+dy2+dy2
if ( d1 > d2 ) then
else
endif

 

[Narks]

doesn't that inline anyway?

 

[Sevion]

Possibly. Actually, I believe it does... Each argument is only used once and there's only one line.