Local Players, Null?

[MrApples]

Tower Respawn Copy
    Events
    Conditions
    Actions
        Set TempPlayer = Player 1 (Red)
        Custom script:   if GetLocalPlayer() == udg_TempPlayer then 
        Custom script:   call PlaySoundBJ( gg_snd_ClanInvitation )
        Custom script:   endif

Since there is no Play Sound for Player action I had to do this, should I null the variable and what would I do to null it exactly if so?

Also if theres anything wrong with it that could cause lag that I should fix please tell me cause this could run often?

 

[Jazradel]

No there is no need to null players. Your trigger how ever will cause a desync. I don't know off hand how to stop this but I know there is a solution at www.wc3sear.ch or www.wc3jass.com.

 

[MrApples]

How do you know it will?

 

[Jazradel]

It plays a sound for one player and this desyncs him/her somehow. I'm not actually sure it does as I tend to stay on the safe side and listen to people who have experiance in these matters.

 

[xPheRe]

Try using call StartSound( gg_snd_ClanInvitation ) instead of PlaySoundBJ
I think StartSound uses no net traffic... not sure.
But PlaySoundBJ sure it uses traffic and it will cause desyncs.

Also, you don't need to nullify globals. But you must nullify local variables.
Most common types that need to be nullified are:
player, unit, destructable, force, group, trigger, timer, location, rect, sound, effect, gamecache...

 

[phyrex1an]

The trigger itself will not desync however if you use it togheter with
'last played sound' it may do that. Especialy if you destroy last played sound.

It is safer to use StartSound() insteed of PlaySoundBJ(). The only difference is that PlaySoundBJ sets a varaible, and after that the varaible will be different for each player.

 

[MrApples]

Alright, ill change it to StartSound.

Also, you don't need to nullify globals. But you must nullify local variables.

Well since im using it in local I assumed it would be like the same thing.

 

[phyrex1an]

GetLocalPlayer has nothing to do with local/global variables.

Only when you declare a handle type varaible local you may have to null it.