Spell Mana Bomb

[Flare]

purgeandfire says that 'not' is faster than '!='

 

[PurgeandFire]

Yes, I've heard that somewhere at wc3campaigns.

Anyway, just do this:

    call SetTextTagVisibility (a.manabar, false)      
    if GetLocalPlayer () == GetOwningPlayer (a.caster) then
        call SetTextTagVisibility (a.manabar, true)
    endif

EDIT: Nvm. Not is only faster in certain cases. At least according to SFilip, I trust him.

 

[Flare]

Ah, thanks for that. Uploaded v5.

Is this the mana bomb I think it is btw?

Why, what are you thinking of? Oh, you talking about the spell suggestion S1lent gave for the Arcanist hero that you/Knight7770 suggested? If so, yes it is

UPDATE: Re-uploaded the screenshots, that free image hosting place sucked

EDIT: Also, should I make the onDestroy method a private member?

 

[GoGo-Boy]

Just put the whole struct private.

 

[Flare]

Updated to v6. See first post for details on update.

 

[Gwypaas]

I'm pretty sure that onDestroy needs to be private so it doesn't collide with another struct.

 

[Flare]

wouldnt a private struct cater for that?

 

[GoGo-Boy]

Yes.

 

[Gwypaas]

Yes but you can make the onDestroy method private anyways since when you call <your struct>.destroy() it automaticly calls if and doesn't care if it's private, public or a normal method.

 

[Flare]

UPDATE
*Made the onDestroy method private
*Used a special effect rather than dummy unit for end explosion (dummy unit was causing the effect to appear twice)
*Fixed an issues with mana bar (it was extending itself slightly)

 

[Trollvottel]

btw,onDestroy wont collide with methods from other structs
the functions will be named like

Structname_methodname

so nothings collides.

 

[Flare]

well, latest ver made the method private... there shouldnt be any problem with private method within private struct?

 

[Flare]

~bump~

Any suggestions, leaks or bugs that need fixing?

 

[cr4xzZz]

You don't need to make the onDestroy method private. The struct is already private, so it can't get more private than that

 

[Flare]

That was done before trollvottel came along to clarify, so you can blame Gwypaas ^^

 

[Gwypaas]

You can always be on the safe side and the private doesn't slow down the code at all anyways. It just needs to be that way when you make non private structs so I think you should use it everywhere for better looking code.

 

[Flare]

~bump~
Still waiting for a mod to take a look-see

 

[hasslarn]

nice spell it workes good for me , deservs a +rep!

 

[Flare]

~bump~

Any more comments/suggestions?

 

[131ackout]

NICE mana bomb, but why don't you call it Life Bomb? The mana bomb don`t drain the mana..