quest help

[feistaghelm]

THIS THREAD IS DEAD
Somehow I posted a question about the same code further in the forum. The new thread has a working code. Thank you: Bankde and TomTTT Find the fixed code in this post: http://www.thehelper.net/forums/showthread.php?t=158001

I made a kill quest following the code given by dragonhord but I have no idea if any of the kills are counting. I killed all the required creeps but nothing happens. Is there a way to make the quest show progress and show the kills add up? This is my quest:

• Emily
  • Events
    • Unit - A unit comes within 100.00 of Emily (Female) 0107 <gen>
  • Conditions
    • (This trigger) Equal to Emily <gen>
  • Actions
    • Quest - Display to (All players) the Quest Update message: Hold Hero! Dangers...
    • Quest - Create a Required quest titled Testing Might with the description Kill all the monste..., using icon path ReplaceableTextures\CommandButtons\BTNAmbush.blp
    • Set Quests[2] = (Last created quest)
    • Trigger - Turn off (This trigger)

Then:

• Testing Might
  • Events
    • Unit - A unit Dies
  • Conditions
    • (Unit-type of (Dying unit)) Equal to Skeleton Archer
    • (Unit-type of (Dying unit)) Equal to Satyr
    • (Unit-type of (Triggering unit)) Equal to Satyr Trickster
    • (Unit-type of (Dying unit)) Equal to Lesser Voidwalker
    • (Unit-type of (Dying unit)) Equal to Felguard
  • Actions
    • Set SkeletonArcherKills = (SkeletonArcherKills + 1)
    • Set SatyrKills = (SatyrKills + 1)
    • Set SatyrTricksterKills = (SatyrTricksterKills + 1)
    • Set LesserVoidwalkerKills = (LesserVoidwalkerKills + 1)
    • Set FelguardKills = (FelguardKills + 1)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • SkeletonArcherKills Equal to 2
        • SatyrKills Equal to 2
        • SatyrTricksterKills Equal to 1
        • LesserVoidwalkerKills Equal to 2
        • FelguardKills Equal to 2
      • Then - Actions
        • Quest - Mark Quests[2] as Completed
        • Quest - Display to (All players) the Quest Update message: Looks like you hand...
        • Player - Add 250 to Player 1 (Red) Current gold
        • Unit Group - Pick every unit in (Units in (Playable map area) matching (((Picked unit) is A Hero) Equal to True)) and do (Actions)
          • Loop - Actions
            • Hero - Add 150 experience to (Picked unit), Show level-up graphics
      • Else - Actions

Any help will be greatly appreciated.

So... I used your code edit and even made the event more specific like in a different post you helped with. The code still doesn't work sadly but I'll post it so you can see what I need to change.

• Testing Might
  • Events
    • Unit - A unit owned by Neutral Hostile Dies
  • Conditions
    • Or - Any (Conditions) are true
      • Conditions
        • (Unit-type of (Triggering unit)) Equal to Skeleton Archer
        • (Unit-type of (Triggering unit)) Equal to Satyr
        • (Unit-type of (Triggering unit)) Equal to Satyr Trickster
        • (Unit-type of (Triggering unit)) Equal to Lesser Voidwalker
        • (Unit-type of (Triggering unit)) Equal to Felguard
  • Actions
    • Set SkeletonArcherKills = (SkeletonArcherKills + 1)
    • Set SatyrKills = (SatyrKills + 1)
    • Set SatyrTricksterKills = (SatyrTricksterKills + 1)
    • Set LesserVoidwalkerKills = (LesserVoidwalkerKills + 1)
    • Set FelguardKills = (FelguardKills + 1)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • SkeletonArcherKills Equal to 2
        • SatyrKills Equal to 2
        • SatyrTricksterKills Equal to 1
        • LesserVoidwalkerKills Equal to 2
        • FelguardKills Equal to 2
      • Then - Actions
        • Quest - Mark Quests[2] as Completed
        • Quest - Display to (All players) the Quest Update message: Looks like you hand...
        • Player - Add 250 to Player 1 (Red) Current gold
        • Unit Group - Pick every unit in (Units in (Playable map area) matching (((Picked unit) is A Hero) Equal to True)) and do (Actions)
          • Loop - Actions
            • Hero - Add 150 experience to (Picked unit), Show level-up graphics
      • Else - Actions

The original quest trigger is the same.

 

[Bankde]

• Testing Might
  • Events
  • Conditions
    • (Unit-type of (Dying unit)) Equal to Skeleton Archer
    • (Unit-type of (Dying unit)) Equal to Satyr
    • (Unit-type of (Triggering unit)) Equal to Satyr Trickster
    • (Unit-type of (Dying unit)) Equal to Lesser Voidwalker
    • (Unit-type of (Dying unit)) Equal to Felguard
  • Actions

Generally all condition must be "True" in order to process the Actions. In your trigger, it is impossible that ONE unit can be Skeleton Archer, Satyr, Satyr Trickster, Void, and Felguard at the same time.

Make sure you add "OR" to your trigger like this:

• Correct one
  • Events
  • Conditions
    • Or - Any (Conditions) are true
      • Conditions
        • (Unit-type of (Triggering unit)) Equal to Footman
        • (Unit-type of (Triggering unit)) Equal to Rifleman
        • (Unit-type of (Triggering unit)) Equal to Knight
  • Actions

Also use "Triggering Unit" is better than "Dying Unit".

 

[TomTTT]

Nothing else to say beside what the person above me did :thup:
Dying is usually meant for when you use killing event and you want to refer the unit that dies.