will this trigger work

[Denegoth]

im making some more heroes for my hero arena v2.1 and i need to know if this trigger works. its supposed to select a random player controlled hero and kill it

Roulette
Events
Unit - A unit Begins casting an ability
Conditions
(Ability being cast) Equal to Roulette
Actions
Unit Group - Pick every unit in (Units owned by (Random player from (All players controlled by a User player))) and do (Actions)
Loop - Actions
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
((Picked unit) is A Hero) Equal to True
Then - Actions
Unit - Kill (Picked unit)
Else - Actions
Do nothing

 

[2-P]

<3 I love these threads. Why oh why don't you just try it?

Anyway, it will kill all heroes controlled by a random player.

 

[C-Death]

I think it will work, alotho im no trigger expert.

 

[R@d14nc3]

Whenever you use unit groups, be sure to add Setbj_WantDestroyGroup=True to avoid unit group leaks.

 

[Potatisbil]

yep, it should work.

and to avoid mem leaks you can add the thing R@d mentioned to the loop :

Custom script : set bj_wantDestroyGroup = true

 

[AceHart]

> to the loop

Not "to", before the loop.

 

[Potatisbil]

ok . im still very new to JASS so i dont know so much about it