System Damage Struct

Dirac

22710180
Reaction score
147
Why you should use this above Damage? Ok a few reasons.
-Instead of coding a bunch of checks in order to know whether you would like to register and change some unit's damage (because of a damage modification ability or something similar) You can just enable the damage recognition for the unit using this system, then disable it after using timers (If approved i'll fix the issue that doesn't let you disable it during damage event firing)
-The event responses variables are now globals and you no longer need to declare them each function as a local. (Damage.dealt, Damage.source, etc.)
-Damage by J4L bugs when trying to prevent AoE damage. (Or any kind of damage done simultaneously
-You don't have to declare triggers in order for the system to function (i really hate this about J4L's damage)
-This (similar to Nestharus's damage library) cleans up the leaks generated by events after a certain amount of units are removed or deindexed. Otherwise unused events would stack and stack over the trigger.
-Gives you the extremely useful DamageMod extension if needed.
-Allows you to retrieve unit armor and unit armor reduction
-Gives you the useful custom DamageType extension if needed.
-Keeps recount of all damage given by all sources or by specific sources (should be an extension)
-Allows you to perfectly attach data to unit damage events, this way you can easily access your ability's instance through damage detection

Fixed the documentation.
 

GFreak45

I didnt slap you, i high 5'd your face.
Reaction score
130
This resource needs to be modular.
GetUnitArmor can be it's own resource.

i think he means that armor is the only module that you have implemented in the core, and that you should have that as optional as well, idk i might disagree with him but just depends on the situation
 

Dirac

22710180
Reaction score
147
Yea the GetUnitArmor function only adds a few lines of text to the system, it would harm to take it away. And i can't submit it for people who don't want to use this damage system because it has to disable the current damage system their map has, and use the custom ability life bonus their map has, if they want a function like that they might as well code it themselves.

@Mag
You do realize that the UnitIndexStruct module does the same thing i'm doing here? It registers functions to the INDEX and DEINDEX events of the trigger, no need to implement it, plus it would make compability with AIDS much harder.

@tooltiperror
I know what you mean when you say i'm reinventing the wheel, why should you approve this resource? So happens that you run on a bad wheel, J4L's damage system isn't completely safe to use, has lots of unnecessary coding, lacks of tools this system (even without the extensions) has, bugs with damage prevention when damage is done simultaneously, LEAKS events on triggers, and it's considerably slower. I'm inclined to think that it was approved because there was no other resource that would do the same thing. After that Nes came out with his DamageEvent library, which was J4L's with all the bug fixed but lacking of tools. I find this the ultimate Damage library with everything the user needs, and if it needs even more there are extensions to it.
I haven't been able to come with a new update because honestly i find nothing to fix / tweak. However i'm extremely open on developing new extensions for it.
 

Switch33

New Member
Reaction score
12
You could make a damage over time module- for when an damage type like poison or fire does damage over time.

Also if your gonna keep the armor system in then at least do the fix for ethereal units(that i talk'd about with GFreak45 a few posts back). It'd make more sense if it work'd for even ethereal units since I can't think of any reason anyone would need to re-code that part then.
 

Magthridon96

Member
Reaction score
2
You do realize that the UnitIndexStruct module does the same thing i'm doing here? It registers functions to the INDEX and DEINDEX events of the trigger, no need to implement it, plus it would make compability with AIDS much harder.

I know, but implementing the UnitIndexStruct would make your code look shorter.

Modularity is very important. By combining your GetUnitArmor function with something totally unrelated (Damage detection), you've made this resource un-modular.
Who would expect to find a GetUnitArmor function in a damage detection library?
It's like adding timer recycling inside a Spell struct.

All you have to do is make another library called GetUnitArmor and place your function there :3
 

Dirac

22710180
Reaction score
147
Ok i'll try to fix the modularity regarding the armor part, but the new "Armor" library would require this library.
ethereal may not be attainable with chaos, but it only takes one damage type and that damage type isnt reduced by armor, so how do you get the armor of a unit without the armor having any effect at all?
Not entirely true, i've been testing ethereal damage done to units and armor DOES affect their spell damage taken (though they only take spell damage, any other type of damage is prevented) and i came up with a solution to fix it, now there's an accurate way to detect ethereal armor without having to specify the unit's amor is ethereal.

EDIT:
v2.0.1
-Removed the GetUnitArmor and GetUnitDamageReduction as they now have their own resource "Armor"
 

Laiev

Hey Listen!!
Reaction score
188
Dirac, I suggest you round up the the returned value of [ljass]GetUnitArmor(u)[/ljass], because is what Warcraft do.

While I'm with 235 armor (value by Warcraft), your function return 234.906.

When I active your ability (+100 armor) we got 235 + 100 (value by Warcraft), while your function return 334.211 (my DisplayFunction is inside the AgilityShield, so we have 2 inaccuracy value here)

I did a little function to test if my theory is right, and, in fact, it is ^_^

JASS:
function RoundUp takes real r returns real
    return R2I(r + 0.5) + 0.
endfunction


This little stupid function fix the inaccuracy value of [ljass]GetUnitArmor[/ljass], but I don't know how it'll work on negative armor :/
 

Dirac

22710180
Reaction score
147
I can't round up armor, it would bug hero armor increased by bonus agility (which gives armor with decimal values).
The fact that the armor returned isn't completely accurate isn't really my fault, there's nothing i can do about it.
Negative armor has the same issue and the maximum negative armor the unit can have is -20 (if the unit has -40 it would increment damage taken as it had -20)
 

Laiev

Hey Listen!!
Reaction score
188
How this can bug the armor increased by bonus agility, since it's just rounded when you get the final value?

Like this:

JASS:
function RoundUp takes real r returns real
    return R2I(r + 0.5) + 0.
endfunction

function GetUnitArmor takes unit whichUnit returns real
    local real reduction=GetUnitDamageReduction(whichUnit,ATTACK_TYPE_CHAOS,DAMAGE_TYPE_NORMAL)
    
    //*********************************************************************
    //  (armor)*0.06/(1+armor*0.06) = reduction
    if 0==reduction then
       set reduction=GetUnitDamageReduction(whichUnit,ATTACK_TYPE_MAGIC,DAMAGE_TYPE_NORMAL)
       return RoundUp(((1-reduction)/(ARMOR_REDUCTION*(reduction)))/ETHEREAL_ARMOR_REDUCTION) //there's nothing interfering the math
    endif
    if reduction<=1 then
        return RoundUp((1-reduction)/(ARMOR_REDUCTION*(reduction))) //neither here
    endif
    
    //*********************************************************************
    //  Ln of 0.94, w3's magic number for negative armor.
    return -(Ln(2-reduction)/-0.061875)
endfunction


or you could do this

JASS:
function RoundUp takes real r returns real
    return R2I(r + 0.5) + 0.
endfunction

function GetUnitArmor takes unit whichUnit returns real
    local real reduction=GetUnitDamageReduction(whichUnit,ATTACK_TYPE_CHAOS,DAMAGE_TYPE_NORMAL)
    
    //*********************************************************************
    //  (armor)*0.06/(1+armor*0.06) = reduction
    if 0==reduction then
       set reduction=GetUnitDamageReduction(whichUnit,ATTACK_TYPE_MAGIC,DAMAGE_TYPE_NORMAL)
       return ((1-reduction)/(ARMOR_REDUCTION*(reduction)))/ETHEREAL_ARMOR_REDUCTION
    endif
    if reduction<=1 then
        return (1-reduction)/(ARMOR_REDUCTION*(reduction))
    endif
    
    //*********************************************************************
    //  Ln of 0.94, w3's magic number for negative armor.
    return -(Ln(2-reduction)/-0.061875)
endfunction
function GetUnitArmorEx takes unit whichUnit returns real
    return RoundUp(GetUnitArmor(whichUnit))
endfunction


PS: sorry for post this here instead of Armor thread... I first post that looking at the demomap :/ anyway...
 

Dirac

22710180
Reaction score
147
This belongs in the actual Armor resource thread but w/e.

If the unit has 5 armor it returns 5.3, if rounded up would return 6, when 5 was the armor
If the unit has 235 armor it returns 234.9 if rounded up would return 235

No way around it, the function just isn't accurate and there's no way to fix it.
 

Laiev

Hey Listen!!
Reaction score
188
>>If the unit has 5 armor it returns 5.3, if rounded up would return 6, when 5 was the armor

Wrong >.>

If unit has 5 armor, and if it returns 5.3, if rounded up, would return 5, because it's not rounded up 100%, it just rounded if armor .XX > 50

[ljass]return R2I(real + 0.5)[/ljass] R2I don't round things
 

GFreak45

I didnt slap you, i high 5'd your face.
Reaction score
130
pretty sure even if it isnt accurate, you could just convert it to a substring using that digit (just after the decimal) and call another function taking that number and returning a true or false where if its 5+ it returns true if not it returns false, and if its false chop off the digits after the decimal, otherwise, do that and add 1 to it
 

Dirac

22710180
Reaction score
147
pretty sure even if it isnt accurate, you could just convert it to a substring using that digit (just after the decimal) and call another function taking that number and returning a true or false where if its 5+ it returns true if not it returns false, and if its false chop off the digits after the decimal, otherwise, do that and add 1 to it
Why on earth would you do that, didn't you see Laiev's function?
That's by far the weirdest and more over complicated method you can use to round up a number.

Remember this:
[ljass]R2I[/ljass] takes away the decimal part of a number, if the number was 9.7 it would return 9
If the number is 9.7 and you add 0.5 to it it would look like this
[ljass]R2I(9.7+0.5) = 10[/ljass]
So because the number's decimal part was above 0.5 now it's rounded up to 10.
[ljass]R2I(9.2+0.5) = 9[/ljass]
Now the number was below 0.5 and returns 9
 

GFreak45

I didnt slap you, i high 5'd your face.
Reaction score
130
hmmm derp i didnt, i thought you were saying he was using a defualt rounding function rather than that
 

Dirac

22710180
Reaction score
147
Updated to 2.0.5
-Instead of Alloc it now uses LinkedListModule
-Removed the Overkill and Overheal constants and fixed issues related to them
-Changed the philosophy on how the "dealt" variable works (it takes into account prevented damage and can't go below 0)
-Added support for the DamageId extension
 

Sevion

The DIY Ninja
Reaction score
413
Confused as to how you find that 5.3 will round to 6.

JASS:
function RoundUp takes real r returns real
    return R2I(r + 0.5) + 0.
endfunction


[ljass]R2I(5.8)+0.[/ljass] will return 5.
 

Dirac

22710180
Reaction score
147
You're right, the reason i haven't updated it is because i was working on some updates and the version that works with LinkedList is ready, thus i was working on maybe adding Advent as a requirement
Anyways now it works with linked list module properly.
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
    +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
    +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
    +2
  • V-SNES V-SNES:
    Happy Friday!
    +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/
  • The Helper The Helper:
    I think we need to add something to the bottom of the front page that shows the Headline News forum that has a link to go to the News Forum Index so people can see there is more news. Do you guys see what I am saying, lets say you read all the articles on the front page and you get to the end and it just ends, no kind of link for MOAR!
  • The Helper The Helper:
    Happy Wednesday!
    +1

      The Helper Discord

      Members online

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top