Has anybody tried out 1.24?

[lovexylitol]

I'll have to try it out as soon as I get home.

Not sure if I read it right, but looks like H2I might not work any more.

Warcraft III v1.24 Patch Notes


PC WORLD EDITOR CHANGES

- Added new JASS hash table functions to replace the lost functionality from
fixing unsafe type casting.
- Hash Table - Save Item Handle
- Hash Table - Save Unit Handle
- ...
- Hash Table - Load Item Handle
- Hash Table - Load Unit Handle
- ...
- Hash Table - Get Handle ID

FIXES

- Fixed an exploit related to unsafe type casting that allowed users to
execute arbitrary code in maps.
- Fixed the JASS unsafe type casting exploit ("return bug").
- Fixed several World Editor crashes.

 

[Dirac]

All of my triggers where disabled and im unable to save my map... i think blizz screwed things up

 

[Komaqtion]

Wierd ... I can still save

 

[Dem0n_Hunter]

My map got screwed too. I can't save anymore and I get about 1000 complied errors

 

[phyrex1an]

Blizzard fixed the return bug. Any map that uses it will be unsaveble and unplayable.
The only fix is to stop using the return bug, eg remove all or update all systems that uses it and rewrite your own code to not use it.
For the special case of replacing H2I blizzard provided GetHandleId

 

[LurkerAspect]

Excuse my ignorance, but what is the return bug, and how can compensate for it to save my WIP before I get the patch?

 

[jwallstone]

Here's the return bug:
http://jass.sourceforge.net/doc/retbug.shtml

Basically, if you have any function in your map that has two return statements, you should change it to only call return at the very end of the function.

 

[woot]

ACK my map is full of those

that's crappy .. its so much easier to have multiple returns in a function


does this only cause the map to not compile properly in 1.24 .. or does it also not work at all when played in 1.24 (if compiled in an earlier version)

 

[BRUTAL]

i think it cant even be played

 

[Dem0n_Hunter]

Well I had a map saved in 1.23 but now I can't open it so I guess if you saved on older version u still can't open it in 1.24 that one of the reasons dota doesn't work anymore

 

[TriggerHappy]

Where have you guys been -_- ?

This news has been around for at least a month.

 

[Romek]

> This news has been around for at least a month.
The patch was made official today.

 

[Dem0n_Hunter]

Which news? that the return bug is fixed and we're all screwed. (at least me)
or the new patch is coming out

 

[Romek]

The patch has been beta for a very long time now.

You missed out on a lot. >.<

 

[TriggerHappy]

> This news has been around for at least a month.
The patch was made official today.

Yea I know but there have been posts all over the forums about it, or at least containing something about patch 1.24.

 

[Kazuga]

Didn't see that one coming... Hope my map isn't ruined, if it is I'm going killing spree on Blizzard. (Worked on it for over a year.)

 

[TriggerHappy]

Didn't see that one coming... Hope my map isn't ruined, if it is I'm going killing spree on Blizzard. (Worked on it for over a year.)

It's not that hard to fix :nuts:

Just remove H2I from your map and replace any H2I( calls with GetHandleId(

 

[lovexylitol]

Hmmm.

Even if the info was avaliable, well it could have been better if they posted on the battle.net welcome page. (Yes, yes I'm lazy I don't go to the support forums)

Just in case somebody finds this useful.

1.24 Checklist

1. Change H2I to GetHandleId.

2. If your map uses any custom Blizzard.k, common.j, *.ai etc, update em.

3. If your newgen isn't working suddenly (crash, error, overflow etc), download the 5d version, update your wc3, and run 'NewGen WE.exe'. (At least the combination worked for me)

4. Read this! http://www.wc3c.net/showthread.php?t=106305

5. Seems like there is a funky bug. Read http://www.wc3c.net/showpost.php?p=1096978&postcount=12 or the other 1.24 thread http://www.thehelper.net/forums/showthread.php?t=133555

 

[MasterOfRa]

Is there a way to determine where my bugs are? Ive already looks through all my triggers and changed usage of the H2I to GetHandleId, and it didnt help.

Is there a new jasshelper yet that tells you where you didn't follow these retarded new rules? they may be necessary to prevent people from using the byte code thingy, but i would really prefer risking that than not being able to host, or even test any of my custom maps, that i spent so much time on...

 

[TriggerHappy]

JassHelper isn't what tells you your errors, pJASS is. Anyways don't just replace your H2I calls, remove the H2I function completely from your map.