How to clean up this messy jass

[dannyboydude]

if ( Trig_Bank_Init_Func001Func001C() ) then

function Trig_Bank_Init_Func001Func001C takes nothing returns boolean
    if ( not ( ConvertedPlayer(GetForLoopIndexA()) == GetTriggerPlayer() ) ) then
        return false
    endif
    return true
endfunction

What does if ( not ( blah blah == GetTrigegringPlayer() ) ) mean and return false
endif
return true ?
What does that jumble mean ?

and how does it work with [ if ( trig () ) then do stuff ]

And how would i clean this up like making it easier to read and not get confussed ?

 

[darkbeer]

function Trig_Bank_Init_Func001Func001C takes nothing returns boolean
    return ConvertedPlayer(bj_forLoopAIndex) == GetTriggerPlayer() 
endfunction

should do the job

 

[dannyboydude]

What i was asking for aswell was what does this mean

if ( not ( ConvertedPlayer(GetForLoopIndexA()) == GetTriggerPlayer() ) ) then
        return false
    endif
    return true

if ( not ( blah blah == blah blah () ) ) then
return true
endif
return flase

If not then return true or false , doesnt make any sense to me ,
what does what ?

 

[Flare]

If that condition isn't true, it will return false (which will prevent execution of the actions), otherwise it will carry on until it reaches the return true statement, which will allow the actions to execute

 

[dannyboydude]

Well couldnt i just do this then to make it much simpler

function Trig_Bank_Init_Func001Func001C takes nothing returns boolean
    if ( ConvertedPlayer(GetForLoopIndexA()) == GetTriggerPlayer() ) then
        return true
    else return false
    endif
endfunction

 

[Sooda]

In post #2 is your answer, World Editor needs to return understandable answer every time, that is why it seemingly creates un-needed jass.

Also you can't invent out of blue new jass syntax:

    else return false

it just isn't right.

 

[Trollvottel]

the best would be:

if ConvertedPlayer(GetForLoopIndexA()) == GetTriggerPlayer() then

forget this extra function