problem with ability trigger

[Mullit]

I have made a spell called Whats that? what the spell does is makes all units aroung the caster look to the casting point and stay looking at it for 3 seconds. So it would seem as thought the caster had pointed something and shouted whats that?

Here is the trigger and it doesnt work.

    Events
        Unit - A unit Starts the effect of an ability
    Conditions
        (Ability being cast) Equal to Whats That? 
    Actions
        Set Whats_that_point = (Target point of ability being cast)
        Set Whats_That_Cast_point = (Position of (Casting unit))
        Set Whats_That_group = (Units within 300.00 of Whats_That_Cast_point)
        Unit Group - Pick every unit in Whats_That_group and do (Actions)
            Loop - Actions
                Unit - Make (Picked unit) face Whats_that_point over 0.10 seconds
                Unit - Create 1 dummy for (Owner of (Casting unit)) at (Position of (Picked unit)) facing Default building facing (270.0) degrees
                Unit - Add Storm Bolt to (Last created unit)
                Unit - Order (Last created unit) to Human Mountain King - Storm Bolt (Picked unit)

I have edited storm bolt so it does no damage and has a 3 second duration.
what it actually does is just make the units face the cast point without any stun.

Apart from memory leaks can someone please tell me whats wrong with it?

btw I based the spell off shockwave, If thats the problem could someone please suggest another point targetable spell I could base it off so it will work.
thanks in advance.

 

[R@d14nc3]

It leaks.
You wish to add the custom script: set bj_wantDestroyGroup = True since you are using one

 

[Andrewgosu]

Did you make sure your dummy caster has enough mana if the spell needs mana?
Did you make sure that the dummy stun spell isn't hero spell if the dummy is not hero?

Btw, Rad, its set bj_wantDestroyGroup = true (JASS is case sensitive)

 

[Chocobo]

Did you make sure your dummy caster has enough mana if the spell needs mana?
Did you make sure that the dummy stun spell isn't hero spell if the dummy is not hero?

Btw, Rad, its set bj_wantDestroyGroup = true (JASS is case sensitive)

And tell him to clean his dummy units, they do not expire.

 

[Mullit]

I know it leaks and I just forgot the expiration timer. The problem may be the mana thing ill go check.

>nope, its not that. I set the mana cost for stormbolt to 0 and my dummy has 100 mana anyway

 

[R@d14nc3]

A simple thought:

How come you cast storm Bolt, a single-targeted spell to multiple units?

 

[Mullit]

The loop means it does those actions once for every picked unit. So it doesnt cast it on lots of units but makes a new dummy unit for each picked unit.

 

[lh2705]

    Events
        Unit - A unit Starts the effect of an ability
    Conditions
        (Ability being cast) Equal to Whats That? 
    Actions
        Set Whats_that_point = (Target point of ability being cast)
        Set Whats_That_Cast_point = (Position of (Casting unit))
        Set Whats_That_group = (Units within 300.00 of Whats_That_Cast_point)
        Unit Group - Pick every unit in Whats_That_group and do (Actions)
            Loop - Actions
                Unit - Make (Picked unit) face Whats_that_point over 0.10 seconds
                [B]Set TempPoint = (Position of (Picked Unit)[/B]
                Unit - Create 1 dummy for (Owner of (Casting unit)) at [B]TempPoint[/B]) facing Default building facing (270.0) degrees
                [B]Custom Script : call RemoveLocation (udg_TempPoint)[/B]
                [B]Unit - Give (Last Created Unit) a 3 second expiration timer[/B]
                Unit - Add Storm Bolt to (Last created unit)
                Unit - Order (Last created unit) to Human Mountain King - Storm Bolt (Picked unit)
        [B]Custom Script : call RemoveLocation (udg_Whats_that_point)
        Custom Script : call RemoveLocation (udg_Whats_That_Cast_point)
        Custom Script : call DestroyGroup (udg_Whats_That_group)[/B]

Fixed the leaks

Maybe you could try using Channel as the base..

 

[Mullit]

I know how to fix the leaks but thanks anyway. I will try basing it off channel.

>ok I tried basing it off channel but now when the hero learns the spell the icon doesn't show up so I cant cast it to test if it works.

 

[AceHart]

For futur reference, "Owner of (Casting unit)" is not very good.
Casting unit tends to get lost in triggers that do their own casting.
Store it in a variable first.

Channel has several "Options", one of them being "visible".

 

[lh2705]

I'm not really sure about the channel ability's options...
Visible
Targeting Image
Physical Spell
(forgot the last one)

Anyone can clarify?

Not sure if this is off-topic..

 

[Chocobo]

I'm not really sure about the channel ability's options...
Visible
Targeting Image
Physical Spell
(forgot the last one)

Anyone can clarify?

Not sure if this is off-topic..

http://world-editor-tutorials.thehelper.net/cat_usersubmit.php?view=14972