Remove Effect (Model) Attached to Unit?

[Tyrulan]

Here's the code:

        call SetUnitAnimation( caster, "attack" )
        call AddSpecialEffectTargetUnitBJ( "hand, left", caster, "war3mapImported\\Final Rod.mdx" )
        set fD.casterRod = GetLastCreatedEffectBJ()

It is contained within the create of my struct.

In the onDestroy() I am destroying it.

    method onDestroy takes nothing returns nothing
        set this.caster = null        
        call DestroyEffectBJ(this.casterRod)        
    endmethod

However it is still there? Attached the left hand of my unit. Please go away!!! Lol

 

[13lade619]

should only be:

method onDestroy takes nothing returns nothing
        set .caster = null        
        call DestroyEffectBJ(.casterRod)        
endmethod

you're referring to stuff inside the struct so you dont need the ones before the '.' .

 

[Tyrulan]

Isn't ".casterRod" and "this.casterRod" the same thing?

 

[wraithseeker]

local [structname] this is always generated in methods so this or . will work well.

Mind showing the whole code? You can try removing those BJ too.

In your create method simply just put set

fD.casterRod = AddSpecialEffectTarget(//parametres)

 

[~GaLs~]

set fD.casterRod = AddSpecialEffectTargetUnitBJ( "hand, left", caster, "war3mapImported\\Final Rod.mdx" )

 

[Tyrulan]

I've fixed this problem. However it takes about.. 5-6 seconds for the model to be removed from the unit. Any way to make this faster?

For anyone who cares here's my solution.

call AddSpecialEffectTargetUnitBJ( "hand, left", caster, "war3mapImported\\Final Rod.mdx" )
set fD.casterRod = bj_lastCreatedEffect

method onDestroy takes nothing returns nothing
     set this.caster = null        
     call DestroyEffectBJ(this.casterRod)     
endmethod

 

[Nexor]

at gameplay constants you can set the time for effects to be removed, but it'll change every effect's time.

 

[wraithseeker]

Maybe this library would help

library TargetTimedEffects requires TimerUtils

private struct data
    effect EFFECT
    timer t

static method create takes nothing returns data
    local data d = data.allocate()
    set d.t = NewTimer()
    return d
endmethod

endstruct

function StopEffect takes data instance returns nothing
    call DestroyEffect(instance.EFFECT)
    call ReleaseTimer(instance.t)
    call instance.destroy()
endfunction

private function DestroyEffects takes nothing returns nothing
    local data d = GetTimerData(GetExpiredTimer())
    call DestroyEffect(d.EFFECT)
    call ReleaseTimer(d.t)
    call d.destroy()
endfunction
    
function AddTimedSpecialEffect takes string EFFECT, real x, real y, real TIME returns nothing
    local data d = data.create()
    call SetTimerData(d.t,d)
    call TimerStart(d.t,TIME,false,function DestroyEffects)
    set d.EFFECT = AddSpecialEffect(EFFECT,x,y)
endfunction
    
function AddTimedEffectTarget takes string EFFECT, unit target, string attachpoint, real TIME returns nothing
    local data d = data.create()
    call SetTimerData(d.t,d)
    call TimerStart(d.t,TIME,false,function DestroyEffects)
    set d.EFFECT = AddSpecialEffectTarget(EFFECT,target,attachpoint)
endfunction

endlibrary

 

[Tyrulan]

Looks great Wraith, though I'm a little unfamiliar with libraries and not sure how to actually use this. Thanks guys!!

 

[_whelp]

I've fixed this problem. However it takes about.. 5-6 seconds for the model to be removed from the unit. Any way to make this faster?

For anyone who cares here's my solution.

call AddSpecialEffectTargetUnitBJ( "hand, left", caster, "war3mapImported\\Final Rod.mdx" )
set fD.casterRod = bj_lastCreatedEffect

method onDestroy takes nothing returns nothing
     set this.caster = null        
     call DestroyEffectBJ(this.casterRod)     
endmethod

Your fishing rod may not have any animations if it stays for 5-6 seconds.

 

[~GaLs~]

>>it takes about.. 5-6 seconds for the model to be removed from the unit.
It is the model's death period?

 

[kingkingyyk3]

Use Dummy or edit the model if you have the problem .

 

[Tyrulan]

at gameplay constants you can set the time for effects to be removed, but it'll change every effect's time.

Thank you to Nexor for the simple solution to this problem. Closed.