Snippet ResetTooltips

[Azlier]

'Avul' can work without any problems, if I remove that lovely MakeUnitFlyable capability, which shouldn't be in there anyway.

 

[quraji]

Until then, I'm sure the player can manage with this silly little bug, and not have the performance of the map crippled because of something so insignificant.

How would the performance be crippled?

Can you automatically do this in response to an event that causes the bug?

Who cares about the "lovely side effect" of making units flyable?

 

[Azlier]

Because side effects should be documented.


>Can you automatically do this in response to an event that causes the bug?

Well, I can hook [lJASS]UnitAddAbility[/lJASS]. But then I get a crazy recursive function. Probably results in a game crash.

 

[quraji]

>Because side effects should be documented.

Suppose so.

>Well, I can hook UnitAddAbility. But then I get a crazy recursive function. Probably results in a game crash.

More vJass hook woes =/
What about something like this:

globals
    private boolean reset = true
endglobals

function ResetTooltips takes unit u returns nothing
    if (reset==false) then
        return
    endif
    set reset = false
    if UnitAddAbility(u, 'Arav') then
        call UnitRemoveAbility(u, 'Arav')
    endif
    set reset = true
endfunction

hook whatever whatever

 

[Azlier]

Wait, not UnitAddAbility. I realize it now. The native that sets an ability's level.

Now I need a 0 second timer, a second function, a system to handle the timers for me, and a struct to hold the unit!

AWAY I GO!

...But not today. I don't have WC3 today.

 

[quraji]

Wait, not UnitAddAbility. I realize it now. The native that sets an ability's level.

Now I need a 0 second timer, a second function, a system to handle the timers for me, and a struct to hold the unit!

AWAY I GO!

...But not today. I don't have WC3 today.

Errr...k. :nuts:

 

[Troll-Brain]

If you want to refresh UI, just use a dummy ability with no effect at all, add/remove it.
I guess using the object merger is fine for that here.

 

[Azlier]

Indeed it is. I'll add a dummy ability via ObjectMerger and hook it so it runs whenever you increase a unit's ability's level.

 

[Jesus4Lyf]

Sounds like a good solution to me. I would've said use object merger (to solve your arav problems)...

And fully encapsulated system this becomes...?

PS. You don't need a timer sys for 0 sec timers, see Damage.

 

[Azlier]

>You don't need a timer sys for 0 sec timers

What if someone calls the native more than once at a time? Or within 0.001 seconds of the other (or whatever the lowest timer amount is)?

Hmm.

 

[Jesus4Lyf]

Do it the way Damage did. Resume the timer more than once, add it to the list.
I linked it because it supports that.

 

[Azlier]

Alrighty then.

 

[Weep]

I wonder if boolean operations are faster than Ifs.

[ljass]return (UnitRemoveAbility(u, 'Avul') and UnitAddAbility(u, 'Avul')) or (UnitAddAbility(u, 'Avul') and UnitRemoveAbility(u, 'Avul'))[/ljass]

 

[Azlier]

That is totally insane.

Beautiful.

 

[Jesus4Lyf]

[ljass]return (UnitRemoveAbility(u, 'Avul') and UnitAddAbility(u, 'Avul')) or (UnitAddAbility(u, 'Avul') and UnitRemoveAbility(u, 'Avul'))[/ljass]

That is awesome. (But I don't know about good.)