Trigger not working properly, pls just give it a look

[Tinker]

Guys this trigger isnt working properly.

It plays the sound and gives the hero the item as it should but then it doesnt remove the item from him anymore :S

• Scream of Pain
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • Or - Any (Conditions) are true
      • Conditions
        • (Ability being cast) Equal to Scream of Pain
        • (Ability being cast) Equal to Scream of Pain Upgr
  • Actions
    • Sound - Play Scream <gen> at 100.00% volume, attached to (Triggering unit)
    • Unit - Add HUGE REGENERATION to (Triggering unit)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Integer((Percentage life of (Triggering unit)))) Greater than or equal to 99
      • Then - Actions
        • Unit - Remove HUGE REGENERATION from (Triggering unit)
      • Else - Actions

Fixed doing this :

• Scream of Pain
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • Or - Any (Conditions) are true
      • Conditions
        • (Ability being cast) Equal to Scream of Pain
        • (Ability being cast) Equal to Scream of Pain Upgr
  • Actions
    • Set SoP_Unit = (Triggering unit)
    • Sound - Play Scream <gen> at 100.00% volume, attached to SoP_Unit
    • Unit - Add HUGE REGENERATION to (Triggering unit)
    • Trigger - Turn on Scream of Pain Check <gen>

and this ...

• Scream of Pain Check
  • Events
    • Time - Every 0.01 seconds of game time
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Integer((Percentage life of SoP_Unit))) Equal to 100
      • Then - Actions
        • Unit - Remove HUGE REGENERATION from SoP_Unit
      • Else - Actions

 

[GFreak45]

does the percent actually reach 100 or does the unit keep taking damage?
and i would do that one like this instead:

• Scream of Pain Check
  • Events
    • Time - Every 0.01 seconds of game time
  • Conditions
    • (Integer((Percentage life of SoP_Unit))) Greater than or Equal to 99
  • Actions
    • Unit - Remove HUGE REGENERATION from SoP_Unit

 

[Tinker]

does the percent actually reach 100 or does the unit keep taking damage?
and i would do that one like this instead:

• Scream of Pain Check
  • Events
    • Time - Every 0.01 seconds of game time
  • Conditions
    • (Integer((Percentage life of SoP_Unit))) Greater than or Equal to 99
  • Actions
    • Unit - Remove HUGE REGENERATION from SoP_Unit

It reaches 100 anyway it is 500 hp reg per sec

 

[GFreak45]

did you test it out? the way it calculates that is by some simple math and converting it to an integer chops off the end of the real number instead of rounding it... meaning if its 99.99999999% it becomes 99 when you convert it to an integer