[Trigger Request] Ice Skating

[Black Hawk]

Hello, I am requesting a ice skating trigger from some one.
I mean that the unit slides in a certain direction when on ice. Help would be apriciated.

 

[Ghan]

Tried search? Sliding? It's actually a rather common question.

 

[Black Hawk]

Oh, thanks

 

[AoW_Hun7312]

You could use my trigger, its far less coding then the ones from other tutorials. AND covers all units.

Sliding
    Events
        Time - Every 0.03 seconds of game time
    Conditions
    Actions
        Unit Group - Pick every unit in Temp_Group and do (Actions)
            Loop - Actions
                Set Temp_Point1 = (Position of (Picked unit))
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        (Terrain type at Temp_Point1) Equal to Sunken Ruins - Large Bricks
                    Then - Actions
                        Set Temp_Point2 = (Temp_Point1 offset by 13.00 towards (Facing of (Picked unit)) degrees)
                        Unit - Move (Picked unit) instantly to Temp_Point2
                        Custom script:   call RemoveLocation(udg_Temp_Point2)
                    Else - Actions
       
                Custom script:   call RemoveLocation(udg_Temp_Point1)

 

[Ghan]

Unit Group - Pick every unit in Temp_Group and do (Actions)

TempGroup? There's no TempGroup. And the Unit Group leaks.

 

[AoW_Hun7312]

The unit group, is something I refer to alot of times, no sense in removing it is there?
EDIT: Temp_Group is set at map initialization.

All Units
    Events
        Map initialization
    Conditions
    Actions
        Set Temp_Group = (Units of type Demon Hunter)

 

[Ghan]

> no sense in removing it is there?

There is very much sense in removing the Unit Group. Set it, use it, remove it. Otherwise you leak a Unit Group every 0.03 seconds. Not pretty.

> Temp_Group is set at map initialization.

You can't do it like that. It still leaks.

 

[AoW_Hun7312]

Damn. No one every told me that :\. Oh well, time to re work it.

EDIT: Reworked Trigger.

Sliding
    Events
        Time - Every 0.03 seconds of game time
    Conditions
    Actions
        Unit Group - Pick every unit in Temp_Group and do (Actions)
            Loop - Actions
                Set Temp_Group = (Units of type Demon Hunter)
                Set Temp_Point1 = (Position of (Picked unit))
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        (Terrain type at Temp_Point1) Equal to Sunken Ruins - Large Bricks
                    Then - Actions
                        Set Temp_Point2 = (Temp_Point1 offset by 13.00 towards (Facing of (Picked unit)) degrees)
                        Unit - Move (Picked unit) instantly to Temp_Point2
                        Custom script:   call RemoveLocation(udg_Temp_Point2)
                    Else - Actions
                        Do nothing
                Custom script:   call RemoveLocation(udg_Temp_Point1)
                Custom script:   call DestroyGroup(Temp_Group)

 

[elmstfreddie]

You can't do it like that. It still leaks.

Uhmm.. No...
It would leak if he set it every 0.03 seconds. He set it once, he doesn't need to destroy. Ever. You only destroy a group if you're going to set it again, and the same goes for all other variable types (except integers, reals, etc)

 

[Ghan]

I stand corrected. Though, I suppose that does make more sense....

 

[AoW_Hun7312]

Ok, time to rework it AGAIN...

 

[elmstfreddie]

And the reason his trigger is still working is because he attempts to destroy the group inside the unit group loop, so it never removed the group. Which is good, because if he removed it the trigger would stop working after the first time it went. lol

 

[AoW_Hun7312]

Lol, I under stand leaks now... I think.

My quick... Wierd defenition of a leak

Leak: Noun.

A leak is anything in WE that is not removed after use, if it has no other use.
Things that have generally no use, after it is used are; points, unit-groups, and special effects. These are removed in GUI within 'Custom Scripts' , or for special effects blizzard's already made GUI action. For unit groups you would use Custom script: call DestroyGroup(udg_Unit_Group)
replacing Unit_Group with the name of your unit group variable. For points you would use Custom script: call RemoveLocation(udg_Temp_Point) replacing Temp_Point with the name of your point variable. For special effects you would use the action Special Effect - Destroy (Last created special effect)

This is everything that I have learned from Ghan, and by past experience. Am I wrong?

 

[Ghan]

> Am I wrong?

No, but you're incomplete. Player Groups also leak. I also think that rects can leak, as well as local handles such as units, locations, timers, etc. Also, I believe that triggers themselves leak to some extent. But when you start talking about that stuff, the definition of 'leak' gets a little fuzzy.

 

[AoW_Hun7312]

Wow, I think that I just got a head ache... Ok refresh my memory... Unit Groups, Variables, Destructables, World Editor, The Frozen Throne, Reign Of Chaos. World of WarCraft (wtf is that doing there?).

Off topic. Im gonna go and make a maze tutorial!!! Now to find a place where I can upload some images. Anyone know of some?

 

[elmstfreddie]

tinypic.com is ownage.