Help on merging functions

[neetmaster]

function Trig_Learning_Spells_Func002A takes nothing returns nothing
    set udg_spellLearningUnit = GetEnumUnit()
endfunction

function Trig_Learning_Spells_Actions takes nothing returns nothing
    set udg__tempUnitGroup = GetUnitsOfPlayerAndTypeId(GetTriggerPlayer(), 'H002')
    call ForGroupBJ( udg__tempUnitGroup, function Trig_Learning_Spells_Func002A )
    call DestroyGroup (udg__tempUnitGroup)

How can I merge the upper one into the lower one so I will have less functions in a trigger?
Thanks.

 

[_whelp]

I'm not sure if this will work, but here you go anyway.

function somethingBoring takes nothing returns nothing
    set bj_groupEnumTypeId = 'H002'
    call GroupEnumUnitsOfPlayer(udg__tempUnitGroup, GetTriggerPlayer(), filterGetUnitsOfPlayerAndTypeId)
    loop
        set udg_spellLearningUnit = FirstOfGroup(udg__tempUnitGroup)
        exitwhen udg_spellLearningUnit == null
        //Do whatever here...
    endloop
    call DestroyGroup (udg__tempUnitGroup)
endfunction

fixed...?

 

[neetmaster]

I'm not sure if I want to change the structure of the whole function...
Thanks anyways. More ideas welcomed though.

 

[_whelp]

I'm not sure if I want to change the structure of the whole function...
Thanks anyways. More ideas welcomed though.

There is another way, but it requires 2 functions...Link

 

[Frozenhelfir]

Um... what is that supposed to accomplish? It will only set that variable to the last unit in the group. Perhaps you should use an array, or maybe you just want the triggering unit to be set to that variable since it'd be the one learning the spell?