Periodic Group usage

[Arkan]

I was wondering, which method is best/fastest?

#1

function ThisFunctionRunsEverySecond takes nothing returns nothing
  local group g = CreateGroup()
  call GroupEnumUnitsInRange(g,x,y,400,Safe)
  // actions
  call DestroyGroup(g)
  set g = null
endfunction

#2

scope something
globals
  private group G = CreateGroup()
endglobals

function ThisFunctionRunsEverySecond takes nothing returns nothing
  call GroupEnumUnitsInRange(G,x,y,400,Safe)
  // actions
  call GroupClear(G)
endfunction

I think #2 would be better, but I could be wrong, what do you think?

 

[Artificial]

One group > Recycling groups > Destroying groups.
That's what I've heard. ^_^ So 2 should be better.

 

[saw792]

I would say that #2 is faster, because it only requires CreateGroup() to be called once, while it is called every second in #1. You're hardly going to notice the difference though.

 

[Arkan]

Alright, as I thought then ^^

 

[TheDamien]

You should do all the group actions in the filter of GroupEnumUnitsInRange.

 

[Hatebreeder]

You should do all the group actions in the filter of GroupEnumUnitsInRange.

What?
You can do actions in a filter? Is it like, a replace for ForGroup? Please explain... With pictures and stuff =P

 

[Flare]

What?
You can do actions in a filter? Is it like, a replace for ForGroup? Please explain... With pictures and stuff =P

You have a reference to the unit (GetFilterUnit ()) so you can easily just use that instead of ForGroup + GetEnumUnit

 

[TheDamien]

What?
You can do actions in a filter? Is it like, a replace for ForGroup? Please explain... With pictures and stuff =P

private function foo takes nothing returns boolean
    local unit u = GetFilterUnit()
    if (GetWidgetLife(u) > 0.405) then
        call ExplodeUnitBJ(u)
    endif
    set u = null
    return false
endfunction

call GroupEnumUnitsInRange(G, x, y, r, Condition(function foo))

G can be a global initialized to CreateGroup().

 

[Arkan]

Interesting, though that would create many additional functions.

 

[Tukki]

Yeah, but it's more efficient. Another one could be that you use a Condition instead of a function to enum the units. As Conditions are evaluated before the actions are executed.