Removing leaks = not optimal?

[Ancanus]

Someone said that using the RemoveLocation calls and equivalents are not good because you keep creating and destroying handles, and that it was more efficient to just clear the variables and use them again. Yet, I see everyone around here always suggesting to use the JASS calls with no regards to the previous.

Can an expert on the matter clear things up?

 

[Komaqtion]

Well, when it comes to location, then it depends... It's never good to overwrite a point variable, but if you use a variable for one spot only, and don't change it's position, then you don't need to destroy it

 

[Skippy]

... It's never good to overwrite a point variable...

Why not??

 

[Azlier]

Overwriting doesn't destroy what the variable previously held.

 

[Ancanus]

so... Is there any advantage to not destroying the variable and using it again?

 

[BlackRose]

You can potentially lag everyone for fun and waste their time (if you manage to get enough leaks ^_^)

 

[Tru_Power22]

so... Is there any advantage to not destroying the variable and using it again?

No.

 

[Weep]

so... Is there any advantage to not destroying the variable and using it again?

There's a difference between overwriting and reusing. For the entities that can be reused once created (unit groups can be cleared and re-filled, locations can be moved), that's faster. You still need to destroy an entity if you are going to set the variable's value again, instead of modifying an existing variable's data.

e.g. Instead of:

set TempPoint = GetUnitLoc(unit)
< Do stuff >
call RemoveLocation(TempPoint)

it would be faster* to do:

call MoveLocation(TempPoint, GetUnitX(unit), GetUnitY(unit))

You probably see destroying/leak prevention so often because GUI doesn't really give the user the tools to reuse these entities (without using Custom Script, which is just a line of JASS). Most of what you can do in GUI will overwrite the variable if not destroyed first.

*I think. The second example takes more function calls, so I'm not sure.

 

[Karawasa]

Use this and forget about your problems.

http://www.wc3c.net/showthread.php?t=107432

 

[Ancanus]

Use this and forget about your problems.

http://www.wc3c.net/showthread.php?t=107432

I don't think I could ever incorporate this tool. I for one, constantly use global variables ( locations and unit groups) to communicate between triggers.

It would seem I would spend more time calling ProtectHandle than actually removing the variables.

I'm sure someone else might find an use for it.

 

[Viikuna]

Also, if you learn Jass you dont have to qorry about nay leak stuff, because cleaning them comes naturally. You only really need one location per map anyways: for GetLocationZ.