Undefined function.

[Flare]

I'm trying to make my first JASS spell, but for some reason, I'm getting an Undefined function error when I save (it's the only error I have so far).

(Most of the comments can be ignored, they are just for personal reference)

scope CrimsonFlash
//Alter this to change the speed of the fireballs, how often fireballs spawn, the rawcode of your base ability, and how often the fireballs move
globals
    constant integer spellid = 'A000'
    constant real distance = 30
    constant real slideperiod = 0.04
    constant real spawnperiod = 0.25
    constant real angleincrease = 35
    constant real initangle = GetRandomReal (1, 360)
endglobals

//Data used to create fireballs and set their facing angle
struct Firespawn
    unit fireowner
    real spawnrate //This will increase with level, when the spell works in the first place
endstruct



//Data used to move the fireballs, and determine when they expire
struct Firemovement
    unit fireunit //The dummy fireball unit
    real x1
    real x2
    real y1
    real y2
    real anglerad
    real angledeg
    integer ticks
endstruct
 
//Spell conditions
function Spell_Conditions takes nothing returns boolean
    return GetSpellAbilityId () == spellid
endfunction

//Spell actions
function Spell_Actions takes nothing returns nothing
    local real angle
    local timer t1 = CreateTimer ()
    local Firespawn data = Firespawn.create ()
    call SetTimerStructA (t1, data)
    set data.fireowner = GetTriggerUnit ()
    call TimerStart (t1, spawnperiod, true, function Timer1Actions) //Error saying that function Timer1Actions is undefined
endfunction

function Timer1Actions takes nothing returns nothing
    local Firespawn data
    local timer t1 = GetExpiredTimer ()
    local real spawnangle
    set data = GetTimerStructA(t1)
    set spawnangle = initangle
    set spawnangle = spawnangle + angleincrease
endfunction



//Trigger Init
function InitTrig_Spell takes nothing returns nothing
    local trigger  Spell = CreateTrigger(  )
    call TriggerAddAction( gg_trg_Spell, function Spell_Actions )
    call TriggerRegisterAnyUnitEventBJ (Spell, EVENT_PLAYER_UNIT_SPELL_EFFECT)
    call TriggerAddCondition (Spell, Condition (function Spell_Conditions))
endfunction
endscope

 

[AceHart]

From the top of the script down to that "error", your function has not been seen yet.

 

[Hatebreeder]

Well, I think you used ABC wrong...

function Timer1Actions takes nothing returns nothing
    local Firespawn data
    local timer t1 = GetExpiredTimer ()
    local real spawnangle
    set data = GetTimerStructA(t1)
    set spawnangle = initangle
    set spawnangle = spawnangle + angleincrease
endfunction

This should be over the Actions Part.

 

[SerraAvenger]

Try taking out the comments just as a test, I had problems concerning them too...

Apart from that, make sure you've got SetTimerStructA and GetTimerStructA as functions

And do this:

//Spell actions

function Timer1Actions takes nothing returns nothing
    local Firespawn data
    local timer t1 = GetExpiredTimer ()
    local real spawnangle
    set data = GetTimerStructA(t1)
    set spawnangle = initangle
    set spawnangle = spawnangle + angleincrease
endfunction

function Spell_Actions takes nothing returns nothing
    local real angle
    local timer t1 = CreateTimer ()
    local Firespawn data = Firespawn.create ()
    call SetTimerStructA (t1, data)
    set data.fireowner = GetTriggerUnit ()
    call TimerStart (t1, spawnperiod, true, function Timer1Actions) //Error saying that function Timer1Actions is undefined
endfunction

hth, Davey

Edit: and again I was typing too slow ; O
Aceheart is right ofc

 

[Flare]

From the top of the script down to that "error", your function has not been seen yet.

uhm... meaning?

Edit: oh, just did what hatebreeder/serraavenger said and it works. ill assume that's what acehart was trying to tell me to do ^^ tyvm for the help

 

[SerraAvenger]

uhm... meaning?

That the compiler goes from line to line, top to bottom.
Thus it only knows things that it actually had read before, so if you call a function that you add after the point of calling, the compiler has never seen the function before. Thus he says "WTF? I can't call this function, I've never seen it!!!", and gives you an error message.

Hth, Davey

 

[soulreaping]

I hate seeing people assigning the expired timer that is needed to pull out the attached struct to a local variable.

It makes nothing faster, and requires nullification.

Simply do this:

local Struct s = GetTimerStructA(GetExpiredTimer())

Easier.

 

[GoGo-Boy]

I hate seeing people assigning the expired timer that is needed to pull out the attached struct to a local variable.

It makes nothing faster, and requires nullification.

Simply do this:

local Struct s = GetTimerStructA(GetExpiredTimer())

Easier.

Ahh nice, gonna use this right now

 

[Flare]

thanks for the tip, but how the f*ck does that help me if i dont have a clue where im supposed to put that... does that go in my timer actions, or my spell init actions?

 

[0zaru]

EDIT: Oh was this solved? I read the last question, and posted then I read an Edit from Flare...

local Struct s = GetTimerStructA(GetExpiredTimer()) <--- This function goes in the TimerActions, It's a short form to get the struct. Also remember to null local timers, etc

 

[Flare]

it was solved, but thanks for trying to help