Units Matching Conditions

[Zurtrogx]

Which of the following is better to use? (ignore and leaks that may exist)

Option 1

• Set UnitGroup = (Units within 500.00 of Point matching this and that and this and that and this and that
  • Unit Group - Pick every unit in UnitGroup and do (Actions)
    • Loop - Actions
      • Do whatever

Option 2

• Set UnitGroup = (Units within 500.00 of Point)
  • Unit Group - Pick every unit in UnitGroup and do (Actions)
    • Loop - Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • Condition 1
          • Condition 2
          • Condition 3
        • Then - Actions
          • Do whatever
        • Else - Actions

 

[Weep]

They are almost identical in terms of how much code gets run, I believe, though using "matching condition" will wind up being slightly more efficient. One additional note, though, is that the code that the GUI "Units with range" without condition is converted into leaks slightly no matter what you do. It would be fine to use "Units within range matching condition" with only a basic condition (such as (Matching Unit) is A structure Equal to False or even True Equal to True) and do the rest of the filtering with an If.

 

[X.Terror.X]

first is better cuz u dont have to repeat that liek u have to do in 2
and stil lcomemnt on elak u should use and all conditions are true[in 2]

 

[Bird]

Your 2nd version is much much easier to edit (add/remove/replace), so unless you know exactly what conditionals you are using, stick with the 2nd one.

 

[X.Terror.X]

your 2nd version is much much easier to edit (add/remove/replace), so unless you know exactly what conditionals you are using, stick with the 2nd one.

not true editing all in 1 varible is easyer if uwanna change your data u only have to do it 1 time if u use this in more tirggers and uwant to change uhave to change it x times

look just do whats better for your self it has no change if u want to easely edit it for more times u use 1 if u only the varible 1 time there is no use of making a varible in any way except if it is needed for a other trigger

 

[Bird]

^ Er, I'm referring to the fact that, in the 2nd example, all he has to do is add a new conditional is just a copy/paste with a slight change from the dropdown.

In the 1st example, he would have to change a condition to an "AND", and completely redo the first conditional, and add a completely new second conditional.

This is very tedious to keep doing if you don't have your conditionals down pat.

 

[Gtam]

use the first for its a little faster than the second since it filters out the units before the picking so not so many is run through the loop where the second all is run through the loop.

 

[Zurtrogx]

... In the 1st example, he would have to change a condition to an "AND", and completely redo the first conditional, and add a completely new second conditional.

This is very tedious to keep doing if you don't have your conditionals down pat.

Yeah... that's why I don't like using the first one.

Anyway, thanks everyone for your help.