I'm new to structs

[Laiev]

The Manual

 

[Romek]

//
    private function pressr takes nothing returns nothing
        if right[GetPlayerId(GetTriggerPlayer())] == true then
            set right[GetPlayerId(GetTriggerPlayer())] = false
        else
            set right[GetPlayerId(GetTriggerPlayer())] = true
        endif
    endfunction

//
    private function pressr takes nothing returns nothing
        set right[GetPlayerId(GetTriggerPlayer())] = not right[GetPlayerId(GetTriggerPlayer())]
    endfunction

Slight optimization.

 

[Magthridon96]

Same for these:

private function pressl takes nothing returns nothing
    if left[GetPlayerId(GetTriggerPlayer())] == true then
        set left[GetPlayerId(GetTriggerPlayer())] = false
    else
        set left[GetPlayerId(GetTriggerPlayer())] = true
    endif
endfunction

->

private function pressl takes nothing returns nothing
    set left[GetPlayerId(GetTriggerPlayer())] = not left[GetPlayerId(GetTriggerPlayer())]
endfunction

---------------------------------------------

private function pressu takes nothing returns nothing
    if up[GetPlayerId(GetTriggerPlayer())] == true then
        set up[GetPlayerId(GetTriggerPlayer())] = false
    else
        set up[GetPlayerId(GetTriggerPlayer())] = true
    endif
endfunction

->

private function pressu takes nothing returns nothing
    set up[GetPlayerId(GetTriggerPlayer())] = not up[GetPlayerId(GetTriggerPlayer())]
endfunction

--------------------------------------------

Is suspect you're using AIDS, so:

private function setglobals takes nothing returns nothing
    local shipdata ud=shipdata.create()
    set ship[0] = CreateUnit(Player(0),'H000',-3000.,-3000.,0.)
    call SetUnitUserData(ship[0],ud)
    call ud.store(ship[0],GetPlayerId(GetOwningPlayer(ship[0])))
endfunction

Using SetUnitUserData will break it

Instead, a simple hashtable save/load or array lookup would be better :3

Another thing:

In your turn function:

if b==true and this.y < d then
    set this.y = this.y + a
elseif c==true and this.y > d*(-1) then
    set this.y = this.y - a
endif

It could be:

if b and .y < d then
    set .y = .y + a
elseif c and .y > -d then
    set .y = .y - a
endif

Also:

call PanCameraToTimed(x,y,0.)
call SetCameraRotateMode(x,y,Deg2Rad(270+GetUnitFacing(ship<i>)),0.)
call SetCameraField(CAMERA_FIELD_TARGET_DISTANCE,3900.,0.)
</i>

That would affect all players
Using these calls inside a GetLocalPlayer block would be the solution. (If this is a problem to begin with lol)

----
And I believe 0.03125 is the proper timer interval for high-frequency periodic stuff