Spellpack Nuke, Flame Storm, Blink Back, Fade Run

Prometheus

Everything is mutable; nothing is sacred
Reaction score
589
Well, care to explain please? I can't figure it out myself.
 

emjlr3

Change can be a good thing
Reaction score
395
when the caster begins some animation, create dummy units that you will use and have them display the same animation

when needed, move them to the correct spot, display them and freeze em
 

Romek

Super Moderator
Reaction score
963
Each of your spells need descriptions before this can be approved.
You need at least one screenshot for this to be approved - For the spells index.
Would be appreciated if that image was 256x256 pxls. :)

Nuke:
I suggest making DMG a configurable function instead of a global which is multiplied by the level.

JASS:
set SOUND = gg_snd_nuclear

gg_snd_nuclear is buried deep within that code.
How about:
JASS:
//constants
private constant string SOUNDPATH = "Some\\Path"

// Init Function
set Sound = CreateSoundFilenameWithLabel(SOUNDPATH, ..., ..)

Notice how Sound, a non-constant global isn't in all-caps.
You can also get rid of that timer you create at init like this.

Quit destroying the group, and make it a global group, which is created at init, and never destroyed.
I don't see you destroying the timer you create dynamically.
Infact, you shouldn't destroy timers. How about replacing AncientData with TimerUtils?

Locations are so GUI. :p

DistanceBetweenPoints could be set to a variable, as you're using it twice.
Though you could remove it by not using locations.

You don't null 't' in NukeAct.

You don't destroy your struct.

JASS:
method DmgE ...

Why?

JASS:
call UnitDamagePoint (..)

Desyncs on Macs. Get rid of realistic. It's simpler to just make them 'return true' in the filter.

Configurable?

It'd also be better if the sound was 3D.​


Flame Storm
Same DMG stuff applies here as the previous spell.

JASS:
[4]
Configurable?

Configurable?

As with before, locations are too GUI for Jass. :p
Your code will be more efficient, and you'd get rid of most of those BJs. They're all crappy, location-based ones.

Your function names suck.


Set those to variables. You're calling them each 4 times.

JASS:
.
        set a.ticker = a.ticker + TT_PERIOD * 100
        if a.ticker == TIME * 100 then

Why the *100? o_O


Desyncs.

I thought I'd mention here that basically all of these points should be repeated about 50 times. Especially the BJs and locations. They're fugly.​

I didn't bother looking at the rest, as I bet all of these points will be repeated again.
Fix these up, and I'll look over it all again.
 
General chit-chat
Help Users
  • No one is chatting at the moment.

      The Helper Discord

      Members online

      No members online now.

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top