Waah? Healing Wave crashes WC3

[Drunken_God]

Ive made a shadow hunter with an ability that links him with a target and if he now gets damage he gets healed by X percent of that damage and the target gets X percent of that damage

Now here is the problem if i cast my spell on a unit everything works fine but if i use now healing wave wc3 crashes
heres my damage trigger

ShadowLinkTakesDamage
    Events
    Conditions
        (Damage taken) Greater than 0.00
    Actions
        Trigger - Turn off (This trigger)
        For each (Integer A) from 1 to 200, do (Actions)
            Loop - Actions
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        (Triggering unit) Equal to SL_Caster[(Integer A)]
                    Then - Actions
                        Unit - Set life of (Triggering unit) to ((Life of (Triggering unit)) + ((Damage taken) x 0.30))
                        Unit - Cause (Triggering unit) to damage SL_Target[(Integer A)], dealing ((Damage taken) x 0.30) damage of attack type Spells and damage type Normal
                        Set temppoint = (Position of (Triggering unit))
                        Set temppoint2 = (Position of SL_Target[(Integer A)])
                        Lightning - Create a Finger of Death lightning effect from source temppoint to target temppoint2
                        Custom script:   call RemoveLocation(udg_temppoint)
                        Custom script:   call RemoveLocation(udg_temppoint2)
                        Set SL_LightningCount = (SL_LightningCount + 1)
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                SL_LightningCount Equal to 200
                            Then - Actions
                                Set SL_LightningCount = 0
                            Else - Actions
                        Set SL_LightningEffect[SL_LightningCount] = (Last created lightning effect)
                    Else - Actions
        Trigger - Turn on (This trigger)

 

[Weyrling]

Make a check for 'If damage < 0'?

 

[Larcenist]

Happened to me too when I used the "damage taken" function inside the same trigger as the "Unit takes damage" event. I think that's the root of all evil.

 

[Slapshot136]

turn the trigger off, deal the damage, then turn the trigger back on to prevent the infinite loop

 

[Drunken_God]

but its because of the healing wave, before it works fine

 

[Weyrling]

The healing wave triggers 'unit takes damage' but the triggering unit Is Himself so it makes your trigger loop infinitely.

 

[Drunken_God]

it doesnt work either

and the periodic(i dont think that really matters:

Shadow Link Periodic
    Events
        Time - Every 0.25 seconds of game time
    Conditions
    Actions
        For each (Integer A) from 1 to 200, do (Actions)
            Loop - Actions
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        SL_Periodic[(Integer A)] Greater than 0
                    Then - Actions
                        Lightning - Destroy SL_LightningEffect[(Integer A)]
                        Set SL_Periodic[(Integer A)] = (SL_Periodic[(Integer A)] - 1)
                    Else - Actions
                        Set SL_Periodic[(Integer A)] = 0
                        Set SL_Caster[(Integer A)] = No unit
                        Set SL_Target[(Integer A)] = No unit

 

[vypur85]

Lightning - Destroy SL_LightningEffect[(Integer A)]

Destroying non-existence lightning causes crash as well. Try remove this line and see whether it crashes or not. (Where is the create lightning action?)

 

[Drunken_God]

in the first trigger (first post)
moved the destroy lightning into the if cond

 

[vypur85]

Yeah. It's still the same reason. When your MUI counter (the SL_LightningCount) is, say, 5, then, lightning 1, 2, 3 and 4 are non-existence. You destroy them in the loop, so it might crash.

Try remove this line and see whether it crashes or not.

Try this and see if it crashes or not.

 

[Drunken_God]

lol thx
it were the lightning effects -.-
but how do i correct them?
ah +rep for you, of course
EDIT: got an idea:

 

[vypur85]

Hmm... I'm not too good with lightning effects . I had the same problem with you before. So I ended up using other alternative (without using lightning effect). So, yeah, maybe some other people could help you instead. The best advice for you is that you have to make sure that the lightning effect is created correctly and stored in correct variable etc etc as they are very sensitive.

And, I see that you do not move the lightning. Is the lightning stationary? If so, you could substitute it with Finger of Death with specific Graphic Duration.

 

[Drunken_God]

ive done it that way
create dummy and let it cast finger of death (it looks really cool)