.

JASS:
globals
    private integer array BlackList
    private integer StackLevel=0
endglobals

private function AddToList takes integer id returns nothing
    set StackLevel=StackLevel+1  // Not giving value to "BlackList[0]"
    set BlackList[StackLevel]=id
endfunction

private function Filter takes unit toFilter returns boolean
    local integer id=GetUnitTypeId(toFilter)
    local integer i=1
    loop
        exitwhen i>StackLevel
        if id==BlackList<i> then
            return false
        endif
        set i=i+1
    endloop
    return true
endfunction</i>


Simple as that. Alternatively, if those units share an attribute (like they're all creeps, etc), you can create a Sphere based dummy ability and check if the unit has that ability. That's what I'm doing on my map for heroes, creeps, minions, towers, and so forth.
 
Dude learn jass more and then come to make scripts, arrays are your best friend. Do as luorax says.
Try to make more things with arrays until you learn them for good. Don't stop only on what they give you.
 
Dude learn jass more and then come to make scripts, arrays are your best friend. Do as luorax says.
Try to make more things with arrays until you learn them for good. Don't stop only on what they give you.

Your comment is both rude and unnecessary, learn some respect. If you have nothing constructive to add to the conversation, don't say anything.
 
Actually the best way would be using array for O(1) checking, either table or hashing unit id into array will do.
JASS:
library Test requires Table initializer OnInit

globals
    private Table UnitTypeFilter
endglobals

function BlacklistUnitType takes integer uid returns nothing
    set UnitTypeFilter[uid]=1
endfunction

function IsUnitTypeBlacklisted takes integer uid returns boolean
    return UnitTypeFilter[uid]==1
endfunction

private function OnInit takes nothing returns nothing
    set UnitTypeFilter=Table.create()
endfunction

endlibrary

When the blacklist becomes bigger, this script will become faster than O(n) searching, which was introduced in luorax and your script.
 
@tommerbob
So giving some helpful advice became disrespectful?
If everyone came here after reading only "if then else" and wrote his question about making something better
without giving a try himself it wouldn't be a spam?

@kingkingyyk3
He should first learn O(n) complexity with loops before coming to O(1) hashed in arrays, but well done mate.
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • The Helper The Helper:
    https://www.thehelper.net/pages/news/ is a link to the old news portal - i will integrate it into the interface somewhere when i figure it out
  • Ghan Ghan:
    Need to try something
  • Ghan Ghan:
    Hopefully this won't cause problems.
  • Ghan Ghan:
    Hmm
  • Ghan Ghan:
    I have converted the Headline News forum to an Article type forum. It will now show the top 20 threads with more detail of each thread.
  • Ghan Ghan:
    See how we like that.
  • The Helper The Helper:
    I do not see a way to go past the 1st page of posts on the forum though
  • The Helper The Helper:
    It is OK though for the main page to open up on the forum in the view it was before. As long as the portal has its own URL so it can be viewed that way I do want to try it as a regular forum view for a while
  • Ghan Ghan:
    Yeah I'm not sure what the deal is with the pagination.
  • Ghan Ghan:
    It SHOULD be there so I think it might just be an artifact of having an older style.
  • Ghan Ghan:
    I switched it to a "Standard" article forum. This will show the thread list like normal, but the threads themselves will have the first post set up above the rest of the "comments"
  • The Helper The Helper:
    I don't really get that article forum but I think it is because I have never really seen it used on a multi post thread
  • Ghan Ghan:
    RpNation makes more use of it right now as an example: https://www.rpnation.com/news/
  • The Helper The Helper:
  • The Helper The Helper:
    What do you think Tom?
  • tom_mai78101 tom_mai78101:
    I will have to get used to this.
  • tom_mai78101 tom_mai78101:
    The latest news feed looks good
  • The Helper The Helper:
    I would like to see it again like Ghan had it the first time with pagination though - without the pagination that view will not work but with pagination it just might...
  • The Helper The Helper:
    This drink recipe I have had more than a few times back in the day! Mind Eraser https://www.thehelper.net/threads/cocktail-mind-eraser.194720/
  • The Helper The Helper:
    Happy Thursday!
  • Ghan Ghan:
    I'm not so sure, there's still a lot of Thursday left for it to become unhappy.
    +3
  • The Helper The Helper:
    still a few hours
  • The Helper The Helper:
    Its Friday!!!!
    +1
  • Ghan Ghan:
    Thursday 7/10 would Thursday again
    +3

      The Helper Discord

      Staff online

      Members online

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top