System Advanced Indexing & Data Storage

Discussion in 'Systems and Snippets' started by Jesus4Lyf, Jun 29, 2009.

  1. Sgqvur

    Sgqvur FullOfUltimateTruthsAndEt ernalPrinciples, i.e shi

    Ratings:
    +62 / 0 / -0
    Bribe:
    1. No, because after the timer the unit's user data will already be 0.

    1. Why should it? The unit is dead but it's user data is not zero.

    Let me give you an example:

    The example I am using is really simple, create 1 footman and 4 knights, for each I save their name and location and after the map loads
    I order the knights to kill the footman. When he dies the AIDS_onDestroy method should be called but it is NOT.
    But if the '==' is changed to '!=' for the above mentioned line it is called.
    JASS:
    
    
    
    
    
    
    library aidstest uses AIDS
    
        struct testaids extends array
            string name
            location l
        
            method AIDS_onCreate takes nothing returns nothing
                set name = GetUnitName(this.unit)
                set l    = GetUnitLoc(this.unit)
            endmethod
            
            method AIDS_onDestroy takes nothing returns nothing
                call RemoveLocation(l)
                call BJDebugMsg("AIDS_onDestroy called")
            endmethod
            
            static method AIDS_onInit takes nothing returns nothing
                call CreateUnit(Player(0), 'hfoo', 0, 0, 0)
                call CreateUnit(Player(0), 'hkni', 0, 0, 0)
                call CreateUnit(Player(0), 'hkni', 0, 0, 0)
                call CreateUnit(Player(0), 'hkni', 0, 0, 0)
                call CreateUnit(Player(0), 'hkni', 0, 0, 0)
            endmethod
    
            //! runtextmacro AIDS()
        endstruct
        
    endlibrary
     
  2. Bribe

    Bribe vJass errors are legion

    Ratings:
    +67 / 0 / -0
    You don't get what this does at all.

    AIDS_onDestroy is called when the unit has finished decaying, or is removed, not when the unit has simply "died".

    If you have it the way it is now, if you order a footman to "undefend" it will also fire the AIDS_onDestroy method. Fail.
     
    • Like Like x 1
  3. Sgqvur

    Sgqvur FullOfUltimateTruthsAndEt ernalPrinciples, i.e shi

    Ratings:
    +62 / 0 / -0
    Bribe:
    1. You don't get what this does at all.

    1. I get it now =).
     
  4. Jesus4Lyf

    Jesus4Lyf Good Idea™

    Ratings:
    +394 / 0 / -0
    Just to clarify, AIDS structs are not destroyed on death, they are destroyed when the unit is removed from the game.
    if GetUnitUserData(IndexUnit[UndefendExpiringIndex[0]]) == 0 then
    This line checks that the unit no longer exists. Nothing should have set it to 0, so it can only fire if the unit is gone. :)
     
  5. Bribe

    Bribe vJass errors are legion

    Ratings:
    +67 / 0 / -0
    Well Jesus, you could still do it without a timer and just check if the unit's ability level of the "Defend" ability is 0. Nestharus found out this trick.

    That way AIDS_onDestroy will fire while the unit is still in scope, and you could always rework the locks to just recycle the index instead of waiting for all locks released to fire onDestroy.
     
  6. Jesus4Lyf

    Jesus4Lyf Good Idea™

    Ratings:
    +394 / 0 / -0
    Correct, and always intended to implement this. Not that it matters, nor that I will, but y'know. Could happen, right?
    I was about to say incorrect, but you are, in fact, totally correct.

    I mean, these are changes which have trivial impact and require substantial time, thought and effort, which I'm currently dedicating to another project,a t the moment. Best I can do is assure you that said project is for this community. :)
     
  7. Nestharus

    Nestharus o-o

    Ratings:
    +83 / 0 / -0
    And you can ofc update the AIDS macro to be a module using static ifs
     
  8. Jesus4Lyf

    Jesus4Lyf Good Idea™

    Ratings:
    +394 / 0 / -0
    I'm not so sure that this is possible with full backwards compatibility. See, unfortunately, the init orders in JassHelper were all stuffed around while this was being made, and the result is not that the init order will not be the same if I was to do that. I tried making it a module and it actually broke some of my maps, so I gave up on the silliness at the time, and just let it be.
     
  9. Nestharus

    Nestharus o-o

    Ratings:
    +83 / 0 / -0
    Well, you could at least fix this

    JASS:
    
    private module Test
        private static method onInit takes nothing returns nothing
            local unit u = CreateUnit(...)
            //unit user data is 0!!
        endmethod
    endmodule
     
  10. GFreak45

    GFreak45 I didnt slap you, i high 5'd your face.

    Ratings:
    +132 / 0 / -0
    now im getting a syntax error whenever I use AIDS, getting this: AIDS error.png

    am i doing something wrong? should i be using vjass?
     
  11. Dirac

    Dirac 22710180

    Ratings:
    +147 / 0 / -0
    Looks like you don't have the latest version of the JassHelper, check the sticky in the WEHZ page for more info on the JassNewGenPack 1.5.
    static if are an special tool for programming that check for constant booleans and decides whether or not the code below should be compiled. Example
    JASS:
    static if LIBRARY_AIDS then
        globals
            integer Index = 0
        endglobals
    endif
    In that case if the user doesn't have AIDS in his map the global won't exist.
     
    • Like Like x 1
  12. Bribe

    Bribe vJass errors are legion

    Ratings:
    +67 / 0 / -0
    Well bad example because vJass bugs with globals in static if's, it creates it anyway because it parses globals before static if's.
     
  13. Dirac

    Dirac 22710180

    Ratings:
    +147 / 0 / -0
    Rofl correct, forgot about that bug.

    On a side-note, i've found this bug that both UnitIndexer and AIDS have when it comes to event-firing of preplaced units, the thing is, it doesn't happen.
    Yes, preplaced units gain their custom value once the map is initialized, but the events are added to functions on unit indexation AFTER the indexation per se happens.
    Any ideas on how to solve this?
     
  14. Bribe

    Bribe vJass errors are legion

    Ratings:
    +67 / 0 / -0
    It works fine with UnitIndexer if you use the current version. It was updated a few months ago to support that.
     
  15. Jesus4Lyf

    Jesus4Lyf Good Idea™

    Ratings:
    +394 / 0 / -0
    There's an even better bug Azlier once pointed out about units with auto-cast activated abilities being issued orders before the enters region boolexpr fires. Get with the times, people! :p

    I think this applies to most indexing systems, and is easy to solve. Can't remember if I ever did address that one.

    Not saying I can't/won't address these things, I just have slightly more pressing things atm.
     
  16. JJooKKoo

    JJooKKoo New Member

    Ratings:
    +0 / 0 / -0
    I have a question how can i take the struct that i assign to unit.I use these two bot non of them works
    Code:
    local MyUnitStruct uData = GetUnitId(GetTriggerUnit())
     
    local MyUnitStruct uData = GetUnitIndex(GetTriggerUnit())
     
    
    i made the struct AIDS struct with //! runtextmacro AIDS()

    edit:
    I found what is wrong now i use this
    Code:
    local MyUnitStruct uData = MyUnitStruct[GetTriggerUnit()]
    but when i initialize the struct members in method AIDS_onCreate and use to say set this.i = 100
    and when i take the value from struct is is 0 .So please smoebody help me

    EDIT2:
    It initialize the members of the struct for dynamic added units but not for units plased in editor.So why this hapen
     
  17. Ice Snake

    Ice Snake Member

    Ratings:
    +3 / 0 / -0
    Hi all, I need help!
    How to use both PUI and AIDS in my map, when I enable both PUI and AIDS in my map, it shows error: Textmacro redeclared.
    If it is double funtion name then I can fix, but macro is out of my knowledge. :(

    Anyone help me. I want to use MoveSpeedX in my map
    http://www.thehelper.net/threads/movespeedx.119384/
     

Share This Page