constant unittype UNIT_TYPE_CUSTOM

[XeRo13g]

I've made several tests and searched around but I've found nothing...

Is there a way to add new classifications to be used with IsUnitType native?
That could really make things 1000% easier.

Thnx.-

 

[Dirac]

[ljass]UnitAddType(unit,unittype)[/ljass]

 

[XeRo13g]

[ljass]UnitAddType(unit,unittype)[/ljass]

I've tried to declare something like this in the globals:

constant unittype UNIT_TYPE_NEW = ConvertUnitType(27)

But when I use what you suggested, it's not detected by IsUnitType... What am I doing wrong?

 

[Dirac]

New classifications besides the ones imposed by warcraft? No.

You would have to create a struct that reads unit's custom value and have multiple "pseudo" types created into it

struct CustomUnitType extends array
    
    boolean fish
    boolean unicorn
    
    static method makeFish takes unit whichUnit returns nothing
        local thistype this=GetUnitUserData(whichUnit)
        set this.fish=true
    endmethod
    
    static method isFish takes unit whichUnit returns boolean
        return thistype(GetUnitUserData(whichUnit).fish
    endmethod
    
endstruct

 

[XeRo13g]

Thanks for the answer.
The problem is that I've read about structs yesterday for the first time and from what I understand, you need a specific unit for using it, not a unit type.

In this particular instance, I need the classification to distinguish 'sold units'.
If I'm to run the method to attach a new classification to each sold unit, it defeats the purpose of the actual classification. I just wanted to make the code more adjustable and avoid a very long:

If u=='xxxx' and u=='xxxy' or u=='xxyy' etc

Of course, since I'm not very familiar with structs, I might be easily wrong.

 

[Dirac]

Ok this is what I understand from what you're telling me.
You want units of type [ljass]'xxxx'[/ljass] to have an specific type.
There are 2 ways of doing it.

First way, add the type for each unit once it enters the map, using an unit indexer, like AIDS

struct CustomTypeIndexer extends array
    
    boolean fish
    
    method AIDS_onIndex takes nothing returns nothing
        if GetUnitTypeId(this.unit)=='xxxx' then
            set this.fish=true
        endif
    endmethod
    
    //! runtextmacro AIDS()

endstruct

That way provides flexibility, if you later want that unit to stop being a fish you can revert it
To check do [ljass]CustomTypeIndexer[GetUnitUserData(unit)].fish==true[/ljass]

The other way doesn't provide that type of flexibility and uses Hashtables

globals
    private Table UNIT_TYPE_FISH
endglobals


function onInit takes nothing returns nothing
    set UNIT_TYPE_FISH=Table.create()
    
    set UNIT_TYPE_FISH.boolean['xxxx']=true
endfunction

To check do [ljass]UNIT_TYPE_FISH.boolean['xxxx']==true[/ljass]

 

[XeRo13g]

Thanks, very helpful indeed.

 

[Laiev]

Actually Dirac :O you could inline it |:

struct CustomTypeIndexer extends array
    boolean fish
    
    method AIDS_onIndex takes nothing returns nothing
            set this.fish = GetUnitTypeId(this.unit) == 'xxxx'
    endmethod
    
    //! runtextmacro AIDS()
endstruct

 

[luorax]

There's no AIDS_onIndex method atm.

struct CustomTypeIndexer extends array
    boolean fish
    
    method AIDS_onCreate takes nothing returns nothing
        set this.fish = GetUnitTypeId(this.unit) == 'xxxx'
    endmethod
    
    //! runtextmacro AIDS()
endstruct

Your way Dirac would also leave "fish" as true once the unit gets deindexed, and since "[]" uses the unit's custom index to return the struct instance (that will be given to the unit no matter whant "AIDS_filter" returns), it might return invalid information if a non-fish unit inherits a fish's old id.

 

[Dirac]

I never use AIDS, sue me.
And those were examples, he should write it his own way

I already told Laiev on skype, but idk why i never saw that i could do it that way. Very nice

 

[luorax]

Well, I still stick to J4L's resources, 'cuz I prefer readibility and usefulness, that minor speed gain doesn't bother me (Laiev uses/used AIDS tho' and he didn't notice it either)

Well, inlining booleans that way is indeed very nice, I was a little but surprised too when I saw them first time in a TextTag library.

 

[Dirac]

Some people mess up from time to time

 

[XeRo13g]

It seems that after a good night sleep, I've come to realize that there are many ways to make such classification but not in the "logically correct" way I was trying to. Using: Unit has an ability, is flying, is ranger and so on...would have the desired effects as far as my current problem concerns. I'm just posting this, just in case it helps someone, somewhere.

Thanks everyone for the useful suggestions, +rep

PS. Dirac, even though I've managed to give you +rep, you seem to be more helpful than the reputation limitations allow; Thus I always find difficult to grant you rep

 

[luorax]

Using: Unit has an ability

Creating dummy abils based on "Sphere" is a good way for sure, I'm using it to create custom "classifications" such as "Dummy Unit", "Hero", "Out This Dimension", etc.