Game Freezing

[somesexyguy]

Hello, me again. I have developed a simple ranking system where every 5 levels, a player increases in rank, which enables abilities that are unlocked after every promotion. When a hero levels up to another rank, the upgrade "hero rank" is increased to match the level of the rank ability, which tells the player which rank he/she is. but whenever a hero ranks up, it freezes, and i am unsure why. perhaps someone can point out what it is...

Increase
    Events
        Unit - A unit Gains a level
    Conditions
    Actions
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                (Hero level of (Triggering unit)) Equal to 5
            Then - Actions
                Game - Display to (All players) the text: |CFF00AEEBYou Have ...
                Player - Set the current research level of Rank: Private  to 2 for (Owner of (Triggering unit))
                Unit - Set level of Hero Rank  for (Triggering unit) to (Current research level of Rank: Private  for (Owner of (Triggering unit)))
            Else - Actions
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        (Hero level of (Triggering unit)) Equal to 10
                    Then - Actions
                        Game - Display to (All players) the text: |CFF00AEEBYou Have ...
                        Player - Set the current research level of Rank: Private  to 3 for (Owner of (Triggering unit))
                        Unit - Set level of Hero Rank  for (Triggering unit) to (Current research level of Rank: Private  for (Owner of (Triggering unit)))
                    Else - Actions
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                (Hero level of (Triggering unit)) Equal to 15
                            Then - Actions
                                Game - Display to (All players) the text: |CFF00AEEBYou Have ...
                                Player - Set the current research level of Rank: Private  to 4 for (Owner of (Triggering unit))
                                Unit - Set level of Hero Rank  for (Triggering unit) to (Current research level of Rank: Private  for (Owner of (Triggering unit)))
                            Else - Actions
                                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                    If - Conditions
                                        (Hero level of (Triggering unit)) Equal to 20
                                    Then - Actions
                                        Game - Display to (All players) the text: |CFF00AEEBYou Have ...
                                        Player - Set the current research level of Rank: Private  to 5 for (Owner of (Triggering unit))
                                        Unit - Set level of Hero Rank  for (Triggering unit) to (Current research level of Rank: Private  for (Owner of (Triggering unit)))
                                    Else - Actions
                                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                            If - Conditions
                                                (Hero level of (Triggering unit)) Equal to 25
                                            Then - Actions
                                                Game - Display to (All players) the text: |CFF00AEEBYou Have ...
                                                Player - Set the current research level of Rank: Private  to 6 for (Owner of (Triggering unit))
                                                Unit - Set level of Hero Rank  for (Triggering unit) to (Current research level of Rank: Private  for (Owner of (Triggering unit)))
                                            Else - Actions
                                                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                                    If - Conditions
                                                        (Hero level of (Triggering unit)) Equal to 30
                                                    Then - Actions
                                                        Game - Display to (All players) the text: |CFF00AEEBYou Have ...
                                                        Player - Set the current research level of Rank: Private  to 7 for (Owner of (Triggering unit))
                                                        Unit - Set level of Hero Rank  for (Triggering unit) to (Current research level of Rank: Private  for (Owner of (Triggering unit)))
                                                    Else - Actions
                                                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                                            If - Conditions
                                                                (Hero level of (Triggering unit)) Equal to 35
                                                            Then - Actions
                                                                Game - Display to (All players) the text: |CFF00AEEBYou Have ...
                                                                Player - Set the current research level of Rank: Private  to 8 for (Owner of (Triggering unit))
                                                                Unit - Set level of Hero Rank  for (Triggering unit) to (Current research level of Rank: Private  for (Owner of (Triggering unit)))
                                                            Else - Actions
                                                                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                                                    If - Conditions
                                                                        (Hero level of (Triggering unit)) Equal to 40
                                                                    Then - Actions
                                                                        Game - Display to (All players) the text: |CFF00AEEBYou Have ...
                                                                        Player - Set the current research level of Rank: Private  to 9 for (Owner of (Triggering unit))
                                                                        Unit - Set level of Hero Rank  for (Triggering unit) to (Current research level of Rank: Private  for (Owner of (Triggering unit)))
                                                                    Else - Actions
                                                                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                                                            If - Conditions
                                                                                (Hero level of (Triggering unit)) Equal to 45
                                                                            Then - Actions
                                                                                Game - Display to (All players) the text: |CFF00AEEBYou Have ...
                                                                                Player - Set the current research level of Rank: Private  to 10 for (Owner of (Triggering unit))
                                                                                Unit - Set level of Hero Rank  for (Triggering unit) to (Current research level of Rank: Private  for (Owner of (Triggering unit)))
                                                                            Else - Actions
                                                                                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                                                                    If - Conditions
                                                                                        (Hero level of (Triggering unit)) Equal to 50
                                                                                    Then - Actions
                                                                                        Game - Display to (All players) the text: |CFF00AEEBYou Have ...
                                                                                        Player - Set the current research level of Rank: Private  to 11 for (Owner of (Triggering unit))
                                                                                        Unit - Set level of Hero Rank  for (Triggering unit) to (Current research level of Rank: Private  for (Owner of (Triggering unit)))
                                                                                    Else - Actions

 

[Exide]

I can't see anything that will cause the game to crash in this trigger.
However, I don't like the one million If / Then / Else functions on top of eachother like that.
"Elseif" might do the trick for you, there.

Are you sure that this trigger causes the crash? (Are there any other trigger with the same, or similar event?)
Try disabling this trigger and test the game again, to be sure.

 

[131ackout]

It's freezing because there's like a million actions and If / Then / Else function..

Just simple make a trigger that when the event that the hero gains level..

Then the condition was the unit-type of that hero and level equals to 5..

Then the action are what the hero is removed and created it at that where the place that old hero is removed.
That way, you don't have the leak actions and triggers..

 

[Exide]

I wrote a small piece of JASS, using elseif. It looks like this:

function Trig_Increase_Actions takes nothing returns nothing
    local integer UnitLevel = GetUnitLevel(GetTriggerUnit())

    if UnitLevel == 5 then
      //Your Actions Here.
      elseif UnitLevel == 10 then
        //Your Actions Here.
      elseif UnitLevel == 15 then
        //Your Actions Here..
      elseif UnitLevel == 20 then
        //And so on..
      elseif UnitLevel == 50 then
        //Your Actions Here.
    endif 

endfunction

function InitTrig_Increase takes nothing returns nothing
    local trigger gg_trg_Increase = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Increase, EVENT_PLAYER_HERO_LEVEL )
    call TriggerAddAction( gg_trg_Increase, function Trig_Increase_Actions )  
endfunction

-All you need to add is your actions, where it says "//Your Actions Here.".

 

[somesexyguy]

well I'm not replacing a hero, all the trigger does is level up the upgrade and the ability called "Hero Rank". And i just finished testing it with only ranking up when a hero reaches level 5, and it still freezes up, so my guess it has something to do with leveling up the upgrade or the ability.

 

[vypur85]

Increase
    Events
        Unit - A unit Gains a level
    Conditions
    Actions
        For every Integer A 1 to 10 loop do actions
           Loop - Actions
               If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                   If - Conditions
                       (Hero level of (Triggering unit)) Equal to (Integer A * 5) 
                   Then - Actions
                       Game - Display to (All players) the text: |CFF00AEEBYou Have ...
                       Player - Set the current research level of Rank: Private  to (Integer A + 1) for (Owner of (Triggering unit))
                       Unit - Set level of Hero Rank  for (Triggering unit) to (Current research level of Rank: Private  for (Owner of (Triggering unit)))
                   Else - Actions

Simplified version. Not sure why it 'freezes' though. Define 'freeze'. It had a moment of lag or the game crashes?


> It's freezing because there's like a million actions and If / Then / Else function..
Lol... This is not true.

 

[somesexyguy]

well, when it "freezes" the screen freezes up, everything stops working, and it does it to other players as well. It does so after it performs the actions, such as display the message and level up the ability and upgrade, but i will try the trigger above, seems much more efficient. Thank you.




-Update: Yes! I Finally found out what the problem was, in the end, it wasn't the trigger that was flawed, but the hero rank ability itself; I based this ability off of "pillage" which I'm guess cannot be leveled and caused the freeze. I am now using a different ability and it works out fine. Thanks to everyone who helped me.